From mboxrd@z Thu Jan 1 00:00:00 1970 From: vigneshr@ti.com (Vignesh R) Date: Thu, 10 Nov 2016 10:37:12 +0530 Subject: [PATCH] drivers: mfd: ti_am335x_tscadc: increase ADC ref clock to 24MHz In-Reply-To: References: <20161024060226.4170-1-mugunthanvnm@ti.com> <038C6B01-8443-4321-9C65-BAC4095237D3@gmail.com> <086ab2fa-63ee-c5ab-2715-b2efd78270d7@ti.com> <12725C92-9BB8-4F77-A7B4-F3C3DA9F8B0B@gmail.com> <20161025063847.GD8574@dell> <20161026084811.GI8574@dell> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thursday 10 November 2016 05:23 AM, John Syne wrote: > OK, then back to my original question. Given that these DT properties are supported in the driver > Below properties are supported by only by ti_am3335x_adc driver and not ti_am335x_tsc driver. As author of this patch pointed out in another reply, there is no need to change step-opendelay for tsc. AFAIK, I don't see a use case where these values needs to be tweaked for tsc channels, therefore it does not make sense to be DT properties. > shouldn?t the following be added to am33xx.dtsi and am4372.dtsi? Its totally upto board dts files to allocate channels for tsc and adc. So, how could these be added to dtsi files? > ti,chan-step-avg = <0x16 0x16 0x16 0x16 0x16 0x16 0x16>; > ti,chan-step-opendelay = <0x500 0x500 0x500 0x500 0x500 0x500 0x500>; > ti,chan-step-sampledelay = <0x0 0x0 0x0 0x0 0x0 0x0 0x0>; > > Regards, > John >> >> -- >> Regards >> Vignesh > -- Regards Vignesh