From mboxrd@z Thu Jan 1 00:00:00 1970 From: thor.thayer@linux.intel.com (Thor Thayer) Date: Tue, 1 Aug 2017 13:57:59 -0500 Subject: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h In-Reply-To: <1499140415-31677-1-git-send-email-yamada.masahiro@socionext.com> References: <1499140415-31677-1-git-send-email-yamada.masahiro@socionext.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/03/2017 10:53 PM, Masahiro Yamada wrote: > Some of include directives in include/linux/gpio/driver.h are > unneeded because the header does not need to know the content of > struct device, irq_chip, etc. Just declare they are structures. > > On the other hand, and > turned out to be necessary for irq_flow_handler_t and spinlock_t, > respectively. > > Each driver should include what it needs without relying on what is > implicitly included from . This will cut down > unnecessary header parsing. > > Signed-off-by: Masahiro Yamada > --- > > drivers/gpio/gpio-altera-a10sr.c | 2 ++ > drivers/gpio/gpio-altera.c | 3 +++ For the Altera GPIO files: Acked-by: Thor Thayer