From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47D5BCD11DF for ; Tue, 26 Mar 2024 09:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ghM8/sXg6s2klyg0yJbw64kb2/cUAlKPTjCNx2pmf0k=; b=s0OKUgEMGVL55M dmtzQos5kLzfuM32hWIgF0R00slWOivJKPE+yvSgpQzdD4QAT8jy08tB53q42LDywk6iiU3q905P8 /ul4u0RBdg4v2IKSyr/Jcj/8+M5/1lYIlSnLM4kLAaG+PlIKE92V/GDGEzr/JDCxmu4wZPS9s7JIp ZFUdFWCAof2yzEe6P4LHjBMByhIhdGMPiVFzarKR4kCJ5HVo4mq+UPp1i02gxL2k3Fno3HU3Ha6S1 0oF35NkNAN8qcx3w7yWl6tVmoBoag0f5/PRhjLlJK9MtxdmizcPEqNxtXa0oRxUWJ5O8q7IwIjRqT cHKUh8BVyvszfTqj1LWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp3LS-00000003sL1-42BO; Tue, 26 Mar 2024 09:43:51 +0000 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp3LQ-00000003sJd-0dcb for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 09:43:49 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 7747711400F5; Tue, 26 Mar 2024 05:43:43 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 26 Mar 2024 05:43:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1711446223; x=1711532623; bh=3LqOQeorRq VxwortoMJ5JQKfcQyoSTQmX4p96tNt/c8=; b=OuKLU3QuihiiwgBCbZEQK7A45K B3lVzNmYyadgFqMqA2Q4hC8brf2EqPlDL/DGSaK21DCyriVX+bjsYBrtROhZILKq 2d95iG2GV5K1D4CJlgLYX7SWq0/RFP9UJKXBK3hALRAZ3f6Hub453qWFS6bFNhkV WoNyr4AdiRyUk5CG2OyTslRnZEHmvY5uUzyRhGWm5oKSkPaGISwfMAPPqNp1+plj FQfqP4+YQZrGquZsB0nrvWqaktHwY7gG4qOurqj53cl6csvSWPyZxyLKUds39Ok9 onV6FEKuOzWsy2ynfY33q6/fyGmjyzVcP8J+oJrqGNT3oy6WHYbcP4RtYHZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1711446223; x=1711532623; bh=3LqOQeorRqVxwortoMJ5JQKfcQyo STQmX4p96tNt/c8=; b=PpyYnb3LrY/7ZTDL4rfJTuXaxMWpw+VlRhYObKM6qF9/ Ueux2FolnCugyuwE/t8TsHLSASnOzmzv2h6cc76sE6GMqRNPWFybek8nLU9iAbYE oAQUHRwJpvIzqCZ5NVkW+u//F5bn2PZeytmK+qPVe0eUeSfj1/d4kDda4aSp91jO SOFOppLTffK/PrnUfmuW7kvYHsXVftDnpC1s0ZhEWs+D2NYrPK22WmWQjmf68Upa EvX/b5X/BrGh8ryLD/rDY4GmJceCCVkvPVxwVXhd9a3FDyA/slViMgBGBREA9Yrx pefb5Aiqv/PJjZnA1tdCKBAJPeNeK3jWVEQzoH7cnA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddufedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5E83DB6008D; Tue, 26 Mar 2024 05:43:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-328-gc998c829b7-fm-20240325.002-gc998c829 MIME-Version: 1.0 Message-Id: In-Reply-To: <20240326-ep93xx-v9-32-156e2ae5dfc8@maquefel.me> References: <20240326-ep93xx-v9-0-156e2ae5dfc8@maquefel.me> <20240326-ep93xx-v9-32-156e2ae5dfc8@maquefel.me> Date: Tue, 26 Mar 2024 10:43:22 +0100 From: "Arnd Bergmann" To: "Nikita Shubin" , "Russell King" , "Hartley Sweeten" , "Alexander Sverdlin" , "Andrew Davis" , "Nicolas Schier" , "Daniel Golle" , "Masahiro Yamada" , "Neil Armstrong" , "Dmitry Baryshkov" Cc: "Bjorn Andersson" , "Russell King" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 32/38] ARM: ep93xx: DT for the Cirrus ep93xx SoC platforms X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_024348_307364_B634EB61 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2024, at 10:18, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin > > Add compulsory device tree support to the Cirrus ep93xx ARMv4 platform. > > - select PINCTRL_EP93xx > - select COMMON_CLK_EP93XX, as clock driver moved out of platform code > - select ARCH_HAS_RESET_CONTROLLER > > Select ARM_ATAG_DTB_COMPAT to update device tree with information > about memory passed from bootloader. > > We have to leave all MACH options as they are used for board checking > before decomp, to turn off watchdog and ethernet DMA. > > Tested-by: Alexander Sverdlin > Signed-off-by: Nikita Shubin > --- > select ARCH_SPARSEMEM_ENABLE > select ARM_AMBA > select ARM_VIC > + select ARM_APPENDED_DTB # Old Redboot bootloaders deployed > + select ARM_ATAG_DTB_COMPAT # we need this to update dt memory node I would drop these two 'select' statements: while it is a reasonable assumption that the boot loaders are never going to be fixed, this is not something that's up to the kernel. We have other platforms that are in the same situation, and they just enable those options through the defconfig, as they are user-visible. > + select COMMON_CLK_EP93XX > + select EP93XX_TIMER > select CLKSRC_MMIO > select CPU_ARM920T > select GPIOLIB > + select PINCTRL > + select PINCTRL_EP93XX If these options are user visible, I would prefer to leave these up to the defconfig as well, but that's not as important and something we do in other platforms as well. In general, I'd prefer to keep 'select' statements to a minimum though. > -obj-y := core.o clock.o timer-ep93xx.o > - > -obj-$(CONFIG_EP93XX_DMA) += dma.o > - > -obj-$(CONFIG_MACH_EDB93XX) += edb93xx.o > -obj-$(CONFIG_MACH_TS72XX) += ts72xx.o > -obj-$(CONFIG_MACH_VISION_EP9307)+= vision_ep9307.o The Makefile changes should be grouped together with whichever patch removes the individual files. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel