From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB08FC352A4 for ; Mon, 10 Feb 2020 07:30:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96FFC20870 for ; Mon, 10 Feb 2020 07:30:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O4uYd+Zu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96FFC20870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=se1POzZfjOZreadtxKcmzXHIT9iGr5VmxIyiCwfilhw=; b=O4uYd+ZuFclaw6 JUBOoiLsGg1dDvLAFqTBXnhiXBGkKUgVHJvLhAPcl0Wn6kBMZy4phCkkbnUhnwBC8Ny65+Z3raf13 yUmgHV+LlFw5rcnHQHrUhyYdxjzuLKKOTBY2pdj5gstkMruSFf5o/ncC+4CTxcPWvcV8rSIFm/l19 5w50NLsmWcK9j7ViaDyhNQGRxCvxyUl+CQ0VntmUhUSmz/kZGl3d2INF5ZzpXZaVdPe0px7+93ew7 UzkxPxmTOPieWy3Hmop0GJTyTkKnAdHGd/LmOdh2tYTMF8cJbpQMoYkJ5Tf0M2vEWAH/lIt88ifCD /gIs6RcVSTndrnik6sEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j13W1-0002F1-25; Mon, 10 Feb 2020 07:29:57 +0000 Received: from kernel.crashing.org ([76.164.61.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j13Vx-0002CI-PL for linux-arm-kernel@lists.infradead.org; Mon, 10 Feb 2020 07:29:55 +0000 Received: from localhost (gate.crashing.org [63.228.1.57]) (authenticated bits=0) by kernel.crashing.org (8.14.7/8.14.7) with ESMTP id 01A7TN4p010982 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 10 Feb 2020 01:29:29 -0600 Message-ID: Subject: Re: [PATCH 2/3] usb: gadget: aspeed: add ast2600 vhub support From: Benjamin Herrenschmidt To: Joel Stanley , Tao Ren Date: Mon, 10 Feb 2020 08:29:22 +0100 In-Reply-To: References: <20200131222157.20849-1-rentao.bupt@gmail.com> <20200131222157.20849-3-rentao.bupt@gmail.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200209_232954_025765_5A10A579 X-CRM114-Status: GOOD ( 19.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Felipe Balbi , linux-aspeed , devicetree , Andrew Jeffery , Greg Kroah-Hartman , OpenBMC Maillist , linux-usb@vger.kernel.org, Linux Kernel Mailing List , Stephen Boyd , Rob Herring , Chunfeng Yun , Colin Ian King , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-02-10 at 02:48 +0000, Joel Stanley wrote: > On Fri, 31 Jan 2020 at 22:22, wrote: > > > > From: Tao Ren > > > > Add AST2600 support in aspeed-vhub driver. There are 3 major differences > > between AST2500 and AST2600 vhub: > > - AST2600 supports 7 downstream ports while AST2500 supports 5. > > - AST2600 supports 21 generic endpoints while AST2500 supports 15. > > - EP0 data buffer's 8-byte DMA alignment restriction is removed from > > AST2600. > > > > Signed-off-by: Tao Ren > > Reviewed-by: Andrew Jeffery Travelling at the moment so my review might be a bit delayed. Also for some reason I missed your original submission, sorry about that, please poke me next time if I don't reply within a couple of days ! One thing to look into as well is the 2600 has revived the "device controller" which looks like a cut down version of a vhub device, so we should break a bit more the linkage between vhub and the underlying devices so the latter can be instanciated standalone... (Foor for thought, I'm not asking you to do that right now) Cheers, Ben. > Reviewed-by: Joel Stanley > > > --- > > drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 4 ++-- > > drivers/usb/gadget/udc/aspeed-vhub/core.c | 9 +++++++++ > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig > > index 83ba8a2eb6af..605500b19cf3 100644 > > --- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig > > +++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig > > @@ -4,5 +4,5 @@ config USB_ASPEED_VHUB > > depends on ARCH_ASPEED || COMPILE_TEST > > depends on USB_LIBCOMPOSITE > > help > > - USB peripheral controller for the Aspeed AST2500 family > > - SoCs supporting the "vHub" functionality and USB2.0 > > + USB peripheral controller for the Aspeed AST2400, AST2500 and > > + AST2600 family SoCs supporting the "vHub" functionality and USB2.0 > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c b/drivers/usb/gadget/udc/aspeed-vhub/core.c > > index 94081cc04113..c827bf420278 100644 > > --- a/drivers/usb/gadget/udc/aspeed-vhub/core.c > > +++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c > > @@ -42,6 +42,11 @@ static const struct ast_vhub_config ast2400_config = { > > .max_epns = 15, > > }; > > > > +static const struct ast_vhub_config ast2600_config = { > > + .max_ports = 7, > > + .max_epns = 21, > > +}; > > + > > static const struct of_device_id ast_vhub_dt_ids[] = { > > { > > .compatible = "aspeed,ast2400-usb-vhub", > > @@ -51,6 +56,10 @@ static const struct of_device_id ast_vhub_dt_ids[] = { > > .compatible = "aspeed,ast2500-usb-vhub", > > .data = &ast2400_config, > > }, > > + { > > + .compatible = "aspeed,ast2600-usb-vhub", > > + .data = &ast2600_config, > > + }, > > { } > > }; > > MODULE_DEVICE_TABLE(of, ast_vhub_dt_ids); > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel