From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94787C001DF for ; Tue, 1 Aug 2023 16:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kwK1wixLBOkYCTuGcPO4DWCWn73FpFiWhK/GtNlJDqM=; b=wbhAeQzIBJf+1E UeKt1ZFD/tL4/Jh1Omq9Z1asEY648SQZ9MGafHqonjuUJfamhu5UHbF+p2iAUlxEFvpLi4MYjKzOq O7HSRL55voeIb4uPuTN2VeFtrFNLMRtrT/7hje/dLpvgGWlODeC0NmqSjICBPo2E0uKtlHnyOXiKX y5P1c5UoMNf7ufj+SzO5NiTAsvPJD083JxFCDpn/UM5YSbIxJsh48CHdQ9EkXPVnAOAacqDqYssyR LK6U9L0nrRr/hwrm93HqWmFikQ7PY22zuGbWurc0mH6JwBhw4+FdoSm0E8SRPqRm6UrDA4KdkDwVt kNQhOPcyFpMqDlEo9IKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQsXe-002qNM-38; Tue, 01 Aug 2023 16:48:14 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQsXb-002qMp-0X for linux-arm-kernel@lists.infradead.org; Tue, 01 Aug 2023 16:48:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6699361634; Tue, 1 Aug 2023 16:48:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52CB7C433C8; Tue, 1 Aug 2023 16:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690908489; bh=dAGSBpdgP559FQfd7iCLmLEEcO7xGZkJcOuwn1Nlil8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sqaFUW4wBrWJpdPRWZQ+TG6HaObURMrJlIV6GAauSFNYhfGFydQ4LxHDHTjxSvPFk O7B8W6EYZoXFN87b/qwxYqjdlQKhxFi4yGBQJjOKvITbyIWaoxqFO+zUTWZchWI26M 7ASrONtD1obsvVpEl5VCmLlp9dkg/ga0RdaVRUkcmNSSZjJqC1nU/nt/dZxfozqE9P ISypzgMxpl4y0WtVNOMjvaikAJW+gRQSHsAf8SQyEPWINNoH19S2gbG92EsMTwror+ +EDrK7whevGWqUGxwk6FnIoxyI+KBKY9Sj1TKwFPCn2EXt5K9HLRCCXRIVlHEuu5TM hQg/icLzo7NVQ== Message-ID: Date: Tue, 1 Aug 2023 19:48:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v8 5/5] arm64: dts: ti: k3-am69-sk: Add DP and HDMI support Content-Language: en-US To: Jayesh Choudhary , nm@ti.com, vigneshr@ti.com, Tomi Valkeinen Cc: s-vadapalli@ti.com, afd@ti.com, kristo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, a-bhatia1@ti.com, r-ravikumar@ti.com, sabiya.d@ti.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230801070019.219660-1-j-choudhary@ti.com> <20230801070019.219660-6-j-choudhary@ti.com> From: Roger Quadros In-Reply-To: <20230801070019.219660-6-j-choudhary@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_094811_325481_C3D37A67 X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/08/2023 10:00, Jayesh Choudhary wrote: > From: Dasnavis Sabiya > > AM69 starter kit features an HDMI port and an eDP port. > > Add assigned clocks for DSS, DT node for DisplayPort PHY, > pinmux for HDMI hotplug and power down, mcu_i2c1 and dss_vout > for HDMI. > Also enable Serdes4 settings for DP display. > > Add the endpoint nodes to describe connection from: > DSS => MHDP => DisplayPort connector > DSS => TI TFP410 DPI-to-DVI Bridge => HDMI connector > > Signed-off-by: Dasnavis Sabiya > [j-choudhary@ti.com: Fix dvi-bridge, dss, mhdp and serdes-refclk] > Signed-off-by: Jayesh Choudhary > --- > arch/arm64/boot/dts/ti/k3-am69-sk.dts | 237 ++++++++++++++++++++++++++ > 1 file changed, 237 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts > index d282c2c633c1..d9a0794bcf6e 100644 > --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts > @@ -107,6 +107,83 @@ vdd_sd_dv: regulator-tlv71033 { > states = <1800000 0x0>, > <3300000 0x1>; > }; > + > + dp0_pwr_3v3: regulator { To be consistent with the rest of the file please use regulator-dp0-pwr > + compatible = "regulator-fixed"; > + regulator-name = "dp0-pwr"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&dp_pwr_en_pins_default>; > + gpio = <&main_gpio0 4 0>; /* DP0_3V3 _EN */ > + enable-active-high; > + }; > + > + dp0: connector { connector-dp0 > + compatible = "dp-connector"; > + label = "DP0"; > + type = "full-size"; > + dp-pwr-supply = <&dp0_pwr_3v3>; > + > + port { > + dp0_connector_in: endpoint { > + remote-endpoint = <&dp0_out>; > + }; > + }; > + }; > + > + hdmi-connector { connector-hdmi > + compatible = "hdmi-connector"; > + label = "hdmi"; > + type = "a"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&hdmi_hpd_pins_default>; > + > + ddc-i2c-bus = <&mcu_i2c1>; > + > + /* HDMI_HPD */ > + hpd-gpios = <&main_gpio0 0 GPIO_ACTIVE_HIGH>; > + > + port { > + hdmi_connector_in: endpoint { > + remote-endpoint = <&tfp410_out>; > + }; > + }; > + }; > + > + dvi-bridge { Although DT binding doc for ti,tfp410 says encoder a name starting with bridge maybe more appropriate. > + compatible = "ti,tfp410"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&hdmi_pdn_pins_default>; > + > + /* HDMI_PDn */ > + powerdown-gpios = <&wkup_gpio0 14 GPIO_ACTIVE_LOW>; > + ti,deskew = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + tfp410_in: endpoint { > + remote-endpoint = <&dpi1_out0>; > + pclk-sample = <1>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + tfp410_out: endpoint { > + remote-endpoint = <&hdmi_connector_in>; > + }; > + }; > + }; > + }; > }; > > &main_pmx0 { > @@ -161,6 +238,57 @@ J784S4_IOPAD(0x008, PIN_INPUT, 7) /* (AJ33) MCAN12_RX.GPIO0_2 */ > J784S4_IOPAD(0x004, PIN_INPUT, 7) /* (AG36) MCAN12_TX.GPIO0_1 */ > >; > }; > + > + dp0_pins_default: dp0-pins-default { > + pinctrl-single,pins = < > + J784S4_IOPAD(0x014, PIN_INPUT, 13) /* (AG33) MCAN14_TX.DP0_HPD */ > + >; > + }; > + > + dp_pwr_en_pins_default: dp-pwr-en-pins-default { > + pinctrl-single,pins = < > + J784S4_IOPAD(0x010, PIN_INPUT, 7) /* (AH33) MCAN13_RX.GPIO0_4 */ > + >; > + }; > + > + dss_vout0_pins_default: dss-vout0-pins-default { > + pinctrl-single,pins = < > + J784S4_IOPAD(0x074, PIN_OUTPUT, 2) /* (AC33) MCAN2_TX.VOUT0_DATA0 */ > + J784S4_IOPAD(0x070, PIN_OUTPUT, 2) /* (AH38) MCAN1_RX.VOUT0_DATA1 */ > + J784S4_IOPAD(0x07c, PIN_OUTPUT, 2) /* (AJ38) MCASP0_AXR3.VOUT0_DATA2 */ > + J784S4_IOPAD(0x068, PIN_OUTPUT, 2) /* (AE38) MCAN0_RX.VOUT0_DATA3 */ > + J784S4_IOPAD(0x064, PIN_OUTPUT, 2) /* (AF38) MCAN0_TX.VOUT0_DATA4 */ > + J784S4_IOPAD(0x060, PIN_OUTPUT, 2) /* (AE36) MCASP2_AXR1.VOUT0_DATA5 */ > + J784S4_IOPAD(0x05c, PIN_OUTPUT, 2) /* (AC36) MCASP2_AXR0.VOUT0_DATA6 */ > + J784S4_IOPAD(0x058, PIN_OUTPUT, 2) /* (AE37) MCASP2_AFSX.VOUT0_DATA7 */ > + J784S4_IOPAD(0x054, PIN_OUTPUT, 2) /* (AD37) MCASP2_ACLKX.VOUT0_DATA8 */ > + J784S4_IOPAD(0x050, PIN_OUTPUT, 2) /* (AC37) MCASP1_AXR2.VOUT0_DATA9 */ > + J784S4_IOPAD(0x04c, PIN_OUTPUT, 2) /* (AC32) MCASP1_AXR1.VOUT0_DATA10 */ > + J784S4_IOPAD(0x048, PIN_OUTPUT, 2) /* (AK33) MCASP0_AXR2.VOUT0_DATA11 */ > + J784S4_IOPAD(0x044, PIN_OUTPUT, 2) /* (AG37) MCASP0_AXR1.VOUT0_DATA12 */ > + J784S4_IOPAD(0x040, PIN_OUTPUT, 2) /* (AF37) MCASP0_AXR0.VOUT0_DATA13 */ > + J784S4_IOPAD(0x03c, PIN_OUTPUT, 2) /* (AK38) MCASP0_AFSX.VOUT0_DATA14 */ > + J784S4_IOPAD(0x038, PIN_OUTPUT, 2) /* (AK35) MCASP0_ACLKX.VOUT0_DATA15 */ > + J784S4_IOPAD(0x0c8, PIN_OUTPUT, 2) /* (AJ32) EXT_REFCLK1.VOUT0_DATA16 */ > + J784S4_IOPAD(0x030, PIN_OUTPUT, 2) /* (AK37) GPIO0_12.VOUT0_DATA17 */ > + J784S4_IOPAD(0x02c, PIN_OUTPUT, 2) /* (AL32) GPIO0_11.VOUT0_DATA18 */ > + J784S4_IOPAD(0x028, PIN_OUTPUT, 2) /* (AE33) MCAN16_RX.VOUT0_DATA19 */ > + J784S4_IOPAD(0x024, PIN_OUTPUT, 2) /* (AH34) MCAN16_TX.VOUT0_DATA20 */ > + J784S4_IOPAD(0x020, PIN_OUTPUT, 2) /* (AJ35) MCAN15_RX.VOUT0_DATA21 */ > + J784S4_IOPAD(0x01c, PIN_OUTPUT, 2) /* (AG34) MCAN15_TX.VOUT0_DATA22 */ > + J784S4_IOPAD(0x018, PIN_OUTPUT, 2) /* (AK36) MCAN14_RX.VOUT0_DATA23 */ > + J784S4_IOPAD(0x084, PIN_OUTPUT, 2) /* (AG38) MCASP0_AXR5.VOUT0_DE */ > + J784S4_IOPAD(0x080, PIN_OUTPUT, 2) /* (AK34) MCASP0_AXR4.VOUT0_HSYNC */ > + J784S4_IOPAD(0x078, PIN_OUTPUT, 2) /* (AH37) MCAN2_RX.VOUT0_PCLK */ > + J784S4_IOPAD(0x088, PIN_OUTPUT, 2) /* (AF36) MCASP0_AXR6.VOUT0_VSYNC */ > + >; > + }; > + > + hdmi_hpd_pins_default: hdmi-hpd-pins-default { > + pinctrl-single,pins = < > + J784S4_IOPAD(0x000, PIN_INPUT, 7) /* (AN35) EXTINTN.GPIO0_0 */ > + >; > + }; > }; > > &wkup_pmx2 { > @@ -231,6 +359,21 @@ J784S4_WKUP_IOPAD(0x064, PIN_INPUT, 7) /* (J36) WKUP_GPIO0_3 */ > J784S4_WKUP_IOPAD(0x11c, PIN_INPUT, 7) /* (M34) WKUP_GPIO0_67 */ > >; > }; > + > + mcu_i2c1_pins_default: mcu-i2c1-pins-default { > + pinctrl-single,pins = < > + /* (L35) WKUP_GPIO0_8.MCU_I2C1_SCL */ > + J784S4_WKUP_IOPAD(0x078, PIN_INPUT_PULLUP, 0) > + /* (L34) WKUP_GPIO0_9.MCU_I2C1_SDA */ > + J784S4_WKUP_IOPAD(0x07c, PIN_INPUT_PULLUP, 0) > + >; > + }; > + > + hdmi_pdn_pins_default: hdmi-pdn-pins-default { > + pinctrl-single,pins = < > + J784S4_WKUP_IOPAD(0x090, PIN_INPUT, 7) /* (H37) WKUP_GPIO0_14 */ > + >; > + }; > }; > > &wkup_pmx3 { > @@ -350,3 +493,97 @@ &mcu_cpsw_port1 { > phy-mode = "rgmii-rxid"; > phy-handle = <&mcu_phy0>; > }; > + > +&wkup_gpio_intr { > + status = "okay"; > +}; > + > +&mcu_i2c1 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mcu_i2c1_pins_default>; > + clock-frequency = <100000>; > +}; > + > +&serdes_refclk { > + status = "okay"; > + clock-frequency = <100000000>; > +}; > + > +&dss { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&dss_vout0_pins_default>; > + assigned-clocks = <&k3_clks 218 2>, > + <&k3_clks 218 5>, > + <&k3_clks 218 14>, > + <&k3_clks 218 18>; > + assigned-clock-parents = <&k3_clks 218 3>, > + <&k3_clks 218 7>, > + <&k3_clks 218 16>, > + <&k3_clks 218 22>; > +}; > + > +&serdes_wiz4 { > + status = "okay"; > +}; > + > +&serdes4 { > + status = "okay"; > + serdes4_dp_link: phy@0 { > + reg = <0>; > + cdns,num-lanes = <4>; > + #phy-cells = <0>; > + cdns,phy-type = ; > + resets = <&serdes_wiz4 1>, <&serdes_wiz4 2>, > + <&serdes_wiz4 3>, <&serdes_wiz4 4>; > + }; > +}; > + > +&mhdp { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&dp0_pins_default>; > + phys = <&serdes4_dp_link>; > + phy-names = "dpphy"; > +}; > + > +&dss_ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* DP */ > + port@0 { > + reg = <0>; > + dpi0_out: endpoint { > + remote-endpoint = <&dp0_in>; > + }; > + }; > + > + /* HDMI */ > + port@1 { > + reg = <1>; > + dpi1_out0: endpoint { > + remote-endpoint = <&tfp410_in>; > + }; > + }; > +}; > + > +&dp0_ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + dp0_in: endpoint { > + remote-endpoint = <&dpi0_out>; > + }; > + }; > + > + port@4 { > + reg = <4>; > + dp0_out: endpoint { > + remote-endpoint = <&dp0_connector_in>; > + }; > + }; > +}; -- cheers, -roger _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel