From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA30C2D0C8 for ; Wed, 25 Dec 2019 18:50:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DC8C2067D for ; Wed, 25 Dec 2019 18:50:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wop2f7Zm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZcnzPFqW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DC8C2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oNDzherdTXE9DVGTDzyxbTLz9OiCebL0AmgQpXlFsa4=; b=Wop2f7ZmI9CKmFqAaYO08agwj Q1LECwC8exscOohadX6gZ38AuwYJ3ER0bTgtLgy2MPgck0ly7VsDDLlox32A3yQXdTc6595SM1dqn 1jeMExmSNQqg2lqNOgXl4D5GWL9vfGk8DZT4CGIn0hGDvrUX8Pjecejr5LoMMkSgkzMpqizXwCWPx g6KRKAycAGXH1PFRXRtG8XJWg1cYBtX7NPuJjpZ/AEC+C5T7IQvO6gLYxnyeDK9cAQW464x0u5XkJ p0gEm5UVyx2BEKtATz659zfNXhW9CYfCyLYDm/s59JMTdYdhZ47b+ELLleQEVzGmTFAeNO1I5YEwe KbyrkmAow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikBjJ-0006yQ-ND; Wed, 25 Dec 2019 18:49:57 +0000 Received: from us-smtp-1.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikBjF-0006xE-Oz for linux-arm-kernel@lists.infradead.org; Wed, 25 Dec 2019 18:49:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577299788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=285kDepmv9QK1DA/8vrnMjbxXwuHVWfi0yZmFm9MG4s=; b=ZcnzPFqWfq7ZHhkG3ZYYH1yDUklTgfhbTPRozc1lOFyU9JCuqhr8urQD1CIW19w/yLcSnt HJ6+nWsT/TeMGgTthwpyKpLIC48Ldh015qkafFcqamP9a/yHlZ0o3m3B52bhahS6CJS/C4 FIZkgr9OEjmNMLJEXuHenZIzCE3ovMA= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-423-jCZ6rsf9N_-eBIBnPOVTcA-1; Wed, 25 Dec 2019 13:49:47 -0500 Received: by mail-pj1-f69.google.com with SMTP id ie20so1206105pjb.8 for ; Wed, 25 Dec 2019 10:49:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=285kDepmv9QK1DA/8vrnMjbxXwuHVWfi0yZmFm9MG4s=; b=XtKV1KTDd71qcoYtFMe4VufJGon0mcVza7e7PY5r3Lwbl2DeTwtdqKcsJRI9VFs4q1 Rs6W77u7YIHjkM650WVVFxNIe+mSHcJJgiegKvyEP/H+GH3hMz+JXSWmvVbOkZfAPgbA GdArhJT7r2nMryhPBCwIAZRROmfIQZBUDnUw6ufLa8l3oAirRnD6epcHWowEo+a41RYm oBSngF5FMrc6DgyVrR72wEGy0Ct7cbxKByXgKc4bOb1nxM7k5OUCgTTosATkRhhY+MVY mEJ+6ZxAB5Nz+F4K4eKhE4RBkI7edBQbpv36td62Mjg0RnKULNdMhuPYZc68nrm9QqhR P8Xg== X-Gm-Message-State: APjAAAVv/eMVVEZGwNTYOg6pxobb/Nu8cPar/zfWdHougRr/UavDcPgF JH58V312JaS3liRs1mdnuiG2ZFdcqb/6jQR2nrcgjbpn4KW6//P5b2tyXk/sLQo2ym/LeYSuAJp v0etSdvHc0eRIgLggRe5iYNaZwRElbU+cVjE= X-Received: by 2002:a17:902:5a85:: with SMTP id r5mr43181280pli.222.1577299785848; Wed, 25 Dec 2019 10:49:45 -0800 (PST) X-Google-Smtp-Source: APXvYqyZq0WNOzdua1RfDEkn3HqURrkcIdrDtqUjWUQg9SWvt9FzZCJpCtHEmlsjvv06Sjav1Dxdww== X-Received: by 2002:a62:7c54:: with SMTP id x81mr43381216pfc.180.1577299783422; Wed, 25 Dec 2019 10:49:43 -0800 (PST) Received: from localhost.localdomain ([122.177.237.105]) by smtp.gmail.com with ESMTPSA id b98sm7539818pjc.16.2019.12.25.10.49.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Dec 2019 10:49:42 -0800 (PST) Subject: Re: [RESEND PATCH v5 5/5] Documentation/vmcoreinfo: Add documentation for 'TCR_EL1.T1SZ' To: James Morse , linux-kernel@vger.kernel.org References: <1575057559-25496-1-git-send-email-bhsharma@redhat.com> <1575057559-25496-6-git-send-email-bhsharma@redhat.com> <8a982138-f1fa-34e8-18fd-49a79cea3652@arm.com> From: Bhupesh Sharma Message-ID: Date: Thu, 26 Dec 2019 00:19:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <8a982138-f1fa-34e8-18fd-49a79cea3652@arm.com> Content-Language: en-US X-MC-Unique: jCZ6rsf9N_-eBIBnPOVTcA-1 X-Mimecast-Spam-Score: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191225_104953_886868_C8A8D7E9 X-CRM114-Status: GOOD ( 20.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ard Biesheuvel , linux-doc@vger.kernel.org, Will Deacon , x86@kernel.org, kexec@lists.infradead.org, Kazuhito Hagio , Dave Anderson , Catalin Marinas , bhupesh.linux@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Steve Capper Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On 12/12/2019 04:02 PM, James Morse wrote: > Hi Bhupesh, I am sorry this review mail skipped my attention due to holidays and focus on other urgent issues. > On 29/11/2019 19:59, Bhupesh Sharma wrote: >> Add documentation for TCR_EL1.T1SZ variable being added to >> vmcoreinfo. >> >> It indicates the size offset of the memory region addressed by TTBR1_EL1 > >> and hence can be used for determining the vabits_actual value. > > used for determining random-internal-kernel-variable, that might not exist tomorrow. > > Could you describe how this is useful/necessary if a debugger wants to walk the page > tables from the core file? I think this is a better argument. > > Wouldn't the documentation be better as part of the patch that adds the export? > (... unless these have to go via different trees? ..) Ok, will fix the same in v6 version. >> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> index 447b64314f56..f9349f9d3345 100644 >> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> @@ -398,6 +398,12 @@ KERNELOFFSET >> The kernel randomization offset. Used to compute the page offset. If >> KASLR is disabled, this value is zero. >> >> +TCR_EL1.T1SZ >> +------------ >> + >> +Indicates the size offset of the memory region addressed by TTBR1_EL1 > >> +and hence can be used for determining the vabits_actual value. > > 'vabits_actual' may not exist when the next person comes to read this documentation (its > going to rot really quickly). > > I think the first half of this text is enough to say what this is for. You should include > words to the effect that its the hardware value that goes with swapper_pg_dir. You may > want to point readers to the arm-arm for more details on what the value means. Ok, got it. Fixed this in v6, which should be on its way shortly. Thanks, Bhupesh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel