From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A0A5CCFA15 for ; Thu, 26 Sep 2024 04:12:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AfcaZu8zeoim4NwG/NkoQzuTbRyVGuawWAfyldWVd08=; b=oFW4ieDz8qoCx6mB2hHzGGYMlF UyBKZE/d2jeiVFzvEul2HWPMK+ebgb9G5BHXRoTqgOyUAt7w3I+m3wsfmFi2bYfTox2/oVl6KSX1f 3/kp/UQ4vWO1hVEE8xVB6WVKO47gqbYGKyO3x+RHG+gL2eXHFmTZakCwKn8EDQCmD2vNLTUvoRbWd 6sWC/PemUCTnzmFiUCFxVH33z6TWy/GQwC10MyAjBbo11UgevrsHDI0G9u6eXOUDDqA7VPRoSJdBj /40D7OKXdNfvy1Gh9f475RpjFn+2Zbt3zfg2B2REK8kb1YhDBgOfhrdTttBF1BMOG7X3Es8MS2gM1 aanazNlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stfrF-0000000798w-3i4q; Thu, 26 Sep 2024 04:12:01 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stfq5-0000000791E-011U; Thu, 26 Sep 2024 04:10:50 +0000 Received: from [IPV6:2405:201:2015:f873:c173:4b:4a04:3a21] (unknown [IPv6:2405:201:2015:f873:c173:4b:4a04:3a21]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 07E36169; Thu, 26 Sep 2024 06:09:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1727323755; bh=xNzjTIY+/UjJ4mk16Bpwfknhgz/q+8dCxH323xBgEkI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OjUF9Wf8XkL6aG8x0u+7FleE010kRackRa2fE1sDKdw35zUD0fK+PlaErEzdabGyH MBwIAWpV2a5IklwPfsHkItrEPlq9T1EToXy6Gy9TFbJOeshnrMjmT+18djRcZjMI2n neECsu78kzTCfiUJvGYcZFwflFFMGNt4GFVq+zYY= Message-ID: Date: Thu, 26 Sep 2024 09:40:37 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] staging: vchiq_core: Consolidate bulk xfer helper To: Dan Carpenter Cc: Greg Kroah-Hartman , Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kieran Bingham , Stefan Wahren References: <20240919142130.1331495-1-umang.jain@ideasonboard.com> <6661b2d5-b439-46e1-b240-9fe436db4e67@stanley.mountain> Content-Language: en-US From: Umang Jain In-Reply-To: <6661b2d5-b439-46e1-b240-9fe436db4e67@stanley.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_211049_250240_C1440F53 X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dan, On 25/09/24 2:53 pm, Dan Carpenter wrote: > On Thu, Sep 19, 2024 at 07:51:27PM +0530, Umang Jain wrote: >> Few functions were identified were their declaration, definition >> and usage were spread (incorrectly) across vchiq_core and vchiq_arm. >> >> These are being consolidated into vchiq_core in this series. >> Please look at individual patches for details. >> >> 2/3 is in particular a big one. The code is just a move, but >> seems big - as it was diffcult to split it into smaller, compilable >> hunks of individual patches. >> >> Umang Jain (3): >> staging: vchiq_core: Move remote_event_signal() vchiq_core >> staging: vchiq_core: Move bulk data functions in vchiq_core >> staging: vchiq_core: Drop vchiq_pagelist.h >> > Reviewed-by: Dan Carpenter Thanks for reviewing. > > But next time, if you're just moving code around, just ignore checkpatch. Do > the white space changes as a separate patch. Thanks for the tip, will surely keep this mind. > > regards, > dan carpenter > > +- memcpy_to_page(pages[0], > +- pagelist->offset, > +- fragments, > +- head_bytes); > ++ memcpy_to_page(pages[0], pagelist->offset, > ++ fragments, head_bytes); > } > + if ((actual >= 0) && (head_bytes < actual) && > + (tail_bytes != 0)) > + memcpy_to_page(pages[num_pages - 1], > +- (pagelist->offset + actual) & > +- (PAGE_SIZE - 1) & ~(drv_mgmt->info->cache_line_size - 1), > +- fragments + drv_mgmt->info->cache_line_size, > +- tail_bytes); > ++ (pagelist->offset + actual) & > ++ (PAGE_SIZE - 1) & ~(drv_mgmt->info->cache_line_size - 1), > ++ fragments + drv_mgmt->info->cache_line_size, > ++ tail_bytes); >