From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Quentin Perret <quentin.perret@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org, rjw@rjwysocki.net,
amit.kachhap@gmail.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, edubezval@gmail.com,
mka@chromium.org, catalin.marinas@arm.com, rui.zhang@intel.com,
javi.merino@kernel.org, ionela.voinescu@arm.com,
dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/3] PM / EM: Expose perf domain struct
Date: Wed, 15 May 2019 12:54:10 +0200 [thread overview]
Message-ID: <b7e91d70-cd16-791c-94e1-3667ff264e49@linaro.org> (raw)
In-Reply-To: <20190515104043.vogspxgkapp6qsny@queper01-lin>
On 15/05/2019 12:40, Quentin Perret wrote:
> On Wednesday 15 May 2019 at 15:52:00 (+0530), Viresh Kumar wrote:
>> On 15-05-19, 12:16, Daniel Lezcano wrote:
>>> Viresh what do you think ?
>>
>> I agree with your last suggestions. They do make sense.
>
> Good :-)
>
> So, FWIW, the below compiles w/ or w/o THERMAL_GOV_POWER_ALLOCATOR. I'll
> test it and clean it up some more and put it as patch 1 in the series if
> that's OK.
>
> Thanks,
> Quentin
>
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index f7c1f49ec87f..ee431848ef71 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -58,7 +58,9 @@
> */
> struct freq_table {
> u32 frequency;
I suspect we will have a problem here as cpufreq_set_cur_state uses the
frequency and when switching to EM, we will still need a freq table.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-15 10:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 8:23 [PATCH v4 0/3] Make IPA use PM_EM Quentin Perret
2019-05-15 8:23 ` [PATCH v4 1/3] arm64: defconfig: Enable CONFIG_ENERGY_MODEL Quentin Perret
2019-05-15 8:46 ` Daniel Lezcano
2019-05-15 9:22 ` Quentin Perret
2019-05-15 8:23 ` [PATCH v4 2/3] PM / EM: Expose perf domain struct Quentin Perret
2019-05-15 9:06 ` Daniel Lezcano
2019-05-15 9:17 ` Quentin Perret
2019-05-15 9:56 ` Daniel Lezcano
2019-05-15 10:07 ` Quentin Perret
2019-05-15 10:16 ` Daniel Lezcano
2019-05-15 10:22 ` Viresh Kumar
2019-05-15 10:40 ` Quentin Perret
2019-05-15 10:46 ` Quentin Perret
2019-05-15 10:51 ` Daniel Lezcano
2019-05-15 11:01 ` Quentin Perret
2019-05-15 11:07 ` Daniel Lezcano
2019-05-15 10:54 ` Daniel Lezcano [this message]
2019-05-15 10:57 ` Quentin Perret
2019-05-15 8:23 ` [PATCH v4 3/3] thermal: cpu_cooling: Migrate to using the EM framework Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7e91d70-cd16-791c-94e1-3667ff264e49@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox