From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27325C43217 for ; Thu, 3 Nov 2022 16:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fTy2ORzaRc67voH19Vk0MFG55neYdIdvJsEXBkvXA2o=; b=spQ01ifWkJ4JH3 gKB8fEtFLGJR642v74L2pvh2iY+e3+MVySJwiWPH62vMap5ubPzF+I2ifu/X1kyr7SLqBsuflKI60 xTRui68kw2RMEv8lkMJdsYxEFubzwkm9Qigw2effSNgqQJ+qRgcnv7DvfkxXXgFDk1LmqcdbXnbkJ WzdbE+1ZdokzcE5WwCE7I97rU85W3x/Q4nfDsaJeR1DrCvujcFgwq6Rewkm7GwBP0H/+hW6S0S6+p O1aBsDx9addaASVgXoauUWsBAqalMBNI2NgrBAWe4j+aco+L/eAQRUIYu3K+N8I1B5vvsM/SLf2mk yp0VNuwOifRKw3SkoVwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqd6M-000hUZ-Us; Thu, 03 Nov 2022 16:29:59 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqd6I-000hST-T4 for linux-arm-kernel@lists.infradead.org; Thu, 03 Nov 2022 16:29:56 +0000 Received: by mail-qt1-x835.google.com with SMTP id e15so1571869qts.1 for ; Thu, 03 Nov 2022 09:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=WzI5WHDGOhILd2kGTGSG7qJD/oMtmbhddu8DVRjwYa8=; b=iR4qWTvnQ9PK6KX3xLXJJOzYzuLeNPTJ5QqMlgdV6aYVyeuiPSztQohCxcwzupcZTM f89PBCC8TnTlTF6PqvJjVqVcFJGCC/heuJ7SggeKGyIK5RBL/rhxsShENw67NTrptTjg QcDX+40Neuew+11KbTD2vFZIwcfH/FmvMq6sgGHh5OJ3xzpc9gjHa+A3n0cuEFwlRPtB eIFb0mZDmTmyvoo1ImX4gAi0P4jxR1GowJpiwwcfXsdRLYQe4do09L6uX8uk/P4DfjL3 9GbCQF8s+hNNU72F2ZUgombhRPuUhfYn6rLYDEKRDmW1rDNuv9uia1VJQJBe1WcLCgq8 ULiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WzI5WHDGOhILd2kGTGSG7qJD/oMtmbhddu8DVRjwYa8=; b=2hTriZY05zTpDBcoxWMrWoPSf5bEICUwnfUSYlOg/d3v7qJY36Wdjp6t0w9nEeKQAd AyG7gxBwLqHLeaai9dqVPLSs+dAYz9TgkfqxvN88LGAdX8GLZpQZDcDtMC1i4Sgtu/Nr S8bO8Pte/xJAaRAwtDTNQU0Nds8N3jSsvl1MpBrSJ02HX1pmFPZeN+8kmvBxZLgtyimT +bYZedLISa37jr8LibOY7ArwYhRBMOI0Wl2DVAxZgigc3vEU5pxnRwBDYofeiGSWyyNJ bgmJx1k22f6P8aCvsUFvc56S/HhCMUKHbuX5/Djqrph/gT59bA+Vo9JwsHEs6BTrjI2p TR7Q== X-Gm-Message-State: ACrzQf1Qen3KIL2zfBROsDTSxKLK0qPJcO7DwdZd4iBqq91PBAhQ9TjM dbZiUe9nTT61mZXlNZsf1h2koLku/6Mfsg== X-Google-Smtp-Source: AMsMyM6uaWdvy7fAoM8b3ziC+Hx3Fsa/5e0pLstybGOQYB7L/NfOxWftJpK5SmD4Fz4HdYXb6c01mA== X-Received: by 2002:a05:622a:10e:b0:398:d464:eefa with SMTP id u14-20020a05622a010e00b00398d464eefamr25748915qtw.172.1667492990935; Thu, 03 Nov 2022 09:29:50 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:a35d:9f85:e3f7:d9fb? ([2601:586:5000:570:a35d:9f85:e3f7:d9fb]) by smtp.gmail.com with ESMTPSA id h15-20020a05620a244f00b006fa468342a3sm1044435qkn.108.2022.11.03.09.29.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 09:29:50 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 12:29:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v1 2/7] dt-bindings: usb: hpe,gxp-udc: Add binding for gxp gadget To: richard.yu@hpe.com, verdun@hpe.com, nick.hawkins@hpe.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk, balbi@kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20221103160625.15574-1-richard.yu@hpe.com> <20221103160625.15574-3-richard.yu@hpe.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20221103160625.15574-3-richard.yu@hpe.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221103_092955_007082_2DBB78AE X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/11/2022 12:06, richard.yu@hpe.com wrote: > From: Richard Yu > Subject: Drop redundant second "binding" word. > Create documentation for the hpe,gxp-udc binding to support access to > the virtual USB device. > > Signed-off-by: Richard Yu > --- > .../devicetree/bindings/usb/hpe,gxp-udc.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/hpe,gxp-udc.yaml > > diff --git a/Documentation/devicetree/bindings/usb/hpe,gxp-udc.yaml b/Documentation/devicetree/bindings/usb/hpe,gxp-udc.yaml > new file mode 100644 > index 000000000000..f1ec4df8c3d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/hpe,gxp-udc.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/hpe,gxp-udc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP Gadget Universal Device Controller (UDC) > + > +maintainers: > + - Richard Yu > + - Jean-Marie Verdun > + - Nick Hawkins > + > +properties: > + compatible: > + const: hpe,gxp-udc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdevnum: > + description: > + virtual device number. That's unusual property... Why numbering devices is part of DT (hardware description)? > + > + fepnum: > + description: > + number of the flexible end-points this device is needed. Similar question. BTW, if you end sentence with '.', it means it is an sentence, so you need to start it with capital letter. > + > + hpe,syscon-phandle: phandle is redudant. You need rather specific name, so "hpe,ehci-syscon" or whatever it is. > + $ref: '/schemas/types.yaml#/definitions/phandle' No quotes. > + description: > + Phandle to the gxp vEHCI controller access vDevice registers. Drop "Phandle to" Isn't "gxp" a GXP? > + > +required: > + - compatible > + - reg > + - interrupts > + - vdevnum > + - fepnum > + - hpe,syscon-phandle > + > +additionalProperties: false > + > +examples: > + - | > + udc@80401000 { Node name "usb", I think it is more popular for USB controllers. > + compatible = "hpe,gxp-udc"; > + reg = <0x80401000 0x1000>; > + interrupts = <13>; > + interrupt-parent = <&vic1>; > + vdevnum = <0>; > + fepnum = <7>; > + hpe,syscon-phandle = <&udc_system_controller>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel