From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91630C433EF for ; Tue, 12 Jul 2022 07:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7TF8G5VQLotK1TzycSF465xO5BAkABQEpYj1Jwxsdr4=; b=rWh6yWVaWK0stQ f8EH+pFDgua4W9yIpIHWT7bJrs+TKiLd+Riz+fymkOKyxwaxyuhkqAiABGEGFzdFS+oY6U7R/UNIq UjixkC/7flb9D7dWdG+Cb/N8JBS0trSFHWAe02AuzPLd3QcTYxJzaJQBTiTUNEyL1d5xLwnk7hhSp +rKEG7BFonQeXuKXiXs8FErWpKr01+PzeTg4whpWqf567P0+fPpEARJKFvuuKizkb10O/M7IGm8w3 izPtPD9xRhVyQXHB7uKaj2DT2qy1dgMBv0pmAm0T11V245hxCsPAMIFbnDtRCPYd5VSizMZ2fd5Xz 34IjkmG5IlvWEWnUjt3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBAc9-008Rwp-Bs; Tue, 12 Jul 2022 07:47:25 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBAc4-008Rtz-UY for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2022 07:47:22 +0000 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Lht6H6sSBzVfkd; Tue, 12 Jul 2022 15:43:35 +0800 (CST) Received: from [10.67.110.173] (10.67.110.173) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 12 Jul 2022 15:47:09 +0800 Message-ID: Date: Tue, 12 Jul 2022 15:46:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] arm64/crypto: poly1305 fix a read out-of-bound Content-Language: en-US To: Eric Biggers CC: , , , , , References: <20220712033215.45960-1-guozihua@huawei.com> From: "Guozihua (Scott)" In-Reply-To: X-Originating-IP: [10.67.110.173] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500024.china.huawei.com (7.185.36.203) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220712_004721_192850_D5D459CD X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/7/12 15:28, Eric Biggers wrote: > On Tue, Jul 12, 2022 at 12:08:36AM -0700, Eric Biggers wrote: >> >> Is the special reproducer really needed? I'd expect this to be reproduced by >> the existing crypto self-tests just by booting a kernel built with both >> CONFIG_KASAN=y and CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y. >> > > Ah, probably the self-tests don't find this because with poly1305 the key is > actually read from the "data", and for the self-tests the data addresses happens > to always be in the kernel direct map, so KASAN doesn't work for it (I think). > Ideally the self-tests would test with kmalloc'ed data buffers too, or a buffer > in vmalloc'ed memory that's directly followed by a guard page. > > - Eric > . Hi Eric, I just tried and it seems that the extra self-test won't find this bug so I will just keep the reproducer in place. -- Best GUO Zihua _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel