From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3EA3C433B4 for ; Fri, 9 Apr 2021 10:02:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 001296135A for ; Fri, 9 Apr 2021 10:02:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 001296135A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xP8t+Nt1WoX4HyTdNs7zyC3TcsUWD9LUXFZnhfs+Qmo=; b=LS0bBT9sRGteUhW9Q5qlsw/E8 0zMoVSEnJ6Ii1NVoR1jfVNmUVlf8ESrXY/OvOqaf3GmimbwfhwtMKID5Iuh1abY37iVwyeYgK/NYL 4bMMTN2P6mzA26x8clspSjiUnrMnFsLCmp1dr/6FZ3DsRuw0jWdsBe4YkoywWX/4W4ZAYtrouo97J lasFw4mmu1bIWHPOrE6P5SwkRwcOOCnesomzW8UdwNRz8r1NF3qa/IPQubKjoYR+l6ifbCoO6Fgzr DdqD68jJL0+jqTciD4DAD43MNPHeYzlWQZMvpQQGE8HI/qvIxuJqYneSuD1lvHa3fm5llmKiNrupp +mGEnKdEw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUnvh-000LdE-PM; Fri, 09 Apr 2021 09:59:58 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUnvb-000Lc3-03 for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 09:59:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1617962390; x=1649498390; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XFFDlaW/yYSV4DGGMtvLpfxUx0tlc4u/Ju/fDulB3oQ=; b=j/KVwlMOQUPyf1WdHBxOQERKAhQTSrLsuhpScKblCZLsm+/jbpqNZV/F pO+aCAYT4sGeesVwlmPRbFEBYFRXeu17DU8AAwveEFNHOvnlNIBIaAK2x /jOP4fLpibk1vylE6AvlWNR1TqzBwQdEt7ZdvTaodN9qkQK/svzNpF6HI ndyb+N2FlA9ohoSYbak82qjw10qV/s0/4i0Zx5ikqQcync6GjaWXDdzcv sKwrKqYw89Q2MK9Lim0p+PJoEMlPgCVqJ2yEXtIASptotIvK/FxrOOEKF 6nedHYiSpye0K6ZUcPW1iomKFRStlY74G5JOPJGj12wbcpH7lQ9Xtxdtu w==; IronPort-SDR: UbtVZfJ1hDunTbUS+yA9MsnfQzlZ1NCY9/4Uadrn1v/ToZKooAwgQCz/ykMvl6ZnKqHXhNYOHR BdvDyMABJroUNP8h+wTtShXFg8ElAVvGjcXQ2Z4k3ouMI/jo6pB3u22v5uXF8StiaQp9QYhTK0 pl/sW7Ku1ENgLV6dBkl0p5KJ+cnxP4CTV4pBcgV5rQGMI7bi5kY2hyZ4oAedqvqFvyPZ1YmbWs CsismlpFUatvRE/ZXyhcqKzzUxkWsS5xmeZtx4ADnINVMaIxrNzpxGXimnWB1JINjIXV3Q4pnN YAw= X-IronPort-AV: E=Sophos;i="5.82,209,1613458800"; d="scan'208";a="116421539" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Apr 2021 02:59:45 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 9 Apr 2021 02:59:45 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2 via Frontend Transport; Fri, 9 Apr 2021 02:59:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U4RMOTU3bnR+g6NB2nsb+2xP2lxvpEmG9OJJYGohVlkUeyKxAHlHLb+QSFsLgxIwaGRhVKJHXKtiyJK6/5OHFPtI1ckZdYmsyqJkHliEw/oxAQko1Au0/uLFDKcvPtZuY0vDBvNTT/3a3SbUzSv/w9iM5an7pSQK5tS316hMI6tEM1GzHsOwiKszsOUt3dzn9RYb3/vWs+kliof+VulzdlGJlFfMGCkRzWcKGmYQhe7RiHH6hdKTW1mP1RMs+7QuFvQBAau0H56TSzgeyboCUc0mmpzdnNVpYwVXY5uXHSvlnkgoDTPncWeoJqpchYRtFA4GnbArxYynUymN7a0EbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XFFDlaW/yYSV4DGGMtvLpfxUx0tlc4u/Ju/fDulB3oQ=; b=Tehf7olRGsekMf5JiZ/VLg0N6MfZdML/Yl0qvZpRvNH615WFpGh6B88LKP4h9+OWx1XBlswPDjA7VqxSVD6L0/ivQBF8uv+XFXZTdrAdltk1gRvV1dq3O3HcmivuxIWKVKTtLpXyPJO8z3BOWGNRgAa1ix701UwlzgXk6f1SjgvT5HC/Q5LlmJQIV9mi3voxbzw6MeVeZ+DUKATod1+c3rRvB+GyfwsI5jbuEB6IxRWG1ZpxRwSB6ybHrV+JUtHgceWslVexBP0KsqUZ3P8uC9pP1VBuNyBs5h/QW78kAl/ZDdZXr3bSYWyw30iiBbvpP+XOL32DWQLrUeFlLzViQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XFFDlaW/yYSV4DGGMtvLpfxUx0tlc4u/Ju/fDulB3oQ=; b=KJCjzdWbMS1pkSYjeQtwCr2QA94thWReWiKM6lqkb284Rqa1gPcQ0m1u10cBUT/MYIOw09KnjW4a2NRxCGtFytX8P90rk3634XXgCOdPsyuCmvy/kTPRubJK/LkTnKXVl0jvZFkUivmqvBZhNc8zi4h4aJfkVHDR3T1n0FVAxSY= Received: from DM6PR11MB3420.namprd11.prod.outlook.com (2603:10b6:5:69::31) by DM5PR11MB1692.namprd11.prod.outlook.com (2603:10b6:3:d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Fri, 9 Apr 2021 09:59:43 +0000 Received: from DM6PR11MB3420.namprd11.prod.outlook.com ([fe80::d405:a5f2:bb71:38d7]) by DM6PR11MB3420.namprd11.prod.outlook.com ([fe80::d405:a5f2:bb71:38d7%2]) with mapi id 15.20.3999.035; Fri, 9 Apr 2021 09:59:43 +0000 From: To: , , Subject: Re: [PATCH] pinctrl: at91-pio4: Fix slew rate disablement Thread-Topic: [PATCH] pinctrl: at91-pio4: Fix slew rate disablement Thread-Index: AQHXLScP50uevSvackKO5w0NtAUzGg== Date: Fri, 9 Apr 2021 09:59:42 +0000 Message-ID: References: <20210409082522.625168-1-tudor.ambarus@microchip.com> In-Reply-To: <20210409082522.625168-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 authentication-results: microchip.com; dkim=none (message not signed) header.d=none;microchip.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [82.76.227.232] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7abb50b8-ac28-46b8-0c47-08d8fb3e32bb x-ms-traffictypediagnostic: DM5PR11MB1692: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: npuY0zoHYGEL/QUpy1KfpxeOtxyhjrTJkq+ld0Z+W1CkOU96viDtgJCtHKiSzin0cTnH0FAe0rzrqAAEdCP/U1A3gW2+Z0OEp+rDwSqRBH1AAsXzmHIU3BpOA0eZ4opN+Cr0DcC9cyIPUnI67R5PeB+k/J5QBRNWoD/IERQsjxCBp2F7f8IWCghxApMr3SnsR6fKrvEK6kF/MXRSJK7HfW0DRlsaSqt5E87xdJm01uNz1euw9vHsQvmR7QxcVRafJ700KzX754eetfjVOgvNsSCGmwu/CMIqvE2WjI/AtotDGUnQ5PMuxbwVGKhEonyh4utet8VI/dg3ZpWGDsO1CjBYgfSE9DflFXuZVfvEsIdvBKTtAcelBLr0iNxdH0lb2rIZVzIzKFrvsMQExsGtXAZFlnUEgCsyqAbKT24SVR1sibSiYShwl57+x9gYzNUvM48PsSn4aKuABlnxpCgI04Z3K2pVdVM4fscJk+LGvYzBGA8fq30+l+ASdzmaVG//lJef04vOfzUNy3zpm12M1202Qexw36Evwz2zVXW222SjkrjornsbC/2Vcy+une4D9QMVuOXgXixemNiIj4ct4rbOrtNYrFA2r8cZQhuw11juwO+3yP63mJsJc4A072VcHciiPZsTRj7Fq6JsZEolc0xV3YF26zjSGC4UjNpbMNkce+aM1qksTU+ERhlDYX4YSox9QBT5ikCFQ5o0oRqFjcVSQH5Ft+DNXLmyYt2HW8I= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3420.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(39860400002)(366004)(396003)(136003)(76116006)(31696002)(2616005)(316002)(66946007)(91956017)(66476007)(54906003)(66446008)(66556008)(2906002)(6512007)(478600001)(8676002)(8936002)(64756008)(31686004)(86362001)(6506007)(53546011)(6486002)(83380400001)(71200400001)(186003)(38100700001)(5660300002)(110136005)(4326008)(36756003)(26005)(43740500002)(45980500001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?eG9xOWZzRU56SjVZU3pUeHlSOEh0NmRDR1h2Z0VuMU5ZZmFMNForMnF0dVBW?= =?utf-8?B?TEh0cHZ4ZEkzN2RXSzM5emhSeFAvYUZpK2RIb3prU3Z3eDNkSCsxMlZxWWYy?= =?utf-8?B?c0h0QU9ZTDllYlZneVhtV00yQlZTVWZ2S2xFRWkvblJhQ3BaYlBVNEtGQ3NZ?= =?utf-8?B?bjR6Y2lGbE5KdUp2ZlB6bi9STTJaa2xSek5zQUVEblU3Z2U0MnpuNHBDTi9D?= =?utf-8?B?d0dxNmRaTU9mcTZKWmM2eXdrV0NOWFBWSk5aazZSSnpIN1NsOXIzbVAyU2FK?= =?utf-8?B?TmZXRWllbG1vVEdQMVh1MkdncDZVV2VQL0tMbkdJcXAyM05tTnZoMHVuV1Z1?= =?utf-8?B?Y3RLdGFCeXFxZzg3OExLdzUyWFdtd0JKOUxJZnMrS1o2N3dwbGZsdW0xODV6?= =?utf-8?B?MHI1ZG0rcTRMUElJVkd6cXBWaEJtR2tTWGo2TzBacHdYR3g0Z3owRXpjcEp2?= =?utf-8?B?bUthSTVvWlB1Z2RQRXUxSHBUNm45d0psRUczM2FETTdDdis3MTcrUEM4V0ZY?= =?utf-8?B?T3BLQ3ByTmdsLzlGSGpFRkVUVjFyQ1NiQVM1NVRJelFYQW9RV28zbzFBeEh2?= =?utf-8?B?T01DSFRDeTFMSU0wdTFnWW12Y3l2S24wNTQ4NXY2SjUvUzAwSktROHJVbm5P?= =?utf-8?B?R1IxV0tZaU50Y1BBV0VqUDhFVHpObEJVcDNyQXhuS1E5R3JYNTlaS0xKWmxy?= =?utf-8?B?S1diUDQzU0czSENuM1JPdkpyL0RFYmZ3Tnl6M0g3QlF5NEdpa0N4OG5LelZX?= =?utf-8?B?bk0xbG91cHlhaFViZUtKWlpyWGF5TDE1UllVVWUwL0I1TVpBV1lSYkxFY0cv?= =?utf-8?B?ZlVIVFp2eDhzamtXaTFWVERZQ1ZRWEhuSW1QMVVCRVRFNTBQZEVvNmV3c093?= =?utf-8?B?YWc3ei9HOTBwNExNUjd2VTdUR0hFNGZoT0gvMzJtUXlESnhqV2cyMldyL2FW?= =?utf-8?B?eVhHS0h3S0RRbGExTjNpeUE3RmtCand5cEhLQkViaU10VWNmL0p1OFlBTHFn?= =?utf-8?B?MDRvOVl0RjdFU0o3U0ZhR2lSK3JtQkVEOXN5SFlHMjFYRWRxbjFjNHNHeUtX?= =?utf-8?B?NTJzOG1PUytWQi8vNEdKc2lNaTlmNThGVjlpNEg0NmlhV3ZTVGlLdXp0TG4w?= =?utf-8?B?MkxBRVE1c05adytaRkpZT3U5eVFLcUxyN1JrcEkxZm9xQldVcjdXZTlrMVpm?= =?utf-8?B?Y1FjcGVOL29SSWpmRlRITTNkQ3V5OFlJOS9RRmJ6aCtDdHduVmU4TXVIUFpz?= =?utf-8?B?U1BRcmd5RWQvSWVGeHVPRDZHejU5WXRUVndHUkEyS1E2SXcwZHV6ZEdnUWxY?= =?utf-8?B?M2RJc1l0c0hCeHhsdFJUMmk2N2hESXdRaGZDQ3A5ZzNOY1R5MU1QRWZBQTRm?= =?utf-8?B?bGlVb3NLbVBmYkpQTitrM0hTb0paamVrSnpOWSsrR0VHMFVVaUtXbDlZQ3BP?= =?utf-8?B?TjJhUFJ5ZGt2ZGlydUtOdkJOay9lcmxhQmQ4aUN6aW5vNVdEYU1ORzRYeFpY?= =?utf-8?B?YWYrZ082QjlwajVUTDNLVGIvcDBpNmIvUW5sVWtnZllmTlVXVnMrc2Rwc0tJ?= =?utf-8?B?VkJtY2p2OFNjalVPMkZHRkRmS1FXWlk1WDJiWWlFLzNaa3JwMUN5bjRBdFdH?= =?utf-8?B?RCt4b1Axd3NISms0NHd1ZVdNYzQ2cHRrclRlR2hMaDRZaE9EOVZjQ3pOdmRC?= =?utf-8?B?ei80eXp6TzFFYXdNZFpacXJTdVVBRkRZUmNSWmRFSEtmQ2ZYVDF3OGRjV21T?= =?utf-8?Q?Fd3WklUTonAeru2EzQ=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3420.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7abb50b8-ac28-46b8-0c47-08d8fb3e32bb X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2021 09:59:42.9529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rrbjgover1R1XezFJnOevdT/K5Gl7+QJKIu1YOZ0NZGTl3eEUzfIjF7BPCDtbn1P/hVWElyl5AbDGEKkIj4c1tTrWdWZhfP9AIhMZEtbKW8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1692 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_105951_712291_23F57185 X-CRM114-Status: GOOD ( 20.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, alexandre.belloni@bootlin.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09.04.2021 11:25, Tudor Ambarus wrote: > The slew rate was enabled by default for each configuration of the > pin. In case the pin had more than one configuration, even if > we set the slew rate as disabled in the device tree, the next pin > configuration would set again the slew rate enabled by default, > overwriting the slew rate disablement. > Instead of enabling the slew rate by default for each pin configuration, > enable the slew rate by default just once per pin, regardless of the > number of configurations. This way the slew rate disablement will also > work for cases where pins have multiple configurations. > > Fixes: 440b144978ba ("pinctrl: at91-pio4: add support for slew-rate") > Signed-off-by: Tudor Ambarus Reviewed-by: Claudiu Beznea > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c > index a5d328808e4c..4c01d8471ffa 100644 > --- a/drivers/pinctrl/pinctrl-at91-pio4.c > +++ b/drivers/pinctrl/pinctrl-at91-pio4.c > @@ -801,6 +801,10 @@ static int atmel_conf_pin_config_group_set(struct pinctrl_dev *pctldev, > > conf = atmel_pin_config_read(pctldev, pin_id); > > + /* Keep slew rate enabled by default. */ > + if (atmel_pioctrl->slew_rate_support) > + conf |= ATMEL_PIO_SR_MASK; > + > for (i = 0; i < num_configs; i++) { > unsigned int param = pinconf_to_config_param(configs[i]); > unsigned int arg = pinconf_to_config_argument(configs[i]); > @@ -808,10 +812,6 @@ static int atmel_conf_pin_config_group_set(struct pinctrl_dev *pctldev, > dev_dbg(pctldev->dev, "%s: pin=%u, config=0x%lx\n", > __func__, pin_id, configs[i]); > > - /* Keep slew rate enabled by default. */ > - if (atmel_pioctrl->slew_rate_support) > - conf |= ATMEL_PIO_SR_MASK; > - > switch (param) { > case PIN_CONFIG_BIAS_DISABLE: > conf &= (~ATMEL_PIO_PUEN_MASK); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel