From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545E5C55178 for ; Mon, 26 Oct 2020 14:09:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E99A424640 for ; Mon, 26 Oct 2020 14:09:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xejsOOny"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="P4Dfr9oO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E99A424640 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QDkZ3Fj1pmAvdMwMnEd5f0IQp0IJLzuHRkZc4txCkOQ=; b=xejsOOnySrPahPHHGZYAQYVEc /fSFV4AhuQhwKxiOX7nL7ErM9wjMiLqMRYhviAV2KDxuv7hBGo4bPkApySg5ilS7L0wd1Xsw3fAIh EYffqpctl3QSu1bP4MgPrGsBWANQoVwu95CY8tjFgqHzT+htU/bN31G4n8SJnKaGrGUR1hvcjeBTM YkfmHyC/6vigakyZzkAGJ0hZ2Zq8fb8eZR0hxhJhsMppU2CxNMyCMMN0RDjFwrQXumSWXOndaFZPi 0LoZr2JLtGrQhzs0kCelYt75c/NJogiKZiSHpy7VO0NjsncX4GEcQG2Dmd2Y5vyFMhEZHAgt5EkIc KKDtwPHjw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX3Av-0004VD-Ep; Mon, 26 Oct 2020 14:08:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX3At-0004UN-6j for linux-arm-kernel@lists.infradead.org; Mon, 26 Oct 2020 14:08:40 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3405F2242A; Mon, 26 Oct 2020 14:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603721318; bh=piPyVG4naoRlpa5Gf3UOt8KiGpTMaw7CwHneYKoEims=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P4Dfr9oOop2NEpcLIejN6byw2vAQtq2F3IQ3NfTLPnTq5m2Rk5j+r4T/EJ8jUek+J eGJ9/CXQG7VRoEvBtjYDQ5AdPd9pPZFhMNOXyItxICFcdliZFFSXWv2HNeZfHW5bo1 U1ZFlbClUSGIXji/cpUxk8ArIMPUIMCLzyo4NPnY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kX3Aq-004LSu-3z; Mon, 26 Oct 2020 14:08:36 +0000 MIME-Version: 1.0 Date: Mon, 26 Oct 2020 14:08:35 +0000 From: Marc Zyngier To: Mark Rutland Subject: Re: [PATCH 01/11] KVM: arm64: Don't adjust PC on SError during SMC trap In-Reply-To: <20201026135308.GC12454@C02TD0UTHF1T.local> References: <20201026133450.73304-1-maz@kernel.org> <20201026133450.73304-2-maz@kernel.org> <20201026135308.GC12454@C02TD0UTHF1T.local> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_100839_334402_5FE9470E X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-10-26 13:53, Mark Rutland wrote: > On Mon, Oct 26, 2020 at 01:34:40PM +0000, Marc Zyngier wrote: >> On SMC trap, the prefered return address is set to that of the SMC >> instruction itself. It is thus wrong to tyr and roll it back when > > Typo: s/tyr/try/ > >> an SError occurs while trapping on SMC. It is still necessary on >> HVC though, as HVC doesn't cause a trap, and sets ELR to returning >> *after* the HVC. >> >> It also became apparent that the is 16bit encoding for an AArch32 > > I guess s/that the is/that there is no/ ? Something along these lines, yes! ;-) > >> HVC instruction, meaning that the displacement is always 4 bytes, >> no matter what the ISA is. Take this opportunity to simplify it. >> >> Signed-off-by: Marc Zyngier > > Assuming that there is no 16-bit HVC: It is actually impossible to have a 16bit encoding for HVC, as it always convey a 16bit immediate, and you need some space to encode the instruction itself! > > Acked-by: Mark Rutland Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel