From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09471C04FFE for ; Tue, 14 May 2024 21:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7s3OcG/yMkzcXBBPDnCCGNHnGmzIwFaFbWAS3opWpcA=; b=2YYnXt8TvgV4uI O8zCXKpD4i9X2179Fym14f8V4NK3w1QUjJjNoOmwiLsrwrLeGEX7jhDVXGjfJhugF25kBXRp+Bqn1 5hZAFXCxRGmI3469kwZKF3I36s+rr9bXWbxgDb9nabhFJVo9YahaYWPFvWNa5t9hTjYea0MSFIg46 9guYJ77MbH3jHeCayCSuPKJvAPlhhcygsZCLt+T8qHqXrzm8UV/tf+G1knVTSGeQWvN/VYA7yWvbs x9T/qDEIbpvzp81PiVdl+fv2zVCTP5sAw5Qld9mX/A0Fa6vuEG2ahzkFsw1+E9M0FbMqihdjfg3ax f7G0PdTePIaCtFXrOwAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6zOf-0000000HAda-1ORP; Tue, 14 May 2024 21:09:17 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6zOc-0000000HAcs-0wxd for linux-arm-kernel@lists.infradead.org; Tue, 14 May 2024 21:09:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6A129CE1337; Tue, 14 May 2024 21:09:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BE4BC2BD10; Tue, 14 May 2024 21:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715720951; bh=iBQGtyPRNxJ3b5eCicElCWKrOiKS02iKAvulYWm1oUU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=geFwaALR6vbhzVKzofNk1wS80bfk5LIQWAfWAgkQV6OL0DagMP9T+RwSQa2s0bz6N 89LSgb4bi7I0aAtPTZMwye1uz3OMNaZja+SJaf+dki+W1UZC14FmzFuPbXRwBeHAFG sVZUuKIeSNTU0FmHftWNp50QfMXnv/CQBXommIolqyx3czSfcJnEWMDPQOPJd9y+t2 jWVLHciqhkaiCdBtCoB1eLVOd3zfS4vvukwhXYTvw0ziGkgbrCEUNNefdofDyJTt54 NkoEzS6VTHACXS/ONZ3OZf/+4dIjsVc00Pj7AMJx3dbXGU85MJlLT5zzdH0Q8Mh/Bx DkXZ1i3E8sX4Q== Message-ID: MIME-Version: 1.0 In-Reply-To: <20240514-campus-sibling-21cdf4c78366@spud> References: <1715679210-9588-1-git-send-email-shengjiu.wang@nxp.com> <1715679210-9588-4-git-send-email-shengjiu.wang@nxp.com> <20240514-campus-sibling-21cdf4c78366@spud> Subject: Re: [PATCH v3 3/6] dt-bindings: clock: imx8mp: Add reset-controller sub-node From: Stephen Boyd Cc: abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, marex@denx.de, linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, shengjiu.wang@gmail.com To: Conor Dooley , Shengjiu Wang Date: Tue, 14 May 2024 14:09:09 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240514_140914_490393_A838EEC2 X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Conor Dooley (2024-05-14 11:06:14) > On Tue, May 14, 2024 at 05:33:27PM +0800, Shengjiu Wang wrote: > > diff --git a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > > index 0a6dc1a6e122..a403ace4d11f 100644 > > --- a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > > +++ b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > > @@ -15,7 +15,10 @@ description: | > > > > properties: > > compatible: > > - const: fsl,imx8mp-audio-blk-ctrl > > + items: > > + - const: fsl,imx8mp-audio-blk-ctrl > > + - const: syscon > > + - const: simple-mfd > > > > reg: > > maxItems: 1 > > @@ -44,6 +47,11 @@ properties: > > ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8mp-clock.h > > for the full list of i.MX8MP IMX8MP_CLK_AUDIOMIX_ clock IDs. > > > > + reset-controller: > > + type: object > > + $ref: /schemas/reset/fsl,imx8mp-audiomix-reset.yaml# > > + description: The child reset devices of AudioMIX Block Control. > > Why not just set #reset-cells = <1> in the existing node? IIRC it was > already suggested to you to do that and use auxdev to set up the reset > driver. Yes, do that. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel