Re: [PATCH v3] net: phy: meson-gxl: implement meson_gxl_phy_resume()

From: Heiner Kallweit <hkallweit1@gmail.com>
To: Da Xue <da@libre.computer>, Andrew Lunn <andrew@lunn.ch>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Luke Lu <luke.lu@libre.computer>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: phy: meson-gxl: implement meson_gxl_phy_resume()
Date: Tue, 8 Aug 2023 08:42:31 +0200	[thread overview]
Message-ID: <b8931b6c-5b35-8477-d50f-b7a43b13615f@gmail.com> (raw)
In-Reply-To: <20230808050016.1911447-1-da@libre.computer>

On 08.08.2023 07:00, Da Xue wrote:
> After suspend and resume, the meson GXL internal PHY config needs to

To avoid misunderstandings:
You mean suspend/resume just of the PHY, or of the system?

Description sounds like this patch is a fix and should go to stable.
So add a Fixes tag.

And a formal remark: Your patch misses the net / net-next annotation.

> be initialized again, otherwise the carrier cannot be found:
> 
> 	eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state
> 		DOWN group default qlen 1000
> 
> After the patch, resume:
> 
> 	eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP
> 		group default qlen 1000
> 
> Signed-off-by: Luke Lu <luke.lu@libre.computer>
> Signed-off-by: Da Xue <da@libre.computer>
> ---
> Changes since v2:
>  - fix missing parameter of genphy_resume()
> 
> Changes since v1:
>  - call generic genphy_resume()
> ---
>  drivers/net/phy/meson-gxl.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
> index bb9b33b6bce2..bbad26b7c5a1 100644
> --- a/drivers/net/phy/meson-gxl.c
> +++ b/drivers/net/phy/meson-gxl.c
> @@ -132,6 +132,18 @@ static int meson_gxl_config_init(struct phy_device *phydev)
>  	return 0;
>  }
>  
> +static int meson_gxl_phy_resume(struct phy_device *phydev)
> +{
> +	int ret;
> +
> +	genphy_resume(phydev);

Return value of this function should be checked.

> +	ret = meson_gxl_config_init(phydev);
> +	if (ret)
> +		return ret;
> +
> +	return 0;
> +}
> +
>  /* This function is provided to cope with the possible failures of this phy
>   * during aneg process. When aneg fails, the PHY reports that aneg is done
>   * but the value found in MII_LPA is wrong:
> @@ -196,7 +208,7 @@ static struct phy_driver meson_gxl_phy[] = {
>  		.config_intr	= smsc_phy_config_intr,
>  		.handle_interrupt = smsc_phy_handle_interrupt,
>  		.suspend        = genphy_suspend,
> -		.resume         = genphy_resume,
> +		.resume         = meson_gxl_phy_resume,
>  		.read_mmd	= genphy_read_mmd_unsupported,
>  		.write_mmd	= genphy_write_mmd_unsupported,
>  	}, {

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel