From: elfring@users.sourceforge.net (SF Markus Elfring)
To: linux-arm-kernel@lists.infradead.org
Subject: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()
Date: Sun, 23 Apr 2017 13:10:16 +0200 [thread overview]
Message-ID: <b89bfd5c-315a-345f-7239-2d6300cf1f6e@users.sourceforge.net> (raw)
In-Reply-To: <49f1c0b2-7463-2121-1aed-0998f6635c92@math.uni-bielefeld.de>
>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply
> For example. Also I just noticed some previous comment by Krzysztof that
> pointed that out already.
>
> My suggestion: One sentence describing that the current situation is.
Why do you find the sentence for the multiplication information inappropriate
(or incomplete) at the moment?
> Another sentence explaining why this is bad/undesirable.
Which details do you miss here?
> In this case, the output of the checkpatch script would come in handy.
Its implementation of the check ?ALLOC_WITH_MULTIPLY? considers only an other
search pattern so far.
* Do you find it worthwhile to add a prefix like ?devm_? to the used
regular expression?
* Would like to improve any related scripts for the semantic patch language
(Coccinelle software) a bit more?
> With this, you avoid cramming every information into one long and
> complicated sentence.
Thanks for your feedback about other wording preferences.
Regards,
Markus
next prev parent reply other threads:[~2017-04-23 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 21:23 [PATCH 0/2] dmaengine: s3c24xx: Fine-tuning for s3c24xx_dma_probe() SF Markus Elfring
2017-04-22 21:24 ` [PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe() SF Markus Elfring
2017-04-23 9:59 ` Tobias Jakobi
2017-04-23 10:38 ` SF Markus Elfring
2017-04-23 10:44 ` Tobias Jakobi
2017-04-23 11:10 ` SF Markus Elfring [this message]
2017-04-23 12:18 ` Tobias Jakobi
2017-04-23 12:36 ` SF Markus Elfring
2017-04-22 21:25 ` [PATCH 2/2] dmaengine: s3c24xx: Fix a typo in a comment line SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b89bfd5c-315a-345f-7239-2d6300cf1f6e@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).