From: Philipp Zabel <p.zabel@pengutronix.de>
To: Matthew Hagan <mnhagan88@gmail.com>
Cc: bjorn.andersson@linaro.org,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Voon Weifeng <weifeng.voon@intel.com>,
Ong Boon Leong <boon.leong.ong@intel.com>,
Wong Vee Khee <vee.khee.wong@linux.intel.com>,
Tan Tee Min <tee.min.tan@intel.com>,
"Wong, Vee Khee" <vee.khee.wong@intel.com>,
Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: stmmac: explicitly deassert GMAC_AHB_RESET
Date: Mon, 07 Jun 2021 11:45:40 +0200 [thread overview]
Message-ID: <b89d828a08528aaa07e3527d254785f1e40b9bee.camel@pengutronix.de> (raw)
In-Reply-To: <20210606103019.2807397-1-mnhagan88@gmail.com>
On Sun, 2021-06-06 at 11:30 +0100, Matthew Hagan wrote:
> We are currently assuming that GMAC_AHB_RESET will already be deasserted
> by the bootloader. However if this has not been done, probing of the GMAC
> will fail. To remedy this we must ensure GMAC_AHB_RESET has been deasserted
> prior to probing.
>
> v2 changes:
> - remove NULL condition check for stmmac_ahb_rst in stmmac_main.c
> - unwrap dev_err() message in stmmac_main.c
> - add PTR_ERR() around plat->stmmac_ahb_rst in stmmac_platform.c
>
> Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++++
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 7 +++++++
> include/linux/stmmac.h | 1 +
> 3 files changed, 12 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 6d41dd6f9f7a..0d4cb423cbbd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -6840,6 +6840,10 @@ int stmmac_dvr_probe(struct device *device,
> reset_control_reset(priv->plat->stmmac_rst);
> }
>
> + ret = reset_control_deassert(priv->plat->stmmac_ahb_rst);
> + if (ret == -ENOTSUPP)
> + dev_err(priv->device, "unable to bring out of ahb reset\n");
> +
I would make this
if (ret)
dev_err(priv->device, "unable to bring out of ahb reset: %pe\n", ERR_PTR(ret));
Also consider asserting the reset again in the remove path. Or is there
a reason not to?
With that addressed,
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-07 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 17:35 [PATCH 1/3] net: stmmac: explicitly deassert GMAC_AHB_RESET Matthew Hagan
2021-06-05 17:35 ` [PATCH 2/3] ARM: dts: qcom: add ahb reset to ipq806x-gmac Matthew Hagan
2021-06-05 17:35 ` [PATCH 3/3] dt-bindings: net: stmmac: add ahb reset to example Matthew Hagan
2021-06-06 3:24 ` [PATCH 1/3] net: stmmac: explicitly deassert GMAC_AHB_RESET Bjorn Andersson
2021-06-06 9:36 ` Matthew Hagan
2021-06-06 10:30 ` [PATCH v2] " Matthew Hagan
2021-06-07 9:45 ` Philipp Zabel [this message]
2021-06-08 18:57 ` Matthew Hagan
2021-06-08 18:59 ` [PATCH v3] " Matthew Hagan
2021-06-08 23:50 ` patchwork-bot+netdevbpf
2021-06-06 14:38 ` [PATCH 1/3] " Matthew Hagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b89d828a08528aaa07e3527d254785f1e40b9bee.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=bjorn.andersson@linaro.org \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mnhagan88@gmail.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=tee.min.tan@intel.com \
--cc=vee.khee.wong@intel.com \
--cc=vee.khee.wong@linux.intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).