From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADBAAEB64D9 for ; Fri, 7 Jul 2023 12:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iUWXNog8AAqN7C5XYv3utKfmWDLYgZfDSHHNdEX0qMs=; b=ZOfp/27OFXNXSh THgwug3wsa4CSUvCI2g/L5tqeDn1MbQqFSBpYB+pGzNex+IuBWniV+0C1Q41G8U8zN4c55UjP0dpQ v8xZh4R7JTBWZNSv2CG+eGrZtD3MmdU/erGEPWYUnMXN5GDYmYrwAx4IcW4MRVRLXf4Re9v4S3v74 UrXqFV4AnDVT1nm5eSw6VMNWoD2n9ulwprs8eubCpj4HjKaKn/RYpk2XGOQ+nbd0pxEoFsJQuE+pU G55p5BtB/8wNnJDUdrFjzkm6pX7V8ofuNmo20HtBEfztfavhOy2fid3H07zAG4JxXgvsfX4yXUqhr Wzvpzcc4Am2D/2sscjWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHkIw-004alK-1j; Fri, 07 Jul 2023 12:11:18 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHkIu-004akw-17 for linux-arm-kernel@lists.infradead.org; Fri, 07 Jul 2023 12:11:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688731875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BVyqwSHAPLftzopmtaxC0lFHhRx6FuTQym8jgnJKosE=; b=TT7UO4bheeBP7wmn9tkTywJkEp8fnSwMnFglXtwkzr1AbWAiX7Pg/2a+ZmaiYth/dsQ5FX CTbrmt/pvv96HmwLAZkSvfTOFRDu/qPB909Qx1P+X4Vzq4IDLLaCl/mwGjAV01YRmHqdDt of+gvaHQOTTt4GgYt9QmY6YfZmdqUh0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-4Ycvy9u6MruECOzAJyUayA-1; Fri, 07 Jul 2023 08:11:14 -0400 X-MC-Unique: 4Ycvy9u6MruECOzAJyUayA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-31429e93f26so993978f8f.2 for ; Fri, 07 Jul 2023 05:11:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688731873; x=1691323873; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BVyqwSHAPLftzopmtaxC0lFHhRx6FuTQym8jgnJKosE=; b=Fg+LbTl47MubvZxmAznUWQUsnGD7ZCsYEtaB+hPBgAxEiveuau6UkoV0JdTz28ZxRG kLHnUr3Sx6dUL1ZEddOC+hWJe9QHrpzMJ+1RYvBuJKiFLFk9rur+9PtD0j11p3Zq3FtC 9fQ7Ti5zmtHqcOagtfpA73wsXR7V5nogUZkpk4hYPBFZpD94W0LQwb5pxsAa1FdBQiTC dSdV+Y6ODmLPS4PAOJhTOvSv5FUz5RxBepbu3l9L8CneiDBFarDOVBfXj/CWfeF8bRuC loRxALMPioMF43LjNnGuCRhTwvZPbesLPutzMUnjMBgd7ik4FF5SFcFjdSn1B8LiY0p4 QaqA== X-Gm-Message-State: ABy/qLYLYRKS6dfryC9nst4E97leN1mjiMjMWgOIic5SMBdl0hzRgScF 2OdCsgmdDNK6NVsVPIx96lU4NLLT0mhKosrsL2WxdSRHC4YALUwxcAuZWdTv6ZBhs0lD/+2NSxr ZMdBbLM4LYF5Op12RG0pc/zIh5oTh/ji+CbZ7cJztlik= X-Received: by 2002:a5d:5450:0:b0:314:3503:15ac with SMTP id w16-20020a5d5450000000b00314350315acmr4071153wrv.10.1688731872960; Fri, 07 Jul 2023 05:11:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlGQ+0CrqDvb4lVn+YlJy3j3lhmI2e5jJ3pz4I7kZYIBFwKLH8Ug0fJ0/CydpV5KGXWVfJemXw== X-Received: by 2002:a5d:5450:0:b0:314:3503:15ac with SMTP id w16-20020a5d5450000000b00314350315acmr4071129wrv.10.1688731872601; Fri, 07 Jul 2023 05:11:12 -0700 (PDT) Received: from ?IPV6:2003:d8:2f04:3c00:248f:bf5b:b03e:aac7? (p200300d82f043c00248fbf5bb03eaac7.dip0.t-ipconnect.de. [2003:d8:2f04:3c00:248f:bf5b:b03e:aac7]) by smtp.gmail.com with ESMTPSA id k6-20020adfd846000000b00314315071bbsm4324550wrl.38.2023.07.07.05.11.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 05:11:12 -0700 (PDT) Message-ID: Date: Fri, 7 Jul 2023 14:11:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC 0/4] arm64/mm: Clean up pte_dirty() state management To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas , Will Deacon , Ryan Roberts , Mark Rutland , Andrew Morton , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20230707053331.510041-1-anshuman.khandual@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230707053331.510041-1-anshuman.khandual@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230707_051116_457357_F928D2F5 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07.07.23 07:33, Anshuman Khandual wrote: > These pte_dirty() changes make things explicitly clear, while improving the > code readability. This optimizes HW dirty state transfer into SW dirty bit. > This also adds a new arm64 documentation explaining overall pte dirty state > management in detail. This series applies on the latest mainline kernel. > > I skimmed over most of the series, and I am not convinced that this is actually a cleanup. If we cannot really always differentiate between sw/hw clearing, why have separate primitives that give one the illusion that it could be done and that they are two different concepts? Maybe there are other opinions, but at least for me this made the code harder to grasp. I do appreciate a doc update, though :) -- Cheers, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel