From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0854C64ED6 for ; Mon, 27 Feb 2023 19:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/9zQEBoiCwNt/MNn2oylJAX0NC5Q7AOdTGusTrDtkx4=; b=Jka/qL79m96qM8 FULcmufslSlIHtKYH+A8q+fzz6vEjm5WjKoKoktUH6K7Y+BjbwUJoANVZCfdC+XRQP19H9r2xlp1f RgImy5l4rbUBFpbWHlTvG0GC3tu8iFJYpswAQa0xfhRu7WKvFihtbs+g+bbe9KZ6xsro6njg80/sa 0x8u7Ylv/7zRlq9d23/TRsn3ekxYTz13cP5TGHPrRmel24t10kDc1gXkU8LKH6h4Q1YqYbcE4us5S Fc5Wbff/mdH3JiK1pMlMHToNzyzedAihU91I9/o5PyTD+LuNaHh2TcOseF5vR+OFms6KCTmp7bcFc U6itDrAF65DEMTTdc4qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWjc3-00B4Ma-4F; Mon, 27 Feb 2023 19:56:43 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWjby-00B4Kj-IN for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 19:56:40 +0000 Received: by mail-qt1-x835.google.com with SMTP id c18so8045326qte.5 for ; Mon, 27 Feb 2023 11:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6WyizIs0G0DtqskbG4LDktWFu7XM+98HS/yWMgv+O1M=; b=lMNG2UzQuQX6PthMTP9zEUUGpBWxGhXSLrSt5NuDsbEtQ+rx8xjqn6DHFcFmqLzhlG 7yc4UFog/eNkldwZaLocvjQX3y1hSB0qsUWE8azN6bRn/mtw1p6mEzFhn3ANQB1nVaH4 slgX5tCjdvtXYoqYqmRdQP9mT0M6C4dPrIBvcOt0zZwcuOeGJagc9ZvwZ2thQ2eFq2am eHSK+aid8yeV8kNoF0OytN/ljSrGHaYokGPf3MbHHndXCo4um3YwOXRnvilrjuYRK5Ln M6yGAj907OZkm1PHkoCZjjr3fApr1OMdeIvndgINdByh7K8YpqPOdnuhVMI+moyStc1p 3Uag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6WyizIs0G0DtqskbG4LDktWFu7XM+98HS/yWMgv+O1M=; b=rGGo6Lh9tY7NjtExyMaS6FPm5DhtmjC9Fe/XNYSywCvGdSd9d1tWWtrElXKHKb/lXo t9BVJ3wUDgpRCZ528+eXknhZErvVlaos1MowUtlf6kuxyxfKB93v5GfN8mZoOarUMVMU y3KLtm7Q00dQU7HVq0V5/OoXOmTJIJ5x3W8V19m1itffdSq/WuflL9rUd8nfN6kaNu1J cs0EVelfOHxZyaKtu0H8h5ofo9nLH8Rn2snLM0d3PiBOJ+yP8bFrf39puZkS5z3a4cbQ Js2O7UXUIaAGRHmeC+/EGoepG9K888sJYJyBkMa0b5P99nvk+1fqKlBwCVRMurWP9zf8 9X9w== X-Gm-Message-State: AO0yUKW/HqEBSdaSAWYAdkpX7VNglwAEbwCEfzNf+PZ0C9h0bBUQWJuF aSOnD9LLiPk/onZOCgR00wmRkkBFlYc= X-Google-Smtp-Source: AK7set8YtMSJUdatqaPYbQ1tAuu+IgLsLaLMDlKg5Rux+uLLUIu05Jkh6sSLPa45rsEaJGUo5Mu9Uw== X-Received: by 2002:a05:622a:1d4:b0:3bd:905:3444 with SMTP id t20-20020a05622a01d400b003bd09053444mr961284qtw.8.1677527795177; Mon, 27 Feb 2023 11:56:35 -0800 (PST) Received: from [10.69.71.131] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x17-20020ac87ed1000000b003b835e7e283sm5169475qtj.44.2023.02.27.11.56.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 11:56:34 -0800 (PST) Message-ID: Date: Mon, 27 Feb 2023 11:56:32 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] arm64: ftrace: forbid CALL_OPS with CC_OPTIMIZE_FOR_SIZE Content-Language: en-US To: Mark Rutland , linux-arm-kernel@lists.infradead.org Cc: catalin.marinas@arm.com, maz@kernel.org, rostedt@goodmis.org, stefan.wahren@i2se.com, will@kernel.org References: <20230227115819.365630-1-mark.rutland@arm.com> From: Florian Fainelli In-Reply-To: <20230227115819.365630-1-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_115638_634614_921C6607 X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/27/2023 3:58 AM, Mark Rutland wrote: > Florian reports that when building with CONFIG_CC_OPTIMIZE_FOR_SIZE=y, > he sees "Misaligned patch-site" warnings at boot, e.g. > > | Misaligned patch-site bcm2836_arm_irqchip_handle_irq+0x0/0x88 > | WARNING: CPU: 0 PID: 0 at arch/arm64/kernel/ftrace.c:120 ftrace_call_adjust+0x4c/0x70 > > This is because GCC will silently ignore `-falign-functions=N` when > passed `-Os`, resulting in functions not being aligned as we expect. > This is a known issue, and to account for this we modified the kernel to > avoid `-Os` generally. Unfortunately we forgot to account for > CONFIG_CC_OPTIMIZE_FOR_SIZE. > > Forbid the use of CALL_OPS with CONFIG_CC_OPTIMIZE_FOR_SIZE=y to prevent > this issue. All exising ftrace features will work as before, though > without the performance benefit of CALL_OPS. > > Reported-by: Florian Fainelli > Link: http://lore.kernel.org/linux-arm-kernel/2d9284c3-3805-402b-5423-520ced56d047@gmail.com > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Marc Zyngier > Cc: Stefan Wahren > Cc: Steven Rostedt > Cc: Will Deacon Tested-by: Florian Fainelli Thanks Mark! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel