From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 08/16] PM / OPP: Add clock-latency-ns support
Date: Wed, 29 Jul 2015 16:23:03 +0530 [thread overview]
Message-ID: <b8c6ec6cfbae452514f2e3c55ccf44c4a4e5101d.1438166099.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1438166099.git.viresh.kumar@linaro.org>
With "operating-points-v2" bindings, clock-latency is defined per OPP.
Users of this value expect a single value which defines the latency to
switch to any clock rate. Find maximum clock-latency-ns from the OPP
table to service requests from such users.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/base/power/opp.c | 41 +++++++++++++++++++++++++++++++++++++++--
include/linux/pm_opp.h | 6 ++++++
2 files changed, 45 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index 0e0eff4d9299..8638204c457e 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -57,6 +57,8 @@
* @u_volt_min: Minimum voltage in microvolts corresponding to this OPP
* @u_volt_max: Maximum voltage in microvolts corresponding to this OPP
* @u_amp: Maximum current drawn by the device in microamperes
+ * @clock_latency_ns: Latency (in nanoseconds) of switching to this OPP's
+ * frequency from any other OPP's frequency.
* @dev_opp: points back to the device_opp struct this opp belongs to
* @rcu_head: RCU callback head used for deferred freeing
* @np: OPP's device node.
@@ -75,6 +77,7 @@ struct dev_pm_opp {
unsigned long u_volt_min;
unsigned long u_volt_max;
unsigned long u_amp;
+ unsigned long clock_latency_ns;
struct device_opp *dev_opp;
struct rcu_head rcu_head;
@@ -109,6 +112,8 @@ struct device_opp {
struct srcu_notifier_head srcu_head;
struct rcu_head rcu_head;
struct list_head opp_list;
+
+ unsigned long clock_latency_ns_max;
};
/*
@@ -226,6 +231,32 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq);
/**
+ * dev_pm_opp_get_max_clock_latency() - Get max clock latency in nanoseconds
+ * @dev: device for which we do this operation
+ *
+ * Return: This function returns the max clock latency in nanoseconds.
+ *
+ * Locking: This function takes rcu_read_lock().
+ */
+unsigned long dev_pm_opp_get_max_clock_latency(struct device *dev)
+{
+ struct device_opp *dev_opp;
+ unsigned long clock_latency_ns;
+
+ rcu_read_lock();
+
+ dev_opp = _find_device_opp(dev);
+ if (IS_ERR(dev_opp))
+ clock_latency_ns = 0;
+ else
+ clock_latency_ns = dev_opp->clock_latency_ns_max;
+
+ rcu_read_unlock();
+ return clock_latency_ns;
+}
+EXPORT_SYMBOL_GPL(dev_pm_opp_get_max_clock_latency);
+
+/**
* dev_pm_opp_get_opp_count() - Get number of opps available in the opp list
* @dev: device for which we do this operation
*
@@ -779,6 +810,8 @@ static int _opp_add_static_v2(struct device *dev, struct device_node *np)
new_opp->np = np;
new_opp->dynamic = false;
new_opp->available = true;
+ of_property_read_u32(np, "clock-latency-ns",
+ (u32 *)&new_opp->clock_latency_ns);
ret = opp_get_microvolt(new_opp, dev);
if (ret)
@@ -790,11 +823,15 @@ static int _opp_add_static_v2(struct device *dev, struct device_node *np)
if (ret)
goto free_opp;
+ if (new_opp->clock_latency_ns > dev_opp->clock_latency_ns_max)
+ dev_opp->clock_latency_ns_max = new_opp->clock_latency_ns;
+
mutex_unlock(&dev_opp_list_lock);
- pr_debug("%s: turbo:%d rate:%lu uv:%lu uvmin:%lu uvmax:%lu\n",
+ pr_debug("%s: turbo:%d rate:%lu uv:%lu uvmin:%lu uvmax:%lu latency:%lu\n",
__func__, new_opp->turbo, new_opp->rate, new_opp->u_volt,
- new_opp->u_volt_min, new_opp->u_volt_max);
+ new_opp->u_volt_min, new_opp->u_volt_max,
+ new_opp->clock_latency_ns);
/*
* Notify the changes in the availability of the operable
diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h
index cec2d4540914..20324b579adc 100644
--- a/include/linux/pm_opp.h
+++ b/include/linux/pm_opp.h
@@ -31,6 +31,7 @@ unsigned long dev_pm_opp_get_voltage(struct dev_pm_opp *opp);
unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp);
int dev_pm_opp_get_opp_count(struct device *dev);
+unsigned long dev_pm_opp_get_max_clock_latency(struct device *dev);
struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev,
unsigned long freq,
@@ -67,6 +68,11 @@ static inline int dev_pm_opp_get_opp_count(struct device *dev)
return 0;
}
+static inline unsigned long dev_pm_opp_get_max_clock_latency(struct device *dev)
+{
+ return 0;
+}
+
static inline struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev,
unsigned long freq, bool available)
{
--
2.4.0
next prev parent reply other threads:[~2015-07-29 10:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 10:52 [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings Viresh Kumar
2015-07-29 10:52 ` [PATCH V3 01/16] PM / OPP: Update bindings to make opp-hz a 64 bit value Viresh Kumar
2015-07-30 13:23 ` Rob Herring
2015-07-29 10:52 ` [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings Viresh Kumar
2015-07-30 13:18 ` Rob Herring
2015-07-30 13:49 ` Viresh Kumar
2015-07-30 16:24 ` Rob Herring
2015-07-30 16:52 ` Viresh Kumar
2015-07-30 16:57 ` [PATCH V3 resend] " Viresh Kumar
2015-07-29 10:52 ` [PATCH V3 03/16] PM / OPP: Relocate few routines Viresh Kumar
2015-07-29 10:52 ` [PATCH V3 04/16] PM / OPP: Create _remove_device_opp() for freeing dev_opp Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 05/16] PM / OPP: Allocate dev_opp from _add_device_opp() Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 06/16] PM / OPP: Break _opp_add_dynamic() into smaller functions Viresh Kumar
2015-07-31 5:43 ` Stephen Boyd
2015-07-29 10:53 ` [PATCH V3 07/16] PM / OPP: Add support to parse "operating-points-v2" bindings Viresh Kumar
2015-07-31 5:51 ` Stephen Boyd
2015-07-31 5:58 ` Viresh Kumar
2015-07-31 6:20 ` Stephen Boyd
2015-07-29 10:53 ` Viresh Kumar [this message]
2015-07-29 10:53 ` [PATCH V3 09/16] PM / OPP: Add OPP sharing information to OPP library Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 10/16] PM / OPP: Add support for opp-suspend Viresh Kumar
2015-07-31 6:24 ` Stephen Boyd
2015-07-31 6:26 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 11/16] PM / OPP: Add helpers for initializing CPU OPPs Viresh Kumar
2015-07-31 6:07 ` Stephen Boyd
2015-07-31 6:13 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 12/16] PM / OPP: add dev_pm_opp_is_turbo() helper Viresh Kumar
2015-07-31 6:10 ` Stephen Boyd
2015-07-31 6:17 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 13/16] cpufreq: Update boost flag while initializing freq table from OPPs Viresh Kumar
2015-07-31 6:11 ` Stephen Boyd
2015-07-29 10:53 ` [PATCH V3 14/16] cpufreq: Allow drivers to enable boost support after registering driver Viresh Kumar
2015-07-31 6:12 ` Stephen Boyd
2015-07-29 10:53 ` [PATCH V3 15/16] cpufreq: dt: Add support for operating-points-v2 bindings Viresh Kumar
2015-07-31 6:15 ` Stephen Boyd
2015-07-29 10:53 ` [PATCH V3 16/16] cpufreq: dt: Add support for turbo/boost mode Viresh Kumar
2015-07-31 6:16 ` Stephen Boyd
2015-07-31 18:55 ` [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c6ec6cfbae452514f2e3c55ccf44c4a4e5101d.1438166099.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).