From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E2F2EB64DD for ; Wed, 9 Aug 2023 04:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=roJWxgWpg2yAeRMFovwzxPLpLp3laZHy7nBK9Zk0M6k=; b=bqC1eRZLYoZ+Gm BB0a++teMuinM2niHYxEDNW3MRmdoPpGVG+79M1EmK2qv5xaeOFh1v4bIfBS9xQhifgxLcOmoqlU8 CC0p5fk6K3ofBwhTlnNJy7sT/s6KEqLKV9R84i/Uutb0khUsrzWSZ0IKw6EAYMxj8wSo1V+PseY9v A5GIiU7zuC/kQKPkyyMfatXdOF04oDsMzxGNyEKDTMvGKP813edsiV5QmCHSSZP0OBBMPAckL9i6f 82+IZqMdy33rTXA9gyNH2htmzdvBYT1oUhuSwlLFIGT57JY9EqPzluOMPoGxBzgxcuDbRhEOEV9Nr YWBpYf7mEEV3h/xK5BkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTaWj-003zhn-2Q; Wed, 09 Aug 2023 04:10:29 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTaWg-003zh6-2x for linux-arm-kernel@lists.infradead.org; Wed, 09 Aug 2023 04:10:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691554225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tiZt5qkV373iiZscCJbcFROPFCou/fOb43yGS5e3+0c=; b=YmzaRhSdtesVBrKBFx1F1608suHHW/rr+Rs3HyqjbLRFg3fQjlzR+hbS+c+96bOnFAfZTu AikIz/SSQLCCn/jTxdIdBZYcowijdU9EJmW4aqBSTRkLZaTfvrPvyapYTADd9WqsUsqHST Bb3S0rYpnXelbqLBonqA4dvR19vkwxo= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-yaz6dle7Nt2re5iRaeGyyw-1; Wed, 09 Aug 2023 00:10:24 -0400 X-MC-Unique: yaz6dle7Nt2re5iRaeGyyw-1 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-686bc3f11feso479276b3a.0 for ; Tue, 08 Aug 2023 21:10:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691554223; x=1692159023; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tiZt5qkV373iiZscCJbcFROPFCou/fOb43yGS5e3+0c=; b=RnPUqUwjfGNCgpwDX1OZadvaxqECb820LBMCrsJHTdxfWWWD62XSOcWy/QLkjoR2Ot u5MtjeIe4X42ecDG05bhul2Fc7Wdjj6z095nPy/2snxXILk4B3UzEqpnqpiXAgmSdQzj fVH4fhHWUq/ovSNWXCp5MUcJPnn1336JkXeL79hYoZdc5YExeCJX7VidMfDr0Vhv743t 02rBRcejgmrPg4ajkl7s1DeDH4c9JDJZJ1hltmiTd8gN8SViLttdtSEhu6J5SzOnjKQY FQsYs3q62GO7R16oyxtsDCU3z/6zSy4JUutVB2wYA9yF27J30tAr9AECe7CoLnRCaVVp ploA== X-Gm-Message-State: AOJu0YyiPwxozcZ4Pjxon+vYy/+F+ewV8RXLp3jD+7MZ/5sTkn+BXoAT 9NdhoybUBdNNUSIzfulCpDeklp9jLwHStTWk6NcU0ZAy+i0OinFTis3r81KnGw7tbO53DJHuRSo WK7AknaAA7fQrTFDjmObYdPnOgxsX9A9+9bM= X-Received: by 2002:a05:6a00:1487:b0:666:eaaf:a2af with SMTP id v7-20020a056a00148700b00666eaafa2afmr2263681pfu.14.1691554222963; Tue, 08 Aug 2023 21:10:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4mKNqTgX+EsfCEP/MYW99W9JIOB5kHuLZbEs18DPRnq1dfDRhMLd6YmPemv3TlybaLWWmcQ== X-Received: by 2002:a05:6a00:1487:b0:666:eaaf:a2af with SMTP id v7-20020a056a00148700b00666eaafa2afmr2263648pfu.14.1691554222702; Tue, 08 Aug 2023 21:10:22 -0700 (PDT) Received: from ?IPV6:2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5? ([2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5]) by smtp.gmail.com with ESMTPSA id p26-20020a62ab1a000000b006871fdde2c7sm8840727pff.110.2023.08.08.21.10.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 21:10:22 -0700 (PDT) Message-ID: Date: Wed, 9 Aug 2023 14:10:12 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v8 03/14] KVM: arm64: Use kvm_arch_flush_remote_tlbs() To: Raghavendra Rao Ananta , Oliver Upton , Marc Zyngier , James Morse , Suzuki K Poulose Cc: Paolo Bonzini , Sean Christopherson , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , Fuad Tabba , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Shaoqin Huang References: <20230808231330.3855936-1-rananta@google.com> <20230808231330.3855936-4-rananta@google.com> From: Gavin Shan In-Reply-To: <20230808231330.3855936-4-rananta@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_211027_046526_A1E7266F X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/9/23 09:13, Raghavendra Rao Ananta wrote: > Stop depending on CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL and opt to > standardize on kvm_arch_flush_remote_tlbs() since it avoids > duplicating the generic TLB stats across architectures that implement > their own remote TLB flush. > > This adds an extra function call to the ARM64 kvm_flush_remote_tlbs() > path, but that is a small cost in comparison to flushing remote TLBs. > > In addition, instead of just incrementing remote_tlb_flush_requests > stat, the generic interface would also increment the > remote_tlb_flush stat. > > Signed-off-by: Raghavendra Rao Ananta > Reviewed-by: Shaoqin Huang > --- > arch/arm64/include/asm/kvm_host.h | 2 ++ > arch/arm64/kvm/Kconfig | 1 - > arch/arm64/kvm/mmu.c | 6 +++--- > 3 files changed, 5 insertions(+), 4 deletions(-) > Reviewed-by: Gavin Shan > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 8b6096753740c..20f2ba149c70c 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -1111,6 +1111,8 @@ int __init kvm_set_ipa_limit(void); > #define __KVM_HAVE_ARCH_VM_ALLOC > struct kvm *kvm_arch_alloc_vm(void); > > +#define __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS > + > static inline bool kvm_vm_is_protected(struct kvm *kvm) > { > return false; > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > index f531da6b362e9..6b730fcfee379 100644 > --- a/arch/arm64/kvm/Kconfig > +++ b/arch/arm64/kvm/Kconfig > @@ -25,7 +25,6 @@ menuconfig KVM > select MMU_NOTIFIER > select PREEMPT_NOTIFIERS > select HAVE_KVM_CPU_RELAX_INTERCEPT > - select HAVE_KVM_ARCH_TLB_FLUSH_ALL > select KVM_MMIO > select KVM_GENERIC_DIRTYLOG_READ_PROTECT > select KVM_XFER_TO_GUEST_WORK > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 6db9ef288ec38..0ac721fa27f18 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -161,15 +161,15 @@ static bool memslot_is_logging(struct kvm_memory_slot *memslot) > } > > /** > - * kvm_flush_remote_tlbs() - flush all VM TLB entries for v7/8 > + * kvm_arch_flush_remote_tlbs() - flush all VM TLB entries for v7/8 > * @kvm: pointer to kvm structure. > * > * Interface to HYP function to flush all VM TLB entries > */ > -void kvm_flush_remote_tlbs(struct kvm *kvm) > +int kvm_arch_flush_remote_tlbs(struct kvm *kvm) > { > - ++kvm->stat.generic.remote_tlb_flush_requests; > kvm_call_hyp(__kvm_tlb_flush_vmid, &kvm->arch.mmu); > + return 0; > } > > static bool kvm_is_device_pfn(unsigned long pfn) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel