From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F9C0C54791 for ; Wed, 13 Mar 2024 12:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l0nw0butD/pHJazz3+/N3jiUNHN3ExuJyal8qjbG0/M=; b=zAmiPeMX6+VzVw z+bfRAhNYsTjgQFa3tEfBPQQbD1Zqtf0His/0XWwe7FRqDq78qt0YK3swVdpOZbdi+LTMik1/hxXI zCApWjdDwv2AutE+fLcchaBQSS7QCozxT9o2gQjN8a5A18JQZZIPGDS/3YJUZwlrDMWu3jX4TApHS +HzrIo+47RjJ9RTj3AE/Mv1qLC0uw+8qZNki8gS+8tjG2sdQ8wi+JFXxLVnIzjc8uZ99tjaC8JAjG pPrpkC2gh9ue1djlJMXqQSZ1Hpag12EpONymXesrg6z12Jn4RXK8qhUsTEhcVIc0WizBLGhS7NzGp X+Vs8KdqmvFYAyYpX2Ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkNf2-0000000A3j0-1YbD; Wed, 13 Mar 2024 12:24:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkNey-0000000A3hn-2k0P for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 12:24:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F8151007; Wed, 13 Mar 2024 05:25:13 -0700 (PDT) Received: from [10.57.52.245] (unknown [10.57.52.245]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BA2D03F762; Wed, 13 Mar 2024 05:24:33 -0700 (PDT) Message-ID: Date: Wed, 13 Mar 2024 12:24:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/10] perf: Define common uncore capabilities Content-Language: en-GB To: James Clark Cc: Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-perf-users@vger.kernel.org, jialong.yang@shingroup.cn, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Will Deacon References: <8496411b6ae9306b70cb90edafa4134b113a3cfe.1710257512.git.robin.murphy@arm.com> <993147ab-26b5-e497-d50f-0f500c8c81b8@arm.com> From: Robin Murphy In-Reply-To: <993147ab-26b5-e497-d50f-0f500c8c81b8@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_052440_756939_D5454E34 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-03-13 11:23 am, James Clark wrote: > > > On 12/03/2024 17:34, Robin Murphy wrote: >> Nearly all uncore/system PMUs share a common set of capbilities, >> so let's wrap those up in a single macro for ease of use. >> >> Signed-off-by: Robin Murphy >> --- >> include/linux/perf_event.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h >> index b1fd832ed8bf..5d5db122005b 100644 >> --- a/include/linux/perf_event.h >> +++ b/include/linux/perf_event.h >> @@ -293,6 +293,9 @@ struct perf_event_pmu_context; >> #define PERF_PMU_CAP_EXTENDED_HW_TYPE 0x0100 >> #define PERF_PMU_CAP_NO_COMMON_EVENTS 0x0200 >> >> +#define PERF_PMU_UNCORE_CAPS \ >> +(PERF_PMU_CAP_NO_SAMPLING| PERF_PMU_CAP_NO_EXCLUDE | PERF_PMU_CAP_NO_COMMON_EVENTS) >> + > > The most minor of nits: missing space before |. There is another one in > another commit that triggers checkpatch but that line gets deleted anyway. Bleh, thanks for the catch. And it seems that wasn't the only thing I inexplicably managed to mess up in the rename patch either... All fixed locally now. Cheers, Robin. > >> struct perf_output_handle; >> >> #define PMU_NULL_DEV ((void *)(~0UL)) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel