From: Andre Przywara <andre.przywara@arm.com>
To: Niyas Sait <niyas.sait@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Ben Horgan <ben.horgan@arm.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Fenghua Yu <fenghuay@nvidia.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Srivathsa L Rao <srivathsa.rao@oss.qualcomm.com>,
Ganapatrao Kulkarni <ganapatrao.kulkarni@oss.qualcomm.com>,
Trilok Soni <tsoni@quicinc.com>,
Srinivas Ramana <sramana@qti.qualcomm.com>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 16/16] arm_mpam: detect and enable MPAM-Fb PCC support
Date: Tue, 21 Jul 2026 16:54:38 +0200 [thread overview]
Message-ID: <b943d2e7-9f74-40f6-bbaa-84642ea785eb@arm.com> (raw)
In-Reply-To: <9ac5f187-ff48-434b-a1c0-7f73b442083c@arm.com>
Hi Niyas,
On 7/14/26 14:32, Niyas Sait wrote:
> On 10/07/2026 15:45, Andre Przywara wrote:
>> + cur->pcc_cl.dev = dev;
>> + cur->pcc_cl.rx_callback = mpam_pcc_rx_callback;
>> + cur->pcc_cl.tx_block = true;
>> + cur->pcc_cl.tx_tout = 1000; /* 1s */
>
> Should this timeout be based on nominal latency reported in PCC table
> instead of being hard coded to 1s here? May be some multiple of nominal
> latency reported
I originally thought that this would be handled by the PCC code, but
that just parses the value, and puts it in the pcc_mbox_chan struct.
Which we only get access to *after* we request the channel in the next
line here.
But it's only mbox_send_message() that uses the value, so I think we can
populate that value later on still. And yeah, some multiple of the
nominal latency sounds reasonable.
Cheers,
Andre
next prev parent reply other threads:[~2026-07-21 14:54 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 14:45 [PATCH v3 00/16] arm_mpam: Add MPAM-Fb firmware support Andre Przywara
2026-07-10 14:45 ` [PATCH v3 01/16] arm_mpam: let low level MSC read accessors return an error Andre Przywara
2026-07-10 18:11 ` Jonathan Cameron
2026-07-10 21:40 ` Andre Przywara
2026-07-15 16:01 ` Ben Horgan
2026-07-10 14:45 ` [PATCH v3 02/16] arm_mpam: propagate MSC read errors for wrapper functions Andre Przywara
2026-07-10 18:21 ` Jonathan Cameron
2026-07-20 15:58 ` Andre Przywara
2026-07-10 14:45 ` [PATCH v3 03/16] arm_mpam: propagate MSC read errors for hw_probe functions Andre Przywara
2026-07-10 18:31 ` Jonathan Cameron
2026-07-10 14:45 ` [PATCH v3 04/16] arm_mpam: propagate MSC read errors for mpam_msc_read_mbwu_l() Andre Przywara
2026-07-10 18:40 ` Jonathan Cameron
2026-07-15 13:35 ` Ben Horgan
2026-07-10 14:45 ` [PATCH v3 05/16] arm_mpam: propagate MSC read errors for msmon helpers Andre Przywara
2026-07-10 18:44 ` Jonathan Cameron
2026-07-10 14:45 ` [PATCH v3 06/16] arm_mpam: propagate MSC read errors for __ris_msmon_read() Andre Przywara
2026-07-10 18:48 ` Jonathan Cameron
2026-07-15 19:52 ` Lee Trager
2026-07-16 8:42 ` Ben Horgan
2026-07-10 14:45 ` [PATCH v3 07/16] arm_mpam: __ris_msmon_read(): get rid of nrdy special handling Andre Przywara
2026-07-10 18:56 ` Jonathan Cameron
2026-07-20 15:57 ` Andre Przywara
2026-07-15 13:39 ` Ben Horgan
2026-07-20 15:58 ` Andre Przywara
2026-07-20 16:09 ` Ben Horgan
2026-07-10 14:45 ` [PATCH v3 08/16] arm_mpam: propagate MSC read errors for state saving functions Andre Przywara
2026-07-10 19:00 ` Jonathan Cameron
2026-07-20 15:57 ` Andre Przywara
2026-07-10 14:45 ` [PATCH v3 09/16] arm_mpam: let low level MSC write accessors return an error Andre Przywara
2026-07-10 19:02 ` Jonathan Cameron
2026-07-10 14:45 ` [PATCH v3 10/16] arm_mpam: propagate MSC write errors for ESR and part_sel wrappers Andre Przywara
2026-07-10 14:45 ` [PATCH v3 11/16] arm_mpam: propagate MSC write errors for hardware probe functions Andre Przywara
2026-07-10 19:04 ` Jonathan Cameron
2026-07-10 14:45 ` [PATCH v3 12/16] arm_mpam: propagate MSC write errors for remaining MSC write users Andre Przywara
2026-07-10 19:10 ` Jonathan Cameron
2026-07-10 14:45 ` [PATCH v3 13/16] arm_mpam: prepare mon_sel locking for MPAM-Fb Andre Przywara
2026-07-10 19:14 ` Jonathan Cameron
2026-07-21 15:22 ` Andre Przywara
2026-07-15 15:16 ` Ben Horgan
2026-07-10 14:45 ` [PATCH v3 14/16] arm_mpam: add MPAM-Fb MSC firmware access support Andre Przywara
2026-07-10 19:58 ` Jonathan Cameron
2026-07-14 12:27 ` Niyas Sait
2026-07-15 16:17 ` Ben Horgan
2026-07-10 14:45 ` [PATCH v3 15/16] arm_mpam: prevent MPAM-Fb accesses inside IRQ handler Andre Przywara
2026-07-15 16:08 ` Ben Horgan
2026-07-10 14:45 ` [PATCH v3 16/16] arm_mpam: detect and enable MPAM-Fb PCC support Andre Przywara
2026-07-10 20:10 ` Jonathan Cameron
2026-07-21 13:47 ` Andre Przywara
2026-07-14 12:32 ` Niyas Sait
2026-07-21 14:54 ` Andre Przywara [this message]
2026-07-15 16:08 ` Lee Trager
[not found] ` <52dc486f-2ef2-4c57-b3fb-fb4c240a9198@trager.us_quarantine>
2026-07-21 14:51 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b943d2e7-9f74-40f6-bbaa-84642ea785eb@arm.com \
--to=andre.przywara@arm.com \
--cc=ben.horgan@arm.com \
--cc=catalin.marinas@arm.com \
--cc=fenghuay@nvidia.com \
--cc=ganapatrao.kulkarni@oss.qualcomm.com \
--cc=guohanjun@huawei.com \
--cc=james.morse@arm.com \
--cc=jic23@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=niyas.sait@arm.com \
--cc=rafael@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=sramana@qti.qualcomm.com \
--cc=srivathsa.rao@oss.qualcomm.com \
--cc=sudeep.holla@kernel.org \
--cc=tsoni@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox