Re: [PATCH v4 5/9] gpio: Add new gpio-macsmc driver for Apple Macs

["Sven Peter" <sven@svenpeter.dev>]

Hi,


On Tue, May 6, 2025, at 10:07, Bartosz Golaszewski wrote:
> On Sat, May 3, 2025 at 12:07 PM Sven Peter via B4 Relay
> <devnull+sven.svenpeter.dev@kernel.org> wrote:
>>
>> From: Hector Martin <marcan@marcan.st>
>>
>> This driver implements the GPIO service on top of the SMC framework
>> on Apple Mac machines. In particular, these are the GPIOs present in the
>> PMU IC which are used to control power to certain on-board devices.
>>
>> Although the underlying hardware supports various pin config settings
>> (input/output, open drain, etc.), this driver does not implement that
>> functionality and leaves it up to the firmware to configure things
>> properly. We also don't yet support interrupts/events. This is
>> sufficient for device power control, which is the only thing we need to
>> support at this point. More features will be implemented when needed.
>>
>> To our knowledge, only Apple Silicon Macs implement this SMC feature.
>>
>> Signed-off-by: Hector Martin <marcan@marcan.st>
>> Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>> Reviewed-by: Sven Peter <sven@svenpeter.dev>
>> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>> Signed-off-by: Sven Peter <sven@svenpeter.dev>
>> ---
>
> [snip]
>
>> +
>> +       smcgp->gc.label = "macsmc-pmu-gpio";
>> +       smcgp->gc.owner = THIS_MODULE;
>> +       smcgp->gc.get = macsmc_gpio_get;
>> +       smcgp->gc.set = macsmc_gpio_set;
>
> I must have given my Reviewed-by under this driver before we started
> the conversion to the new GPIO driver setters. Could you please
> replace this with set_rv() as the old set() is now deprecated?

Probably, the last version I took from the ML is from November 2022 :-(
Will do that for the next version, I can just pass through the return value
we get from apple_smc_write_u32 anyway.


Thanks,


Sven


-- >8 --
Subject: [PATCH] fixup! gpio: Add new gpio-macsmc driver for Apple Macs

---
 drivers/gpio/gpio-macsmc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-macsmc.c b/drivers/gpio/gpio-macsmc.c
index 289be4268f63..a68676239718 100644
--- a/drivers/gpio/gpio-macsmc.c
+++ b/drivers/gpio/gpio-macsmc.c
@@ -135,7 +135,7 @@ static int macsmc_gpio_get(struct gpio_chip *gc, unsigned int offset)
 	return val ? 1 : 0;
 }

-static void macsmc_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
+static int macsmc_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
 {
 	struct macsmc_gpio *smcgp = gpiochip_get_data(gc);
 	smc_key key = macsmc_gpio_key(offset);
@@ -146,6 +146,8 @@ static void macsmc_gpio_set(struct gpio_chip *gc, unsigned int offset, int value
 	if (ret < 0)
 		dev_err(smcgp->dev, "GPIO set failed %p4ch = 0x%x\n",
 			&key, value);
+
+	return ret;
 }

 static int macsmc_gpio_init_valid_mask(struct gpio_chip *gc,
@@ -214,7 +216,7 @@ static int macsmc_gpio_probe(struct platform_device *pdev)
 	smcgp->gc.label = "macsmc-pmu-gpio";
 	smcgp->gc.owner = THIS_MODULE;
 	smcgp->gc.get = macsmc_gpio_get;
-	smcgp->gc.set = macsmc_gpio_set;
+	smcgp->gc.set_rv = macsmc_gpio_set;
 	smcgp->gc.get_direction = macsmc_gpio_get_direction;
 	smcgp->gc.init_valid_mask = macsmc_gpio_init_valid_mask;
 	smcgp->gc.can_sleep = true;
--
2.34.1