From: "Maxime Ripard" <mripard@kernel.org>
To: "Jernej Skrabec" <jernej.skrabec@gmail.com>
Cc: airlied@gmail.com, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
mripard@kernel.org, samuel@sholland.org, wens@csie.org,
"Maxime Ripard" <mripard@kernel.org>
Subject: Re: [PATCH 2/7] drm/sun4i: dw-hdmi: Remove double encoder cleanup
Date: Mon, 25 Sep 2023 07:44:15 +0000 [thread overview]
Message-ID: <b96d809490814cce95ec13ef8e21d3d1.mripard@kernel.org> (raw)
In-Reply-To: <20230924192604.3262187-3-jernej.skrabec@gmail.com>
On Sun, 24 Sep 2023 21:25:59 +0200, Jernej Skrabec wrote:
> It turns out that comment is wrong - dw hdmi driver never does any
> encoder cleanup. In fact, cleanup is done automatically, in destroy
> callback of encoder. Even more, encoder memory will be freed when hdmi
> device is destroyed. However, encoder will be cleaned up after that, in
> drm_mode_config_cleanup(), which is called later. This will cause use
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-25 7:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 19:25 [PATCH 0/7] drm/sun4i: dw-hdmi: Fix initialization & refactor Jernej Skrabec
2023-09-24 19:25 ` [PATCH 1/7] drm/sun4i: dw-hdmi: Deinit PHY in fail path Jernej Skrabec
2023-09-25 7:43 ` Maxime Ripard
2023-09-24 19:25 ` [PATCH 2/7] drm/sun4i: dw-hdmi: Remove double encoder cleanup Jernej Skrabec
2023-09-25 7:44 ` Maxime Ripard [this message]
2023-09-24 19:26 ` [PATCH 3/7] drm/sun4i: dw-hdmi: Switch to bridge functions Jernej Skrabec
2023-09-25 7:57 ` Maxime Ripard
2023-09-25 15:29 ` Jernej Škrabec
2023-10-05 8:42 ` Maxime Ripard
2023-09-24 19:26 ` [PATCH 4/7] drm/sun4i: Don't show error for deferred probes Jernej Skrabec
2023-09-25 7:45 ` Maxime Ripard
2023-09-24 19:26 ` [PATCH 5/7] drm/sun4i: dw-hdmi: Split driver registration Jernej Skrabec
2023-09-25 2:35 ` kernel test robot
2023-09-25 7:47 ` Maxime Ripard
2023-09-25 15:07 ` Jernej Škrabec
2023-10-05 8:43 ` Maxime Ripard
2023-10-13 19:50 ` Jernej Škrabec
2023-09-25 16:40 ` kernel test robot
2023-09-24 19:26 ` [PATCH 6/7] drm/sun4i: dw-hdmi: Make sun8i_hdmi_phy_get() more intuitive Jernej Skrabec
2023-09-24 19:26 ` [PATCH 7/7] drm/sun4i: dw-hdmi: check for phy device first Jernej Skrabec
2023-09-25 7:50 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96d809490814cce95ec13ef8e21d3d1.mripard@kernel.org \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).