From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32403CE7A89 for ; Mon, 25 Sep 2023 07:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:References:In-Reply-To: Subject:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MwKTKUg7cVKlcn/0YMWxiyibAAqKx/XgUlKIGPGv43o=; b=NLjIcRQMofnGyf bmCkl0jDUJB7oWXaaaXfV4w4YLHxAohyb6S8IhFZ+SjyiNOGrSWtCgGIVR4bLujOXsULhQYQuM/yd b8Oo9iJJWS89R1dioAdZNZDqVT1ajJezcJWr2WQUy1IfCVOsAzMeFxVP2C2pZ34C5jBhCaxBFYmjQ 0d8Qqu0/g5UJzxkVbD2OUaL/h6dqafimR9n4gN9lXeBj935HTBlpZepxhHNEQWB/sAaNKnTJP0fy7 hlXF2gYQ3CCP2zivb7X25x/Y+WfpjQiRUi2U8ugAvyLv36dURlUGn9jhUNcLRYWmX64lKBeTfFMJs uDhooqHJyVxGW9E5qlaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkgGS-00De5l-30; Mon, 25 Sep 2023 07:44:20 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkgGQ-00De4Y-2R for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 07:44:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4251860F60; Mon, 25 Sep 2023 07:44:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56685C433CA; Mon, 25 Sep 2023 07:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695627857; bh=HGbj+fObT8u6gTICGsTkRzwnurezQLIHLfZnqiBm5js=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=GGSj1y/GZBESvrJwHEtIwCeJboCOT+s3GpBV7F/TNSTPOGssUZew5WtCI9hcGY5cl SjRTDUZqAANJZcy1iLpI714Y61sc83YcmpxJWTMxEfJxIyeJmn6/c8+hJq26q/RxF0 RhEaHt7Oq8m5z3tESrmS1AubR6iYJmL3yDEG+I91W3PYCyMPeVYASln5pFRWkSvL8H stXmjH278Xof+DRrjbgIgj4XylNG4rzO9ZpOLbMcbgHIzz3yXMbz6TwMyKKrPreK/d 42H3CHU06G6Fbj6bu1Z9vIbOeX/9AFeFYoNJocJlRVNSTdkCugEpu02cYYo9u9awYg soPW50dMpGf/g== Message-ID: Date: Mon, 25 Sep 2023 07:44:15 +0000 From: "Maxime Ripard" To: "Jernej Skrabec" Subject: Re: [PATCH 2/7] drm/sun4i: dw-hdmi: Remove double encoder cleanup In-Reply-To: <20230924192604.3262187-3-jernej.skrabec@gmail.com> References: <20230924192604.3262187-3-jernej.skrabec@gmail.com> Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, mripard@kernel.org, samuel@sholland.org, wens@csie.org, "Maxime Ripard" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_004418_838241_A0B5CCED X-CRM114-Status: UNSURE ( 8.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 24 Sep 2023 21:25:59 +0200, Jernej Skrabec wrote: > It turns out that comment is wrong - dw hdmi driver never does any > encoder cleanup. In fact, cleanup is done automatically, in destroy > callback of encoder. Even more, encoder memory will be freed when hdmi > device is destroyed. However, encoder will be cleaned up after that, in > drm_mode_config_cleanup(), which is called later. This will cause use > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel