From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 442A7ECAAA1 for ; Tue, 30 Aug 2022 06:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=24OhTLuYdZXGPrJqihxB+4CNiJgdGk/QjN9lsAGrW8c=; b=oI7Sqq8/BAMq6RUt4WoKgpAneN mrlNSNq9rWivpQgM6m/P1RJrQhQasBJhxqbG7kU6/b8hPVZzQA4RU+yhodZnBsfWl6K7bYA/08W6d cB3oXlkT7riRzgckMseCbzsmJPDlPE81dQ5pk0oZuRcM0veMfbueMLTGjkZN6fvhq/fyEDHOWIT6Q /FD0CUhhZ2Epa78xuHQZZ0oYfsQYSL6GTLjYLU7NEskpopikKFO+2HMnRGCC+9tGYvr0HTxGs+lPb BCqjZwcJSpYhH6imlmSZO8UWUB3rBk9f2+tf0FeynYJBvPCNyWgAtUIkG4W8Ka4RoRb6jXg06tOU0 S177t5cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSuPv-00EKdc-FP; Tue, 30 Aug 2022 06:08:07 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSuPs-00EKcB-GF; Tue, 30 Aug 2022 06:08:05 +0000 Received: from [10.18.29.47] (10.18.29.47) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Tue, 30 Aug 2022 14:08:02 +0800 Message-ID: Date: Tue, 30 Aug 2022 14:08:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH V3 3/6] clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver Content-Language: en-US To: Jerome Brunet , , , , , , Rob Herring , Neil Armstrong , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl References: <20220805085716.5635-1-yu.tu@amlogic.com> <20220805085716.5635-4-yu.tu@amlogic.com> <1jiln0yzgj.fsf@starbuckisacylon.baylibre.com> <1jwnartm78.fsf@starbuckisacylon.baylibre.com> From: Yu Tu In-Reply-To: <1jwnartm78.fsf@starbuckisacylon.baylibre.com> X-Originating-IP: [10.18.29.47] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_230804_636425_C272CE9F X-CRM114-Status: UNSURE ( 8.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/8/29 17:46, Jerome Brunet wrote: > [ EXTERNAL EMAIL ] > > > On Mon 15 Aug 2022 at 14:34, Yu Tu wrote: > >> Hi Jerome, >> >> On 2022/8/10 21:47, Jerome Brunet wrote: >>> [ EXTERNAL EMAIL ] >>> On Fri 05 Aug 2022 at 16:57, Yu Tu wrote: >>> */ > > [... ] > >>>> +#define ANACTRL_FIXPLL_CTRL0 (0x0010 << 2) >>> I already commented on the "<< 2" . Remove them please. >> Sorry, maybe I didn't pay attention to this comment earlier. A little bit >> of a question why is this not okay? I understand isn't it better for the >> compiler to help with this calculation itself? > > Because it is aweful to read > > Also please trim your replies. > It is a bit annoying to search for your comments in the replies > Okay. Like this? > > > . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel