* [PATCH] memory: atmel-ebi: Annotate struct atmel_ebi_dev with __counted_by
@ 2023-09-22 17:52 Kees Cook
2023-09-23 16:35 ` Gustavo A. R. Silva
2023-09-24 12:09 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Kees Cook @ 2023-09-22 17:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alexandre Belloni, linux-kernel, Kees Cook, Tom Rix, llvm,
Nick Desaulniers, Claudiu Beznea, Nathan Chancellor,
linux-hardening, linux-arm-kernel
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct atmel_ebi_dev.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/memory/atmel-ebi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
index 635966d705cb..ec6100bc94c5 100644
--- a/drivers/memory/atmel-ebi.c
+++ b/drivers/memory/atmel-ebi.c
@@ -30,7 +30,7 @@ struct atmel_ebi_dev {
struct atmel_ebi *ebi;
u32 mode;
int numcs;
- struct atmel_ebi_dev_config configs[];
+ struct atmel_ebi_dev_config configs[] __counted_by(numcs);
};
struct atmel_ebi_caps {
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] memory: atmel-ebi: Annotate struct atmel_ebi_dev with __counted_by
2023-09-22 17:52 [PATCH] memory: atmel-ebi: Annotate struct atmel_ebi_dev with __counted_by Kees Cook
@ 2023-09-23 16:35 ` Gustavo A. R. Silva
2023-09-24 12:09 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2023-09-23 16:35 UTC (permalink / raw)
To: Kees Cook, Krzysztof Kozlowski
Cc: Alexandre Belloni, linux-kernel, Tom Rix, llvm, Nick Desaulniers,
Claudiu Beznea, Nathan Chancellor, linux-hardening,
linux-arm-kernel
On 9/22/23 11:52, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct atmel_ebi_dev.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> drivers/memory/atmel-ebi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index 635966d705cb..ec6100bc94c5 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -30,7 +30,7 @@ struct atmel_ebi_dev {
> struct atmel_ebi *ebi;
> u32 mode;
> int numcs;
> - struct atmel_ebi_dev_config configs[];
> + struct atmel_ebi_dev_config configs[] __counted_by(numcs);
> };
>
> struct atmel_ebi_caps {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] memory: atmel-ebi: Annotate struct atmel_ebi_dev with __counted_by
2023-09-22 17:52 [PATCH] memory: atmel-ebi: Annotate struct atmel_ebi_dev with __counted_by Kees Cook
2023-09-23 16:35 ` Gustavo A. R. Silva
@ 2023-09-24 12:09 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-24 12:09 UTC (permalink / raw)
To: Kees Cook
Cc: Alexandre Belloni, linux-kernel, Tom Rix, llvm, Nick Desaulniers,
Claudiu Beznea, Nathan Chancellor, Krzysztof Kozlowski,
linux-hardening, linux-arm-kernel
On Fri, 22 Sep 2023 10:52:15 -0700, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct atmel_ebi_dev.
>
> [...]
Applied, thanks!
[1/1] memory: atmel-ebi: Annotate struct atmel_ebi_dev with __counted_by
https://git.kernel.org/krzk/linux-mem-ctrl/c/c1f2c81631df7654c249a457b7a54bbc36042248
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-24 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-22 17:52 [PATCH] memory: atmel-ebi: Annotate struct atmel_ebi_dev with __counted_by Kees Cook
2023-09-23 16:35 ` Gustavo A. R. Silva
2023-09-24 12:09 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).