From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E6CFC433EF for ; Thu, 10 Feb 2022 12:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5XP0mevbetm0lQ2ojZc7SdRnnT5Wibx4zReP5MpERcc=; b=PZ6u9Z4ieP/blJ9DioVzocP+uP L1fckC3gQ4ggL+Rjk9JaZcSogM0wkMrdFlo9itYswKSmh2tuHkVYGjKrm6EtfclymnQ00aIqY+sGN IcZO9wbi3d06+63ShqRkrsZBx56v/qZSbgVpXjIVPY9lCqZXSRJ3I8O3cHj9OMqfhfNOH24vfgAd9 PAlCK7pQxq9FEzopTAU1TYd3tquQWjyQN5yyAzqbJNPDryF2Owr2NvNB+YBltkHNlMxlyMQGTkYDz ICb+tXO6LwpkG/IJRKM5BB6aCX+FHnFaAFz0x3zLSPFXnkoFQXnD/vpo1s5WEp64AvF4Sz1tRwmft p2iuiW3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI8Cd-003iIy-24; Thu, 10 Feb 2022 12:05:35 +0000 Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI8CW-003iH4-4g for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 12:05:30 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id EC8822223A; Thu, 10 Feb 2022 13:05:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1644494725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GokQuS+suI7AFN8u7SGXFvEJz7aki0KJ68Y/NTbDdeA=; b=f25C19yRv3k+t8BbJBx+qqCKdrKwAaHf4qgcgO0Hu2jfGZLbhPEekAgTYLfFmMUrJvcwfA GrcyU0c9LAXQT5KgI+GF/Ja8FypMyb2FL1psBkc6VPEhKWe7iCe+xXxg0rCFiey7HOd2F0 KQWd4Q7NPOZJi43WvbA7JimyUL18+W8= MIME-Version: 1.0 Date: Thu, 10 Feb 2022 13:05:24 +0100 From: Michael Walle To: Kavyasree.Kotagiri@microchip.com Subject: Re: [PATCH v4] ARM: dts: add DT for lan966 SoC and 2-port board pcb8291 In-Reply-To: References: <20220209111318.21112-1-kavyasree.kotagiri@microchip.com> <20220209184600.1230365-1-michael@walle.cc> <97bcfa4417d5f8c41cc6aa1e411c8747@walle.cc> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_040528_373001_5CD17CAD X-CRM114-Status: GOOD ( 20.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, arnd@arndb.de, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, soc@kernel.org, robh+dt@kernel.org, olof@lixom.net, Manohar.Puri@microchip.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 2022-02-10 12:52, schrieb Kavyasree.Kotagiri@microchip.com: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> the >> content is safe >> >> Am 2022-02-10 10:40, schrieb Kavyasree.Kotagiri@microchip.com: >> >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> >> the >> >> content is safe >> >> >> > + clocks { >> >> [..] >> >> > + >> >> > + nic_clk: nic_clk { >> >> >> >> What does nic_clk stand for? If I had to guess, it >> >> has something to do with network. But.. >> >> >> > NIC clock is the clock used by AXI, AHB fabric and APB bridges which >> > connects all the peripherals. >> > It is named so because the AXI fabric is based on NIC400 IP from ARM >> >> Ok, thanks for clarification. >> >> >> >> > + watchdog: watchdog@e0090000 { >> >> > + compatible = "snps,dw-wdt"; >> >> > + reg = <0xe0090000 0x1000>; >> >> > + interrupts = ; >> >> > + clocks = <&nic_clk>; >> >> >> >> Btw. can we disable all nodes by default and enable them >> >> in the board dts files? >> > I would like to have only board specific nodes enabled in dts files >> > and rest of them in dtsi file >> >> And how do you know which ones are board specific? E.g. I would like >> to add our board which is also based on the lan9668. Maybe I don't >> want a watchdog (or whatever node). Of course I could use >> >> &watchdog { >> status = "disabled"; >> }; >> >> But IMHO opt-in is better. At least thats what we are doing for >> the layerscape over on arm64. >> > Basically, I am disabling only the nodes which have pinctrl settings > in dtsi file > and enable in dts to make sure there are no conflicts on pins on the > board. Thats not what I'm asking. I would like to see *optional* nodes disabled by default. Whether the watchdog is optional might be debatable, but what about the usb controller and the qspi controller? They don't have shared pins AFAIK, so according to your rule, they will be enabled by default and each board which doesn't have anything connected on these pins would have to disabled it. Please keep in mind that this .dtsi will also be used by boards not manufactured by microchip. -michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel