From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9CC6CA0EFF for ; Fri, 30 Aug 2024 10:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FFvEi22aaFveU/v85aARXCtDR6noK8yhzMwhF2L+8zM=; b=o1vXFqIomLj5t94IogOeggDS0a TH20ADAFvBVOp0ceyZoSp4kg9JMHwM1GE83B0NISJrNuoPvJ8A+wp8mXikxz4NTYwAhjSGn+N8Jm7 dwIaGYCbgXlgTrCFLEX34M2MCvgoj32pQrUqveyi9oi5ESks7/BxkMna//KnlVFJd14u7JvTcsCgL WjgUoAeZLjxLG+a68JDM9x/rtxJjbe4rcustKenX8Y9RvYOaQiTuHnP6uiWNXJWAas0dA3tAtZb4E gGeiJT38hhUS0GmInFv2qP6OTl1fuDUVpb1WHvPLuSNgFYdG8iAm3d4yZViN/ldcUXB1pOaZajDLx ufYP1G5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjyRJ-00000005gBn-0uS7; Fri, 30 Aug 2024 10:01:09 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjxG2-00000005PcP-2Nv0 for linux-arm-kernel@bombadil.infradead.org; Fri, 30 Aug 2024 08:45:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=FFvEi22aaFveU/v85aARXCtDR6noK8yhzMwhF2L+8zM=; b=blRMLBp46Pk8aIl4wG/aLisniU a0U68qCwkoZlsqV3XA76yWKflwloct4/u7FYzlPc9n7QN6hWh5RiaY0DLW+wWKm6Lg3MHzcMtY1/F 7c5dyYblCHT2JmffiM9SA3HBaX4DDOxYpEp3gEB5MrhWSgZ0CJl/601eUrtwTjs7aeJ2tTsPk9rmf Ml8bhnphSOK0ryeTQPjBCFvzi5KEex3QRheSkPK7jGZwFoGeTzmJN2uDCAqAD92Hi/CouI+lfWJ83 gqkDpqNzRrq0/NzLKof1tJkUt1F2ylBTYomGwzfl/qjFM/Ya3M0p5Hvj7xx+GHe+ucKcNvV4zQDKE u62EJBcA==; Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjxFt-0000000Bbn9-3CdH for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 08:45:25 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-428e0d18666so13047815e9.3 for ; Fri, 30 Aug 2024 01:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725007514; x=1725612314; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=FFvEi22aaFveU/v85aARXCtDR6noK8yhzMwhF2L+8zM=; b=hsQ6Wy73uuZGCDiwtrRXv+TXPtYgw9ZbQbvJ/TdLkaETfJ1WxEOjsRNwHr47T7/TsF Zxdq8yk3aEWSxdiIZZq7lAKdgSWRkXx85zgIVT3yKJ5/cBA/1aFPeeFFy8zNKgMsfD9d dzAHPj0LtkSMsMPKwUobb3Jrpk4qziEgNuQ7xxB68ESJPuxejCqKSW/T7AGhRuLHtxgg J5RIgZXRkmFnjHKScqNVmEgP5Qwsf61ANE8gd1TCXak4cz+xupqxgd2Ju43+g6khq1oD sAffTwRnLFW2hV6jiHI8JFNB7MJP1pUELp1qbj9H06uJWSuejiBuyzdQr96jMhHRMFaL ibbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725007514; x=1725612314; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FFvEi22aaFveU/v85aARXCtDR6noK8yhzMwhF2L+8zM=; b=nnV7mPuTSdWoZyrjN8BndZYMhfGkwtOxSVYleg8Shan3q1ad3oDzoLObaIHi2tJS8d GX19ukhc4iWUhONZCljL06hMsIuvLrs83KUiav+0RzqFaxFCXtSwhsgRdgTeh+S/PwjG 5iDfqXPDG3/AH9nMNpOJSFzwTIwlYopDA2qX8BUnXXsvhIqhurEZGYMjVGeQWthFFArH W45YTFoYmBqzGzdefmHt9rgXZ9iN94Hk46M6WOTLN1BwmPBD0rhFsdPN4cwqu0stFoI8 zFQq4DOaIyP73HfKXSBqGEAO5C2UNNeoxWG9M/2w2cr1f7if28KtgDX0pHVhjCltR7Ih 0h0w== X-Forwarded-Encrypted: i=1; AJvYcCWfLm2tX3I7YW19IHDoci8Dm3m57Jgvy3Efsg1q3eGYeXbcHXSJXvP9ujbU8Q3TT/q2zuKJdU+4eoRei9yIa03V@lists.infradead.org X-Gm-Message-State: AOJu0Yxy6sH9PV9t+NEF6W2dOSlS41dKeLKO0CFuav/Y0ti3hx4zqS5N q3furffV9S7+YyA/GiRts6AG1CS0aRNmI0jK+IXu7RoLTuQv+lInW3YdhHHUZSc= X-Google-Smtp-Source: AGHT+IHnzDSOe8kd9fvuLoVFjLC1R5c/WM+ttCvQdw8+ztum16kSwXDjQlWZTWhokM7kdzCwcNZT1g== X-Received: by 2002:a05:600c:46c9:b0:42b:8a35:1acf with SMTP id 5b1f17b1804b1-42bbb436e9amr10518395e9.25.1725007513329; Fri, 30 Aug 2024 01:45:13 -0700 (PDT) Received: from [192.168.1.3] ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ba639d512sm71843875e9.18.2024.08.30.01.45.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Aug 2024 01:45:12 -0700 (PDT) Message-ID: Date: Fri, 30 Aug 2024 09:45:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 7/7] perf test: Add a test for default perf stat command From: James Clark To: Namhyung Kim Cc: irogers@google.com, linux-perf-users@vger.kernel.org, kan.liang@linux.intel.com, ak@linux.intel.com, John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Weilin Wang , Dominique Martinet , Athira Rajeev , Colin Ian King , Yang Jihong , Ze Gao , Sun Haiyong , Jing Zhang , Yicong Yang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240828140736.156703-1-james.clark@linaro.org> <20240828140736.156703-8-james.clark@linaro.org> <52de8df9-4554-4bc0-9735-fdbd197dbb7c@linaro.org> Content-Language: en-US In-Reply-To: <52de8df9-4554-4bc0-9735-fdbd197dbb7c@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_094519_557008_D1757414 X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/08/2024 9:29 am, James Clark wrote: > > > On 30/08/2024 7:32 am, Namhyung Kim wrote: >> Hello, >> >> On Wed, Aug 28, 2024 at 03:07:21PM +0100, James Clark wrote: >>> Test that one cycles event is opened for each core PMU when "perf stat" >>> is run without arguments. >>> >>> The event line can either be output as "pmu/cycles/" or just "cycles" if >>> there is only one PMU. Include 2 spaces for padding in the one PMU case >>> to avoid matching when the word cycles is included in metric >>> descriptions. >>> >>> Signed-off-by: James Clark >>> --- >>>   tools/perf/tests/shell/stat.sh | 21 +++++++++++++++++++++ >>>   1 file changed, 21 insertions(+) >>> >>> diff --git a/tools/perf/tests/shell/stat.sh >>> b/tools/perf/tests/shell/stat.sh >>> index 525d0c44fdc6..24ace1de71cc 100755 >>> --- a/tools/perf/tests/shell/stat.sh >>> +++ b/tools/perf/tests/shell/stat.sh >>> @@ -148,6 +148,26 @@ test_cputype() { >>>     echo "cputype test [Success]" >>>   } >>> +test_hybrid() { >>> +  # Test the default stat command on hybrid devices opens one cycles >>> event for >>> +  # each CPU type. >>> +  echo "hybrid test" >>> + >>> +  # Count the number of core PMUs >>> +  pmus=$(ls /sys/bus/event_source/devices/*/cpus 2>/dev/null | wc -l) >> >> Is it working on non-hybrid systems?  I don't think they have cpus file >> in the core PMU. >> >> Thanks, >> Namhyung >> > > Good point I only tested on Arm non-hybrid. I can change it to assume 1 > PMU for no cpus files? Or maybe assume 1 if a /sys/bus/event_source/devices/cpu folder exists? Not sure which is best but either will work.