From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CAAFC83F15 for ; Wed, 30 Aug 2023 09:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7ISKT++ELNEhJf/SyaNvrTjyvwrUkYQPrc/92EiLZf8=; b=0IFxh9/0pLOU9d xQFIIDr6znXhZnAzoVkCO+95pIj8Pv7u6MGfMgwBFYVMySIFshNok7erpiackB00V7bSHmqenU4fO FF5B+cyvWYd3Z8WlShf4E2/TZ5rE5pDbRrJ3vSePdXQ9DKtOsuJW9A6i6dfqUxlln2QyV2x79Rpz4 zVOW4CF8VYMeJLohIkyT4Bji1KcGIPJ9KNW8TGUdZWlcwWX3MTFMNasgKLz70WRX7IY87+DI0V3cM eaRZl9sUcLb9f/HgFMMDgCdV63T6Pj2dCxESTTL5ua5WycCDkAFLt+iUa1vuaQV0i12QmZZ4ezpoz JTJvT3FbEzxNByuyvw3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbHl5-00DAPV-28; Wed, 30 Aug 2023 09:45:07 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbHl2-00DANx-0y for linux-arm-kernel@lists.infradead.org; Wed, 30 Aug 2023 09:45:05 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-986d8332f50so696926066b.0 for ; Wed, 30 Aug 2023 02:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693388700; x=1693993500; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GinLhIkYK1eux6i+cjheW/SanM1hfGzP7zFFV4Pq7CI=; b=D0IIGybaRbcrFKQzNviJAYJJfwEOa3269U+iTRRmf2c0NarNTijbJJhaOfVzd1LvLJ avBxY28p5yeB+qwR2zXCXBfiQDU64668kDany2SEjEGubol7ptxSbyRyR+JGNBiAvEJK 7lefl6tRwhstsQYQ6FF1AyblI2f+3QSXg1xRAIipDna7+XgjRjrI2M9Qr9u2Ip3c2c+J QxqxEm/08+VFgRuUwe3Q4+rEoXd6jIIMgVykBvSxmfWjqSMfbzQvYnAZTz3QRjB72xuC MhfDVuf29dve644JKzE0vArby5yiCbV5jpDC5SvGN+VI18G3SlJbBb+pjlU/gwhC5SNT F1FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693388700; x=1693993500; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GinLhIkYK1eux6i+cjheW/SanM1hfGzP7zFFV4Pq7CI=; b=Zew41ptEHu4PJuvlk79fPsLc4qeZyTtH1QHMT+8ITPFvrnQssqzU/bebRjTD4gRkqv DXH4zzJ3DZBsiEzqJdBFkgIHjTiL6WwMiOHbTvx7pPWnxNkLdLA8eDq8g51lQkep92vI siILyCdwbpFRuGzpSIg+WA037NGMo3e6loNgFaSy0DIkkWTWHIH3XRIcHgrGBnNrtGqH QPhhnBJCXEly06tnJweSa/ur5VP3q0EiHO5d1cj5KgpSHcsMLpHS4iIc15gs9wNwi9Lx CCrlEU2N3KQ9S7W2AlDJqBqFS/aApiFBImlVGv01bkegTO4c++AldKVtXjUEkBEcFljx /ZqA== X-Gm-Message-State: AOJu0Yzvt27oXbfyP6jvhSoMR0ykUfU6gwUQSRn516eJEUqTSrgOYDCY ojbfHDIxXWPBlNo2yCnGfN3o4Q== X-Google-Smtp-Source: AGHT+IErP0xuXzSAW/p+xjsBaBQUM/72RL+nvycu+pslby5SCw0FQTJk9JH2ZdMQgx3+rxaEkK5Myw== X-Received: by 2002:a17:906:3152:b0:9a5:874a:9745 with SMTP id e18-20020a170906315200b009a5874a9745mr1129087eje.26.1693388700643; Wed, 30 Aug 2023 02:45:00 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id a8-20020a1709066d4800b0098e422d6758sm6930455ejt.219.2023.08.30.02.44.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Aug 2023 02:44:59 -0700 (PDT) Message-ID: Date: Wed, 30 Aug 2023 11:44:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC Content-Language: en-US To: peteryin , patrick@stwcx.xyz, Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Arnd Bergmann , Olof Johansson , soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: cosmo.chou@quantatw.com, potin.lai@quantatw.com, daniel-hsu@quantatw.com References: <20230830090212.3880559-1-peteryin.openbmc@gmail.com> <20230830090212.3880559-2-peteryin.openbmc@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230830090212.3880559-2-peteryin.openbmc@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230830_024504_363689_233D6AD5 X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/08/2023 11:02, peteryin wrote: > Add linux device tree entry related to > Minerva specific devices connected to BMC SoC. > > Signed-off-by: peteryin To clarify: your full name or known identity is "peteryin"? > --- > arch/arm/boot/dts/Makefile | 1 + > .../boot/dts/aspeed-bmc-facebook-minerva.dts | 385 ++++++++++++++++++ > 2 files changed, 386 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 9e1d7bf3cff6..edb0b2105333 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-facebook-wedge400.dtb \ > aspeed-bmc-facebook-yamp.dtb \ > aspeed-bmc-facebook-yosemitev2.dtb \ > + aspeed-bmc-facebook-minerva.dtb \ Nothing improved here. > aspeed-bmc-ibm-bonnell.dtb \ > aspeed-bmc-ibm-everest.dtb \ > aspeed-bmc-ibm-rainier.dtb \ > + "","","","","","","","", > + /*O0-O3 line 224-231*/ > + "","","","","","","","", > + /*O4-O7 line 232-239*/ > + "","","","","","","","", > + /*P0-P3 line 240-247*/ > + "","","","","","","","", > + /*P4-P7 line 248-255*/ > + "","","","","","","",""; > +}; > + Nor here. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel