From: Christian Lamparter <chunkeey@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
linux-arm-kernel@lists.infradead.org
Cc: mnhagan88@gmail.com, "Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"maintainer:BROADCOM BCM5301X ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Jon Mason" <jonmason@broadcom.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: BCM5301X: Fix I2C controller interrupt
Date: Wed, 27 Oct 2021 22:32:42 +0200 [thread overview]
Message-ID: <b9e56efc-c060-df62-8aec-ad93b0b08764@gmail.com> (raw)
In-Reply-To: <20211027193730.3941945-1-f.fainelli@gmail.com>
On 27/10/2021 21:37, Florian Fainelli wrote:
> The I2C interrupt controller line is off by 32 because the datasheet
> describes interrupt inputs into the GIC which are for Shared Peripheral
> Interrupts and are starting at offset 32. The ARM GIC binding expects
> the SPI interrupts to be numbered from 0 relative to the SPI base.
>
> Fixes: bb097e3e0045 ("ARM: dts: BCM5301X: Add I2C support to the DT")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Thank you! This fixed the MR32 iproc-i2c issue.
It's working now (will post the patch for the MR32 tomorrow):
# cat /proc/interrupts
CPU0 CPU1
24: 1 0 GIC-0 27 Edge gt
25: 110418 108252 GIC-0 29 Edge twd
26: 476 0 GIC-0 117 Level gpio, ttyS0
31: 128 0 GIC-0 121 Level 18009000.i2c <--- YES!
32: 49477 0 GIC-0 100 Level brcmnand
33: 0 0 GIC-0 109 Level mspi_done
34: 0 0 GIC-0 110 Level mspi_halted
35: 0 0 GIC-0 104 Level spi_lr_fullness_reached
36: 0 0 GIC-0 105 Level spi_lr_session_aborted
37: 0 0 GIC-0 106 Level spi_lr_impatient
38: 0 0 GIC-0 107 Level spi_lr_session_done
40: 7227 0 GIC-0 179 Level eth2
51: 0 0 BCMA-GPIO 21 Edge keys
and the attached AT24 + PoE-Power monitor can be probed + read as before.
[ 12.042576] at24 0-0050: 8192 byte 24c64 EEPROM, read-only
...
[ 12.077671] ina2xx 0-0045: power monitor ina219 (Rshunt = 60000 uOhm)
Tested-by: Christian Lamparter <chunkeey@gmail.com>
Regards
Christian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-27 20:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 19:37 [PATCH] ARM: dts: BCM5301X: Fix I2C controller interrupt Florian Fainelli
2021-10-27 20:28 ` Rafał Miłecki
2021-10-27 20:32 ` Christian Lamparter [this message]
2021-11-15 17:31 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9e56efc-c060-df62-8aec-ad93b0b08764@gmail.com \
--to=chunkeey@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnhagan88@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).