From: Dmitry Osipenko <digetx@gmail.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: linux-kernel@vger.kernel.org,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Robert Yang" <decatf@gmail.com>,
linux-tegra@vger.kernel.org,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/7] ARM: trusted_foundations: Support L2 cache maintenance
Date: Thu, 28 Feb 2019 16:36:49 +0300 [thread overview]
Message-ID: <ba215d63-ffaa-5be6-c43f-fdb845b1d6b7@gmail.com> (raw)
In-Reply-To: <20190228132748.s2woduoycm7igfub@shell.armlinux.org.uk>
28.02.2019 16:27, Russell King - ARM Linux admin пишет:
> On Thu, Feb 28, 2019 at 04:17:01PM +0300, Dmitry Osipenko wrote:
>> +#ifdef CONFIG_CACHE_L2X0
>> +static void tf_cache_write_sec(unsigned long val, unsigned int reg)
>> +{
>> + u32 l2x0_way_mask = 0xff;
>> +
>> + switch (reg) {
>> + case L2X0_CTRL:
>> + if (l2x0_saved_regs.aux_ctrl & BIT(16))
>
> And bit 16 is what? We have definitions in one of the headers you've
> added above, please use them. Thanks.
>
Good catch, I missed that there is a definition for that bit. I'll make a v8 soon'ish, please let me know if there is anything else to be addressed. Yours r-b and a-b will be appreciated.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-28 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 13:17 [PATCH v7 0/7] Support Trusted Foundations firmware on Tegra30 Dmitry Osipenko
2019-02-28 13:17 ` [PATCH v7 1/7] ARM: trusted_foundations: Support L2 cache maintenance Dmitry Osipenko
2019-02-28 13:27 ` Russell King - ARM Linux admin
2019-02-28 13:36 ` Dmitry Osipenko [this message]
2019-02-28 13:17 ` [PATCH v7 2/7] ARM: trusted_foundations: Make prepare_idle call to take mode argument Dmitry Osipenko
2019-02-28 13:17 ` [PATCH v7 3/7] ARM: trusted_foundations: Provide information about whether firmware is registered Dmitry Osipenko
2019-02-28 13:17 ` [PATCH v7 4/7] ARM: tegra: Set up L2 cache using Trusted Foundations firmware Dmitry Osipenko
2019-02-28 13:17 ` [PATCH v7 5/7] ARM: tegra: Don't apply CPU erratas in insecure mode Dmitry Osipenko
2019-02-28 13:17 ` [PATCH v7 6/7] ARM: tegra: Always boot CPU in ARM-mode Dmitry Osipenko
2019-02-28 13:17 ` [PATCH v7 7/7] ARM: tegra: Add firmware calls required for suspend-resume on Tegra30 Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba215d63-ffaa-5be6-c43f-fdb845b1d6b7@gmail.com \
--to=digetx@gmail.com \
--cc=decatf@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mirq-linux@rere.qmqm.pl \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).