From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB50AC67861 for ; Mon, 8 Apr 2024 05:58:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OYX58xnqGVSXzBTfjdIz8sQft5llnQ9ajExUR89DXRo=; b=3SsFvDCMPzzALe 9eyjeypgKgs6K/eKV/0l85OieiZ6wOC6V6bFBH9OSKOug5oqvSE06HCGsKBrkCApcdur+dqB3U9Hu 7JDIrgk3Qk3ro3V/wmyPwWZ35NqsULEZumSEPZQhjpc9JzhISPtH+gup+9B1Vp6IWjz5jHgXLZXRE GNXzxtoxQSaiZjjxz2/OIQG1s5dm7ffFEaQdbL/vDRLKw4LlnSPV5N33B6wZMSW5yfNnfeRrhk+gg xcghWSYASbSoCDslYtyAyM76i1+lE3oGJxbeWKsnZlVIdzJ2Ewax7TP5TEP40y4u94scBBdkDf/Xd fYBRuUbmsIjQrJ+hY4QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rti0s-0000000ERrD-2psA; Mon, 08 Apr 2024 05:57:50 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rti0n-0000000ERqF-1Fwe for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2024 05:57:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 720E060DEA; Mon, 8 Apr 2024 05:57:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DE34C433F1; Mon, 8 Apr 2024 05:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712555862; bh=mBGucGHxPEYjNGFj9o1D+BgtglcfHZFWJhMetpAilZg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sDmHFt5bWapR5TTFh/Ikxt8jRpMRejQ6zXt1Sm9GJOMtT1UPvftyO1fQMwS/nI0Nv 3lCcjqfnMn07nsWcrjJpYGmJPML4SwLj+E8KqONvckc+WbNinUc+Wk5YS0QdLI3rFQ IHPacDQ1xU7fJBbO1XQZHDYM48zD+LPjUiU2jFaSSZQ4Tu1Qg4rkuOJ41OqGHrM16f yOWXS9cP7qps4qRBOaAPdduyQYmWecRtGL2L6ijy9e4u4sWQxCz7u8L8sl4vf3HFwY WSvm5OLD0VrvtuK5GhkDZkHKC8BnzqA90J2bhdTnpC8nNANbs4iS1xj2hZnIGkt+Tq 0PgiUqgPe424A== Message-ID: Date: Mon, 8 Apr 2024 07:57:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dt-bindings: firmware: arm,scmi: set additionalProperties to true To: Peng Fan , "Peng Fan (OSS)" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sudeep Holla , Cristian Marussi Cc: "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20240405-imx95-bbm-misc-v2-v2-0-9fc9186856c2@nxp.com> <20240405-imx95-bbm-misc-v2-v2-1-9fc9186856c2@nxp.com> <614b5107-656d-4d41-99c1-77941c48342c@kernel.org> <09f6b752-6b72-49d7-b248-6faba2fd13a7@kernel.org> <5b9e0e44-0b9c-44fc-9d18-21c47b46dc63@kernel.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240407_225746_280070_0EE166B6 X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/04/2024 01:50, Peng Fan wrote: >> Subject: Re: [PATCH v2 1/6] dt-bindings: firmware: arm,scmi: set >> additionalProperties to true >> >> On 07/04/2024 12:04, Peng Fan wrote: >>>> Subject: Re: [PATCH v2 1/6] dt-bindings: firmware: arm,scmi: set >>>> additionalProperties to true >>>> >>>> On 07/04/2024 02:37, Peng Fan wrote: >>>>>> Subject: Re: [PATCH v2 1/6] dt-bindings: firmware: arm,scmi: set >>>>>> additionalProperties to true >>>>>> >>>>>> On 05/04/2024 14:39, Peng Fan (OSS) wrote: >>>>>>> From: Peng Fan >>>>>>> >>>>>>> When adding vendor extension protocols, there is dt-schema warning: >>>>>>> " >>>>>>> imx,scmi.example.dtb: scmi: 'protocol@81', 'protocol@84' do not >>>>>>> match any of the regexes: 'pinctrl-[0-9]+' >>>>>>> " >>>>>>> >>>>>>> Set additionalProperties to true to address the issue. >>>>>> >>>>>> I do not see anything addressed here, except making the binding >>>>>> accepting anything anywhere... >>>>> >>>>> I not wanna add vendor protocols in arm,scmi.yaml, so will introduce >>>>> a new yaml imx.scmi.yaml which add i.MX SCMI protocol extension. >>>>> >>>>> With additionalProperties set to false, I not know how, please suggest. >>>> >>>> First of all, you cannot affect negatively existing devices (their >>>> bindings) and your patch does exactly that. This should make you >>>> thing what is the correct approach... >>>> >>>> Rob gave you the comment about missing compatible - you still did not >>>> address that. >>> >>> I added the compatible in patch 2/6 in the examples "compatible = >> "arm,scmi";" >> >> So you claim that your vendor extensions are the same or fully compatible >> with arm,scmi and you add nothing... Are your extensions/protocol valid for >> arm,scmi? > > Yes. They are valid for arm,scmi. > > If yes, why is this in separate binding. If no, why you use someone >> else's compatible? > > Per SCMI Spec > 0x80-0xFF: Reserved for vendor or platform-specific extensions to > this interface > > i.MX use 0x81 for BBM, 0x84 for MISC. But other vendors will use > the id for their own protocol. So how are they valid for arm,scmi? I don't understand. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel