From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95400C54E4A for ; Fri, 8 Mar 2024 08:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/NTDg6IbX5EGmGu0XxMjRKt7UQ25IvfB1XrGwEnw0JE=; b=GoLzwjMziOIczD M/kYVXknj/VW3A0HMpqALnqUiSIjmhNHYKdg+7zSJEwSOke8OaXcUvUuwNnFrsLGtFkVoqSUfcWel uJUFmitRU81ygPMr0xb8cz0nwz4jgPKJMvBCwqXc08LndWB/6VAo8f3o3bcfaUv2zMcxo9xSMryFV nCLI2YJ+Ctr5hJyqZXCFLyljxLBfUD2+xzPOIrWGBz5PuZ/7Mdh+0I6RydePa+2imT8pVlA9QdomI weqaLDNjcLE7L4Mu6R+vIfCmGtvUrFsk/pz6zbGsnn74U2tTG3Qlw6rAXZ6rrQOuJC5TgwJZuB4TO yMjicd6gRmmjsNpuTfgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riVwm-00000008QGm-39iY; Fri, 08 Mar 2024 08:51:20 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riVwj-00000008QFs-2gzJ for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 08:51:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1709887877; x=1741423877; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Q0vxSJidsLU7QrKv8KswXHeLBnH68SHh0mNavKDOBKo=; b=WwEgni+T8jtAfdpncSWOeKE668rcuSRGprYza+bClxl1LLjkSoNIeZgY hMQU2XTfVEby5nTfO+w0LSjo/86edgYfu04tK2GeTEJCIbQ0fhTd6xmML 6doOBkMIAdaUOxqgeK2DAwYOkT6rHAbn/m2W48ZQ7SE8PNquXO3c9jfux VLzg71TmgcZWCE00LS1mrao9DJqou+E6k3qGYtcDgGXZPaeAoj8WVipdZ 7tMK5HWr+VHhEtKmpimfIk/XhZ0aM8Zdw60JrHPSe+NXrpm+vrhBbKicI i//jRuwXiRAAAKEtbc6zVXphXMXVZF+L8MtQNI6XEAf06pvMir+l99qHO g==; X-CSE-ConnectionGUID: 6Y7IRf7nT2yhgiGn/H1Wlg== X-CSE-MsgGUID: vCzIFCcLSN2ET6Ad+uR4dw== X-IronPort-AV: E=Sophos;i="6.07,109,1708412400"; d="scan'208";a="248159251" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Mar 2024 01:51:16 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 8 Mar 2024 01:50:45 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (10.10.215.250) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 8 Mar 2024 01:50:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dx52qGHFj0p0qO0/db+iSkED5RH7r+Vh4HItH2dCIEZkrj5sXjJUv+0qgcknWeow4Beo9rynfh0CkaAEZy3yR4Ob0+AmJbYXo2osZtPbAfKpsEkxs5d0gaadEaQq4M5OCPJumKtyuDtMyPTfvaxLb+oI//+KFOpQM9j6QPFZnjClKiViX2E/hn53DE3s8Qt74x9YLwr3rfMKlO+Ck3UBiOLtD6FTD0s5Numi2sQVpq4GAFACY2xeOIIkGItndurHRtbutWLfgye89714XT3VU8284Wpd5wqgPItUJL2+Nzf5ACFlz2fSK0tEwCVAqr8tjNwl9OX+wwvcSJCOX5bkqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q0vxSJidsLU7QrKv8KswXHeLBnH68SHh0mNavKDOBKo=; b=k9O77LMXkBdz5K5g7H9u/zZiJKptmL9e7Xr5+yoDeBXfctlwwQa3X17xZZ3FBn9UoVDWELoUwuLU5civHbpG9+SR5QwaLiApBi/scSfW8lJXIByYnS4QSOdgnMQGymPwf9hbaeXlNpj1FZsRB1Sis9ltEskruMhkgMK/Nc3Dvw8SYRyOcwRYnOXj9yndVFe2jx9eXZXMqKutZldn6XCXXJFt4b1euTD/It3M3iSr0p0z0YBmVWQYmeWhzsWoW5uDIg5QlfXe6UlzId/xItyrt17wMeM5HG75CD46JaSuefbqARKZ4DGKh3B7ZESa9nSJ8qteYi8b65YO8WYGvnhikQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchip.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q0vxSJidsLU7QrKv8KswXHeLBnH68SHh0mNavKDOBKo=; b=NQYyj71IdadWNVLxZzH8gc6lJNoBrMpXZ5bz4c4M4gen7z8I1WhysA0fXhRhU3e2Vj++6hOqvI3gzHB22oDNdCB5OnYLtDROxeDGijSVbZwY5nTA/CXifYyjJnO8LOAaos4/CU6YPqzG+6tKesAU+DWKCSaxkhEkZ87rh1GBQKsdNbMCyKlU2yd3HJUgo5w6euT2txkhy5Hq5N0ZIyDZDQGdbBECf9Z9Wd3aYziGIu9BO9bxf7qyKrtK3I9pbpVtUslDRqqeYYJSdQ7XEG56+XI88C7fEgY6W8Qa7h3QMoaBwz+zXdDFAU0nKTbHJWO4SgxQ0RNjkIGKOdt82qkMVQ== Received: from SA0PR11MB4719.namprd11.prod.outlook.com (2603:10b6:806:95::17) by LV8PR11MB8557.namprd11.prod.outlook.com (2603:10b6:408:1e8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.16; Fri, 8 Mar 2024 08:50:43 +0000 Received: from SA0PR11MB4719.namprd11.prod.outlook.com ([fe80::f65f:f05e:4faf:4433]) by SA0PR11MB4719.namprd11.prod.outlook.com ([fe80::f65f:f05e:4faf:4433%4]) with mapi id 15.20.7386.009; Fri, 8 Mar 2024 08:50:43 +0000 From: To: , , , , , , , , , , , , , Subject: Re: [PATCH v4 29/39] irqchip/atmel-aic5: Add support to get nirqs from DT for sam9x60 & sam9x7 Thread-Topic: [PATCH v4 29/39] irqchip/atmel-aic5: Add support to get nirqs from DT for sam9x60 & sam9x7 Thread-Index: AQHaZn3lLFE5+OUN/UmzjmxjtudQILEl/b+AgAegrYA= Date: Fri, 8 Mar 2024 08:50:43 +0000 Message-ID: References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223172905.673053-1-varshini.rajendran@microchip.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA0PR11MB4719:EE_|LV8PR11MB8557:EE_ x-ms-office365-filtering-correlation-id: 4bf9f764-ae14-48fb-377d-08dc3f4cd705 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VBLxCS4mxOWzUiqDIcuyT3RQz3wJaE0p4+H8diGSdukjC+VbRtrL1X/P+1Z/07L64L8J+pUnzFfw/MrCml5xHgrm1Huf9G5gFL5X40pZp0ZDiNt6GqtlmdKPHP3wxCQkrl2ozjL8jAjpPxX5FmYGzArV39z20GC6hYbyx9MiLoAc4K0+e84uowhxWe0r65hizsrZhDj4WjTZhm9apRa1uOWzrCQbeiZ+UjhM2v82iDMipLGK99FSRAPNknJFiefJKO/Y7TKYcW5TwgNvMNuam7Sa1tajL0bNyeND/zWKSpBBFS6sivb2DAJ49x9toD4OnWx69dVgIPoAeXW+ERt/1n/bIhTzTOU/TQ2AegNlHksdlP/NL4A5FXX+rla3EfaqTx4XotNEgnYCkiJhlWqm2HKNtkZvLU58f1HHVH+SP8OyUFHAZNZejKFnFBiN67MgWoxMhOBdUVYBupOeQ5DNLda2C6xZMlsioTHBcAaaadYzWw4GK09cCUMjnpBQ2lmYoN6oMhFQ92rIGpeOPlJDQ22TdG9GXEi4Y2AivkSE4+cTDsRexIl+eHfGR5U8gNRRq6ac4Ga8puCk/pVBQLoAX/rQZs0fumRBWEqHoquy4oJnwTYmp85A0rxLsPX8ozQvLuZxhfM+d+6KQFiQCMqJhV+vemz9A59M43wOkUMtDeLrE+WrGBqfCWJzsncWdOvr+disNgu/jVPh8VTifufUj+X8ZMx8Zx8awc9sx0Wud0k= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR11MB4719.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(7416005)(38070700009)(921011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RkZxRUl5SXVwL3dJa1pockFMN2MwcmJzVFZTYkp0KzJ3MjIwRi9ZbDY3WUtj?= =?utf-8?B?VmRDalpWeVlBNzFmNXcvWnFnSnlUYlFEd2lRa0hzR01zU3ZMdkw5a24xZTBJ?= =?utf-8?B?V2ZBSlZhVUtZL0dQYXR3ekZOcEN2dnNEUmdSMm1TZ29uRUxtWnh0TlB3UjNz?= =?utf-8?B?dWdZSzlWaXNGMjVndElWZWQ1MW9GVkhVaGpkbUxJbmVRWUwvcCtZSFVkQWZD?= =?utf-8?B?S29CNE1zRm1yNGVDdVlld0IrTkx3RlVKbWt0bkdMTWFwbis2Vk5LS1hNZUJo?= =?utf-8?B?a3FyTTBiUEpFeFoxblEydjZlRnEyaHkwdjJxVkdMakJINHVLUzN1UVNoYjhQ?= =?utf-8?B?clpaSWFBVGFJUkorQjZSSjdBOHhvUmlZSk9CMWNVVmRmSzR5N2NnelJxVVRV?= =?utf-8?B?K3MzQnp5bjJCRkxFamVyWEZraGJFaDlzY0RRWVVHU05uV3FKSGVFZUdyc3pJ?= =?utf-8?B?MFZHajFDYm4yTXVuYnFaUjhmL0s1NmQwSHlyeVp2bHU5SkhnSEVtN3dZU2N2?= =?utf-8?B?NHVxQWx3Y2ZPRUk0UXRNQ2dKUDQ3WXVYZmw0UW1aMHVpc2x0bnE5VVU1aHo2?= =?utf-8?B?UDFRNENENjNOVnVNTzhGenFQem41WUhDZUFMV1BnRFprcElldTQvMVFvRmtB?= =?utf-8?B?N0oxODF2cGVMUFpsbnh6L0o1bXp0NEI2czBQWEVmeElEZ0NZelphb1phblUz?= =?utf-8?B?MkVzYUF6N3BEakNkSmVzYVYxVUpyZ2h3ZmhJajV3aWplNUNCZ3Ryc2ZmQ0dG?= =?utf-8?B?b1hjdnEvOGxuUlE3VVJtQ0ZHeVI2MVo1UFQ3Vi9Ic05ZanduZ0Zqa3pTMTMx?= =?utf-8?B?enVPWi9rNnRSTFk1NEFPRlZWSWg5YmpwbDlaZno4d2NQMDBYYS8yTEQ0V2JO?= =?utf-8?B?VjhOc0R3bi9UNnlteHI3Z2N0V1owWjZzb1F3WlVsTGNBVDZ3NWFYUGc5WXN6?= =?utf-8?B?UjNZZVdGb2VEOTJVOWxkOTlmNmtHWjF5RjNwMUkvWnZXN0pOZGNuTDluNFAv?= =?utf-8?B?Z0NMUFZJYjlVc2hWbFZJSHprTDhsQzM1a0wzeTRqV1VJMHB3R2gvTWRmT0o0?= =?utf-8?B?bjRZVXdmTW1mMzRaVWlJVG4zNzdGRG8xQjFNOXpZckduTnBqU2lZMXk4ZmZL?= =?utf-8?B?dEZkcjJOZlBxNmhKZ3c2QnR5enZhY0lTdUJ4OG1wdmFPSUVLZ1k2Um1TSWs2?= =?utf-8?B?RG0vZVo5Sm82WElhZ0lGaXlQSHEwUUtldzUwMjhPMElxV3lYdExXTTNiaDJU?= =?utf-8?B?Ym1DVmUreEFXbWRXajBob1FwY3IwMlVPU2F1cnh2aGF2STZ5M3I1RmNSeC96?= =?utf-8?B?a1hUcnBjd1gxZFNXdmF3dCtMdVljZUhjZjNNOWlGREJHWmliYnBQclE2UURV?= =?utf-8?B?ZDBXdEx4ZnBHVWUyZEVVL2VleENXWEFtRDhML2pZTzI0SmFEZ2JlVldRYkli?= =?utf-8?B?QzRFd1Z2MFQ4ckwwbmNaZW5NSVFXS0wxY3hCZ2RUbElHRnBVRUtRNTVkSUVt?= =?utf-8?B?eGgzNmZtaVYrUXhERjZWVm1Dd2VVclo4VzFYVE1BK2pybzM2MFFNbGYxMEFv?= =?utf-8?B?WXh3ZjkxMzN4MnNNcVJTUi9kZVppNEl1MXFZNm1FMGNOeW9CYkFEOHBhejB2?= =?utf-8?B?aXRQbWtCSWIzZ2dXMys4UktySlpDdlhLQ2JSR3Z6aUlvc2VyUGhLWFc1L2Nm?= =?utf-8?B?aEJXRXpsTnR5SXYrRUxHOXp2amhZQnNaSE43L0FQRlkvZE5RYldVM0hmYllt?= =?utf-8?B?bStIeSsySGNQRlVXVWkzMC9ucGE4M01tQXdaWUlyRmZHOXVHUmMrUHJxcVU5?= =?utf-8?B?eExQa0xCdEdFSFJPZG9pN0ZnTFRsOWZScFg0dnNBME5yR1hvRHhFbjhJWjFo?= =?utf-8?B?cmxqQUtyY3RxNUdvcXlRZ3FJSndRZ0NtTVR5WG5jWFpFYURzbFk4NFdYL0ZE?= =?utf-8?B?OWhqd0g1RmJ1b003UXVQYTZhT09FZ003WlVDRmRHaU9VZFpyNTFqQk11NCtu?= =?utf-8?B?YzEwdlFVcGhJNnNLM09DZTMzdDVUL2ZTVmJRZE4yUEpQajRUdzgydVlJS2R3?= =?utf-8?B?VUdONG9qVWU4UnFibi9NWlloczVwMFFLclU5WUNIZkZHYlJ6TmcrN051cWow?= =?utf-8?B?NHhWY2NVVjFNREZpek5IbmJOTHVGOE1MalVHTjdma3dFSXZpVisydEUrYUFO?= =?utf-8?B?Vnc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4719.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bf9f764-ae14-48fb-377d-08dc3f4cd705 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2024 08:50:43.6673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AR/2XRpVOcXl2URnPWQGukJbXfcm+ZjCxnYXWO1HC7ULM5aqwRkwfMMvbY7ma2IjisdI3WAmfsiatLC/uHa+qt5L4WQsCGRxyCV6iDgmq8hn2naErfFCnDWyCjvGXFD9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8557 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_005118_118756_3446E824 X-CRM114-Status: GOOD ( 26.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/03/24 5:51 pm, claudiu beznea wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 23.02.2024 19:29, Varshini Rajendran wrote: >> Add support to get number of IRQs from the respective DT node for sam9x60 >> and sam9x7 devices. Since only this factor differs between the two SoCs, >> this patch adds support for the same. Adapt the sam9x60 dtsi >> accordingly. >> >> Signed-off-by: Varshini Rajendran >> --- >> Changes in v4: >> - Changed the implementation to fetch the NIRQs from DT as per the >> comment to avoid introducing a new compatible when this is the only >> difference between the SoCs related to this IP. >> --- >> arch/arm/boot/dts/microchip/sam9x60.dtsi | 1 + >> drivers/irqchip/irq-atmel-aic5.c | 11 ++++++++--- >> 2 files changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/boot/dts/microchip/sam9x60.dtsi b/arch/arm/boot/dts/microchip/sam9x60.dtsi >> index 73d570a17269..e405f68c9f54 100644 >> --- a/arch/arm/boot/dts/microchip/sam9x60.dtsi >> +++ b/arch/arm/boot/dts/microchip/sam9x60.dtsi >> @@ -1201,6 +1201,7 @@ aic: interrupt-controller@fffff100 { >> interrupt-controller; >> reg = <0xfffff100 0x100>; >> atmel,external-irqs = <31>; >> + microchip,nr-irqs = <50>; >> }; >> >> dbgu: serial@fffff200 { >> diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c >> index 145535bd7560..5d96ad8860d3 100644 >> --- a/drivers/irqchip/irq-atmel-aic5.c >> +++ b/drivers/irqchip/irq-atmel-aic5.c >> @@ -398,11 +398,16 @@ static int __init sama5d4_aic5_of_init(struct device_node *node, >> } >> IRQCHIP_DECLARE(sama5d4_aic5, "atmel,sama5d4-aic", sama5d4_aic5_of_init); >> >> -#define NR_SAM9X60_IRQS 50 >> - >> static int __init sam9x60_aic5_of_init(struct device_node *node, >> struct device_node *parent) >> { >> - return aic5_of_init(node, parent, NR_SAM9X60_IRQS); >> + int ret, nr_irqs; >> + >> + ret = of_property_read_u32(node, "microchip,nr-irqs", &nr_irqs); >> + if (ret) { >> + pr_err("Not found microchip,nr-irqs property\n"); > > This breaks the ABI. You should ensure old device trees are still working > with this patch. The only older device that uses this API is sam9x60 and the newly added sam9x7. This change has been tested to be working fine in both the devices. If you still want me to use the macros as a fallback in the failure case I can do it. But this change was proposed to avoid adding macros in the first place. I can remove the error check just like they do while getting other device tree properties. Or if this is just a concern of the old devices working with the new change, then sam9x60 works. Please let me know how to proceed. > >> + return ret; >> + } >> + return aic5_of_init(node, parent, nr_irqs); >> } >> IRQCHIP_DECLARE(sam9x60_aic5, "microchip,sam9x60-aic", sam9x60_aic5_of_init); -- Thanks and Regards, Varshini Rajendran. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel