From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16ABAC47DD9 for ; Fri, 22 Mar 2024 10:27:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0zhIqO9DErdj5zhSnx0l70TURhHEs7a7JrNkMNQD57Q=; b=oZJC8GPJrgsCDG kEck22mv8/bxwnrGg147HDs6DC7sS2OHg82VCLGO1zUYKI5D+5PeCZMBvgin+j9OR5sFDQ+jOerG9 /BbY2w1t/PT2+tEQMYxMp5CcvR9sOxRmx+ixD8FzcsNIexog2XO0l8i31PhfhebZzw+ZkHSohw3R2 EIgPLr5xDi2sGRXgOhK4q3eGz5swXafBVx3XEXIMH5eQerCyq7LcSMXmIDyBm53Gi1st/CrYaSB9j ZTgAjpMdeeP7BSIvk8XqympGYk7wNmgqZpafcXRHj0I3fg6eU7kbY7B4oc+XarzT6rYGKEJ8EFy2s sT5I818gU4YOUFM5N9Pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnc6k-00000006lzG-03HH; Fri, 22 Mar 2024 10:26:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnc6g-00000006lx0-3vK9 for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 10:26:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E050D1007; Fri, 22 Mar 2024 03:27:09 -0700 (PDT) Received: from [10.57.71.57] (unknown [10.57.71.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 763BF3F64C; Fri, 22 Mar 2024 03:26:33 -0700 (PDT) Message-ID: Date: Fri, 22 Mar 2024 10:26:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning() Content-Language: en-US To: Christian Loehle Cc: dietmar.eggemann@arm.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org References: <20240314140421.3563571-1-lukasz.luba@arm.com> <20240314140421.3563571-4-lukasz.luba@arm.com> From: Lukasz Luba In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_032639_141412_66881F8C X-CRM114-Status: GOOD ( 19.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christian, On 3/14/24 14:32, Christian Loehle wrote: > On 14/03/2024 14:04, Lukasz Luba wrote: >> Add a function which allows to modify easily the EM after the new voltage >> information is available. The device drivers for the chip can adjust >> the voltage values after setup. The voltage for the same frequency in OPP >> can be different due to chip binning. The voltage impacts the power usage >> and the EM power values can be updated to reflect that. >> >> Signed-off-by: Lukasz Luba >> --- >> include/linux/energy_model.h | 5 ++++ >> kernel/power/energy_model.c | 51 ++++++++++++++++++++++++++++++++++++ >> 2 files changed, 56 insertions(+) >> >> diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h >> index 770755df852f1..d30d67c2f07cf 100644 >> --- a/include/linux/energy_model.h >> +++ b/include/linux/energy_model.h >> @@ -172,6 +172,7 @@ struct em_perf_table __rcu *em_table_alloc(struct em_perf_domain *pd); >> void em_table_free(struct em_perf_table __rcu *table); >> int em_dev_compute_costs(struct device *dev, struct em_perf_state *table, >> int nr_states); >> +int em_dev_update_chip_binning(struct device *dev); >> >> /** >> * em_pd_get_efficient_state() - Get an efficient performance state from the EM >> @@ -387,6 +388,10 @@ int em_dev_compute_costs(struct device *dev, struct em_perf_state *table, >> { >> return -EINVAL; >> } >> +static inline int em_dev_update_chip_binning(struct device *dev) >> +{ >> + return -EINVAL; >> +} >> #endif >> >> #endif >> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c >> index 6960dd7393b2d..1494a909844a4 100644 >> --- a/kernel/power/energy_model.c >> +++ b/kernel/power/energy_model.c >> @@ -808,3 +808,54 @@ static void em_update_workfn(struct work_struct *work) >> { >> em_check_capacity_update(); >> } >> + >> +/** >> + * em_dev_update_chip_binning() - Update Energy Model with new values after >> + * the new voltage information is present in the OPPs. >> + * @dev : Device for which the Energy Model has to be updated. >> + * >> + * This function allows to update easily the EM with new values available in >> + * the OPP framework and DT. It can be used after the chip has been properly >> + * verified by device drivers and the voltages adjusted for the 'chip binning'. >> + * It uses the "dynamic-power-coefficient" DT property to calculate the power >> + * values for EM. For power calculation it uses the new adjusted voltage >> + * values known for OPPs, which might be changed after boot. >> + */ >> +int em_dev_update_chip_binning(struct device *dev) >> +{ >> + struct em_perf_table __rcu *em_table; >> + struct em_perf_domain *pd; >> + int i, ret; >> + >> + if (IS_ERR_OR_NULL(dev)) >> + return -EINVAL; >> + >> + pd = em_pd_get(dev); >> + if (!pd) { >> + dev_warn(dev, "Couldn't find Energy Model %d\n", ret); > > ret is uninitialized at this point, I guess just > + dev_warn(dev, "Couldn't find Energy Model\n"); > already contains everything relevant. > Good catch, thanks! Yes, I agree it contains enough. I'm going to send v2 with this. Regards, Lukasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel