From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EE87C433F5 for ; Tue, 11 Jan 2022 00:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=riZGXKwTWnfCsnXEp2rlmPsLBRAaof22QNJNQhKW9Ec=; b=4w17GVoPc3eoGu f3eruIeRpolFm6cvEENd7rXrwchyRWmHj2jrsSa1On0Z+xh2R4NYniPBIz9YfgJP5+HM8MBsNCI8n UWtZAIVq7QzM5NkY8TBEXOdejhIhA3hGoeqOu9nEMzO/lWblMgcJJW5KPPSVqME9SL8amiGgdbQbD PEFc5nWcXnhyfk1V3uaa4Sy38n715NjODscariNJYPiqIoL/e3xHnqW/7oIFsdN19r8mOpc0/GE8M xFVxoTtvwi1ycpzigkdecHxldVcSYsP0RmVXeP49Eb621QLJfAfWXSqjZctw7P+s9ApVVu5mtJ8PA P5TZ8DCBw9SerQN5OlZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n74sV-00E3sx-Vn; Tue, 11 Jan 2022 00:19:08 +0000 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n74sS-00E3s3-PA for linux-arm-kernel@lists.infradead.org; Tue, 11 Jan 2022 00:19:06 +0000 Received: by mail-qk1-x733.google.com with SMTP id f138so17327735qke.10 for ; Mon, 10 Jan 2022 16:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=RUJ7uJMEeEhsJoqBp40ayA1X7yhjrJAzeMDsVRChGZU=; b=S6pPOW4QL+gADjyZhSQ9f0IUmKgK/8rGcICxVWY1hIAGpa9wuBatdW6lYt1nEa0UlE mDzKqhzoatwOPQwaPvreH7iQp9mB2vEeDnF6pXl7puDwL/xce+DDcFsms2WRLYOas/TD z5h2BTDCmUp2v05SCtkfsbRUG9lktvgSfu1Lb5LCWxHvRohz6t7ZZ3dPDgfgwa76c5n0 Fasnpn8H5S8L3AIu+Zn/B+ZDCqccxHbtlNyVwJ3WdjyILO9wp2+55cnmP25l9T5IIWPg rwbqOazU/Am/6t184ernOkHTgmCVWVzyCmr9XGSWVlLWmnbuBIA9b+ibXunj77DMUeoc RYzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=RUJ7uJMEeEhsJoqBp40ayA1X7yhjrJAzeMDsVRChGZU=; b=cs+oxX2QHq7DcOOUWeMFMPJj7mFdkAi2V5IZAkG/BWzvCKrS4kAsWjIaTP59Yt/o1o we8vnnTSGvCiftxEHSXMKnep5kf43MXMOp3d02EmFRUUy/Hy4qVGqWz21AlqfE9aL7hW t12ENmvBwnbSdStgazHcx084m8RkgOnGjsEVax49aNC6OqSfq9VDEObDMFveKOUGeEqJ upY17xDfE/Gp0q7uor8yqqBJSXNKLqAmp4bxh/Oof9HkTafvpH1AST5ivFjYkDD0p4zM j3IX4NmTx+XejiFcS2Yyv22E3jEnSSJXmEOdyoyTggvFyLc6cyLqgo1Np4lmmPmPh2hO 1iCQ== X-Gm-Message-State: AOAM531U6Jbx228rjkt6fUXbNZJsMRnlDRpP+NJWrqFgtdOECcw4rKgs gvSbUYNsRWZusbtaFYlv7RA= X-Google-Smtp-Source: ABdhPJwa41EczwvAQUKQdQ5jTpSkuQyZia7x61pNiOQzsbpG8FVGVnyZLnHaVs6mR7StpIpb0pY1mQ== X-Received: by 2002:a05:620a:2942:: with SMTP id n2mr1665704qkp.340.1641860342256; Mon, 10 Jan 2022 16:19:02 -0800 (PST) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id a3sm5784796qtx.66.2022.01.10.16.19.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jan 2022 16:19:01 -0800 (PST) Message-ID: Date: Mon, 10 Jan 2022 19:18:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v7 5/7] clk: imx: Add initial support for i.MXRT1050 clock driver Content-Language: en-US To: Abel Vesa , Stephen Boyd Cc: linux-imx@nxp.com, mturquette@baylibre.com, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, gregkh@linuxfoundation.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, adrian.hunter@intel.com, jirislaby@kernel.org, giulio.benetti@benettiengineering.com, nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org References: <20220103233948.198119-1-Mr.Bossman075@gmail.com> <20220103233948.198119-6-Mr.Bossman075@gmail.com> <20220105235157.8ED80C36AEB@smtp.kernel.org> <89046151-e44e-6828-ad76-8574fba4fca8@gmail.com> <20220110201201.C1E37C36AE9@smtp.kernel.org> From: Jesse Taube In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_161904_857836_0B701A1B X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/10/22 17:48, Abel Vesa wrote: > On 22-01-10 12:12:00, Stephen Boyd wrote: >> Quoting Jesse Taube (2022-01-09 11:07:42) >>>>> + >>>>> + clk_hw_data->num = IMXRT1050_CLK_END; >>>>> + hws = clk_hw_data->hws; >>>>> + >>>>> + hws[IMXRT1050_CLK_OSC] = __clk_get_hw(of_clk_get_by_name(np, "osc")); >>>> >>>> Use clk_parent_data instead and reference the binding name with .fw_name >>> >>> Hi Stephen, sorry to bother you again. >>> I'm wondering if adding `clk_parent_data` is necessary as it seems like >>> it wold be a big change and the other IMX boards haven't implemented >>> this yet would it be okay if I don't do this, or if it is necessary >>> could you link to a patch set to change it. >>> >> >> Is it a big change because the imx_clk_hw*() APIs aren't prepared for >> non-string parents? Can you make some clk_parent_data based APIs and >> migrate things over gradually? This is really a question for i.MX folks >> to see if anyone is working on moving away from the string names. > > I'm currently looking into it. I would suggest we take this patch as is > and I'll switch it later on to clk_parent_data. Thanks so much that would be great! Should I sent the other changes requested I have them ready? Or should i wait. Best regards Jesse Taube _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel