From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C55FC28CBC for ; Sun, 3 May 2020 21:30:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE6E1206D7 for ; Sun, 3 May 2020 21:30:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F433UVmX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE6E1206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S7QWWm+OKsrEQwd0TVjV+cJv/OKZnV15ahaplEHhZmI=; b=F433UVmXlgZ3PkY8iEkbAxRgW WQL5qdmGS/rIlNLLyKEnkqOeGNVc29OL3iyCAbU9UzNvu43QfWsy7/0pBfVWoD1vpWPaAj8ZII3au Vs/t3JdRW55RknGR+EhBgMZ8lnRrnSUASWneY34sr5Qs73S+AuKJOfEYDLSuaydVEz+WD6Y4Mn4fP wosV0fHrmg1lbOsbgi40R6ryS7OvOTfIxF9geQKAibXkYyZmCCnI4ozI7EfjLQbat+Z9Pk5G19GvV 81DYlZUX5IrGhavg6drm3myXGUIEplctjiO2xqswVdIUoaqNetfOBJvVff0BeJ2wclQLOrSw10dav AT9CrwOUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVMCJ-0008PI-Um; Sun, 03 May 2020 21:30:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVMCF-0008D1-Ow for linux-arm-kernel@lists.infradead.org; Sun, 03 May 2020 21:30:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B82A31FB; Sun, 3 May 2020 14:30:43 -0700 (PDT) Received: from [10.37.12.17] (unknown [10.37.12.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C33E73F68F; Sun, 3 May 2020 14:30:41 -0700 (PDT) Subject: Re: [PATCH V3 05/16] arm64/cpufeature: Introduce ID_DFR1 CPU register To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org References: <1588426445-24344-1-git-send-email-anshuman.khandual@arm.com> <1588426445-24344-6-git-send-email-anshuman.khandual@arm.com> From: Suzuki K Poulose Message-ID: Date: Sun, 3 May 2020 22:35:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1588426445-24344-6-git-send-email-anshuman.khandual@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200503_143047_900649_23C01ACD X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, james.morse@arm.com, maz@kernel.org, will@kernel.org, kvmarm@lists.cs.columbia.edu Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/02/2020 02:33 PM, Anshuman Khandual wrote: > This adds basic building blocks required for ID_DFR1 CPU register which > provides top level information about the debug system in AArch32 state. > This is added per ARM DDI 0487F.a specification. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: James Morse > Cc: Suzuki K Poulose > Cc: kvmarm@lists.cs.columbia.edu > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > > Suggested-by: Will Deacon > Signed-off-by: Anshuman Khandual > --- > arch/arm64/include/asm/cpu.h | 1 + > arch/arm64/include/asm/sysreg.h | 3 +++ > arch/arm64/kernel/cpufeature.c | 10 ++++++++++ > arch/arm64/kernel/cpuinfo.c | 1 + > arch/arm64/kvm/sys_regs.c | 2 +- > 5 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/cpu.h b/arch/arm64/include/asm/cpu.h > index 464e828a994d..d9a78bdec409 100644 > --- a/arch/arm64/include/asm/cpu.h > +++ b/arch/arm64/include/asm/cpu.h > @@ -33,6 +33,7 @@ struct cpuinfo_arm64 { > u64 reg_id_aa64zfr0; > > u32 reg_id_dfr0; > + u32 reg_id_dfr1; > u32 reg_id_isar0; > u32 reg_id_isar1; > u32 reg_id_isar2; > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index c977449e02db..2e1e922e1409 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -154,6 +154,7 @@ > #define SYS_MVFR1_EL1 sys_reg(3, 0, 0, 3, 1) > #define SYS_MVFR2_EL1 sys_reg(3, 0, 0, 3, 2) > #define SYS_ID_PFR2_EL1 sys_reg(3, 0, 0, 3, 4) > +#define SYS_ID_DFR1_EL1 sys_reg(3, 0, 0, 3, 5) > > #define SYS_ID_AA64PFR0_EL1 sys_reg(3, 0, 0, 4, 0) > #define SYS_ID_AA64PFR1_EL1 sys_reg(3, 0, 0, 4, 1) > @@ -763,6 +764,8 @@ > #define ID_ISAR4_WITHSHIFTS_SHIFT 4 > #define ID_ISAR4_UNPRIV_SHIFT 0 > > +#define ID_DFR1_MTPMU_SHIFT 0 > + > #define ID_ISAR0_DIVIDE_SHIFT 24 > #define ID_ISAR0_DEBUG_SHIFT 20 > #define ID_ISAR0_COPROC_SHIFT 16 > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index a8247bf92959..2ce952d9668d 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -451,6 +451,11 @@ static const struct arm64_ftr_bits ftr_id_dfr0[] = { > ARM64_FTR_END, > }; > > +static const struct arm64_ftr_bits ftr_id_dfr1[] = { > + S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_DFR1_MTPMU_SHIFT, 4, 0), > - ID_UNALLOCATED(3,5), > + ID_SANITISED(ID_DFR1_EL1), > ID_UNALLOCATED(3,6), > ID_UNALLOCATED(3,7), > IIUC, we should not expose the MTPMU to the KVM guests. Either we could drop this entire patch, or we should emulate the MTPMU to 0 in KVM. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel