From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FBCDC433EF for ; Wed, 30 Mar 2022 15:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BhGRoHo07BMLB+ABfMKZxfk7IoXlP3iFgfN2d+LBvPg=; b=ehqzd0qDv6KqJ6 QbLSLTDZx4RyZw41iY4cycFY1P+p8XGviQX07e5Rqluv469hyWncImNA7UCsT/+CWviCcKqZadiIE IXz3YXfPXMHOj/+2/2VtyOHplPIs1Xzg3mu59806uDHpxgi37h4eOJ//v9ThgYYflXrh+gaeuKQ4A gkHYVKe9yMM1UYi21jG94by4offkv8rAPvYUzMvMkQsAjmanwkh1TTx6rrK5xlmhsQ8aUubp6R5U8 tE1JvHBT3Nv0M1jdogjOtu5DDlPB11nr9P7iI3q/fiXG9QV4FnvBKe12dNQmHNmiZqrDqLHg4sjiu 2PQ21OQ81ah+yFcGOwuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZaRy-00GbZ7-LD; Wed, 30 Mar 2022 15:41:34 +0000 Received: from mail-gv0che01on20716.outbound.protection.outlook.com ([2a01:111:f403:4012::716] helo=CHE01-GV0-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZaRu-00GbYJ-Qo for linux-arm-kernel@lists.infradead.org; Wed, 30 Mar 2022 15:41:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LCF9UA/QVMWk4r/ltodsC30HPtnSzWT1rzUhXKJOGA/0OE+lzBSLOoAW3xKHp7JZ1WUv4nsg6My5ll6DwO8lJHKVpgfifS3+rn//8FIyvbNgK4iNLY/E986Geg0BZPQf7TlsNKUw0Uie8Boc6+HclmzTLVtjSZHdAEo7dT3/aLwXLnx7NcTrQYK58E1d/1Q5ChSK3q5WDk916JgOcHAT62gdQTxFLphxjzq08T68RywZd/8/DzIHvUXdTP0NkcEyOcitQsiqDMSSTgnpn223dT3gHmYLQtoww0n+fMVvoRz9J3bWPQkmHu9eeBNIWU1Cfm1vRyokIhZcnuEPEzrJyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TwS3GGfbv6cWqoLzyjh+BCMxx0CH1bm2ZeZVCs6Pdso=; b=EfVwLGqn7awFUKEm+SMOb7ppekVWqLX2jbIi50cxi4zm8uq0rJEctxn/174SGwyjFp8U/BJjP4cxMoMKvpkL8IZPSzYIPG3J2NTiN2J/0i2B2uJIEAFVYyGjNZPYebgJDY7VFCyBjNpD5tquKAtSs+fV8GEAFRP0OAxKCVMbAiMUijgHgnpwJtKt+0ONs7ELnw91yBVuJ3Q9oUEVzCiihjgf0myfOpt2YKdV49B7u1P+TltteseZMSueRWTXUslmpQC6fxap1hL6upfXpq6ZEHVPvVpy8HY06HOKfiy67dZNKGpeg9j38791/xDJfmX7s2QqpcCs76mUukdRKDm4Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=toradex.com; dmarc=pass action=none header.from=toradex.com; dkim=pass header.d=toradex.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TwS3GGfbv6cWqoLzyjh+BCMxx0CH1bm2ZeZVCs6Pdso=; b=pWvuspSNETvzXqzu9R3zHr/paKJhPd8cidW994a2qZk6HhZeTrjHFpIs9Ii8YYyZKj5klHv1ZsjfgmohKM4bQJWHb+Li8H194gLZV+D4e44yOYswlwlm2b+i+U1qiGXa2KHP/WbIeyq9nqwP+Wbu50lNZ9CL2zcbNAyNIUfdbv8= Received: from ZRAP278MB0237.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:2e::13) by GVAP278MB0312.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:39::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.19; Wed, 30 Mar 2022 15:41:25 +0000 Received: from ZRAP278MB0237.CHEP278.PROD.OUTLOOK.COM ([fe80::d9ec:a2cc:7cc:e400]) by ZRAP278MB0237.CHEP278.PROD.OUTLOOK.COM ([fe80::d9ec:a2cc:7cc:e400%7]) with mapi id 15.20.5102.023; Wed, 30 Mar 2022 15:41:25 +0000 From: Max Krummenacher To: "festevam@gmail.com" , "shawnguo@kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , Marcel Ziswiler , "otavio@ossystems.com.br" , "tharvey@gateworks.com" Subject: Re: [PATCH] ARM: dts: imx6qdl-apalis: Fix sgtl5000 detection issue Thread-Topic: [PATCH] ARM: dts: imx6qdl-apalis: Fix sgtl5000 detection issue Thread-Index: AQHYRExXk5t/NFliWUK5VJOpeCXeH6zYEKGA Date: Wed, 30 Mar 2022 15:41:25 +0000 Message-ID: References: <20220326151455.1171719-1-festevam@gmail.com> In-Reply-To: <20220326151455.1171719-1-festevam@gmail.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=toradex.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8370b9b-789b-4947-899e-08da1263bfd9 x-ms-traffictypediagnostic: GVAP278MB0312:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AkOZG7zjLrJzJ9J6lrCntv9rJ+zFiSxuHRjygvcf45yY87P4dfpCwc3SVwsnu6Uc14BYHOpQihFpTPF+swtxU5bruoOKJE80EWd3Tv+hmFhGZZp81btmL3V4kI/vAlO04k3hdelRvjqXonB6xMkqyrBjUjrmKK5wEUw0dCFLciKTVLd0tk/36Z6VbxQt9QpQf4b5hehZG3q0vfK9B6FlWqcAC6l/bk2ADCqT9i7zQW5NQMaYN648XFAuqWRfPt/vp39qlTwhzd+RgOmEZxC6bm7lAxqcBU4AsrioUVFWJicLhG1tWUPuSPXHA1jAXCsEDM18JmpHG9DIx3UU8yLLm8aYooLj77UDxTT67Dl16vKDTslrVWUjxJoG0cP2Pc5s198jNm4k7dvGrA0L6oEnw/kbZD2mFGHxLD0ApWG/abdtNocekBbzxP5uxt5k5heOA6J5N2UeHhJhutpWMUElt8rVJ0u24YgrXeK203Go2/xKGwxancW0Yl5oQY2V4rCLxifFIMSqJbayMKElYfX07In5s3eXw+2BV/Nqo2V6p5q6+BTjzmm5QD2oFkzm7V6BjiNuhCWGroUF2GapwiM3oIfyV2Cbj6giLGiHAliRiEeOPzZ7O8Eu7MRhmAadmVgaROhNzdG09mZjGFOIEecxWT1v0f/Ti2B0VvKPUtkZGgRx2HURAwqMPmhTacKdwxH3TQO2Niii40WKM1t2IAGSV0bC4q9XcyeIlve/HyqBTZU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:ZRAP278MB0237.CHEP278.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(346002)(396003)(136003)(39850400004)(376002)(366004)(316002)(86362001)(26005)(76116006)(186003)(38100700002)(2616005)(83380400001)(122000001)(71200400001)(66446008)(2906002)(508600001)(6506007)(66556008)(4326008)(44832011)(64756008)(54906003)(6512007)(66946007)(8676002)(8936002)(66476007)(110136005)(38070700005)(6486002)(5660300002)(36756003)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?KytIbEl2VG1sRmtDcnBwV2szZCsra1kxTm9ITC9xTUhCM0s2cTB5a1BxTFlJ?= =?utf-8?B?L0lkWGtxNzJoaityY2YraTgzNDJPSGRpN01zRWxPUEsyQW5oSEdndnZCc2lk?= =?utf-8?B?L0VJdU9UWUppK2pvMEdPNVl6UnN6ci9NR2xtMlJhMVlqQm1MbWJvY2VEeS9p?= =?utf-8?B?bHdWNGprRU5jelRkZXFkeTdUaVJPTThFS3NhVTlmd1pUeHNtcDRKOTFYQW5h?= =?utf-8?B?SGpIOHorSnA2SXdIQWI2SVBMYzBURUVYY0ZIRGhXRnBxNzN2RHpSQjNnLzdj?= =?utf-8?B?UTR4eFRmaUZZMEgvNy9aL0c3S3RyQlZWU0gzdzZQUUc2UkFEdFFJSkVuS2VS?= =?utf-8?B?M3dtMWhTME5QZjNPODlCclNnQmVIMndBUXNNeEN4T3J2VlpJRW9MVGNqZFZr?= =?utf-8?B?L2Z1T1QraklVQzZNWFEya3YwdUYyWkpnY1dpZDNQMFIrTk9GOFVCU0JqdEha?= =?utf-8?B?aWtuNkFrS0NIaTJNNXpab21XRExYNFVuVHJMYVVOcWVPUmVUMmJyVkpEcHRF?= =?utf-8?B?MGZ3UGJzSy8zUUNCWXF4UGh3bmxHeEpqd2xZejNqSVV6MURZUmtCWE1EM1FD?= =?utf-8?B?bksrL1JFc0doUWtKMzM4NXhCWDBOcit3c2o5alJWVEJDN2hFam1wdDRFRndT?= =?utf-8?B?WEF6NEhDWjV0ek9FUU9maHRQb1NRVHJjb0JiUlY5WHIxNWw3a3JRdGZXNkpM?= =?utf-8?B?UjBLUUJGeXI4RlNoTXFFSUlxZUtGVmxZS0gxSzZnZTkva3BWeE9DTUh4U3Vt?= =?utf-8?B?UVFCOXo3L0tJM05TcmdJRmtzT2NUQ09wRndmdWwzd0txWEQvcncwVk9JelYx?= =?utf-8?B?OFBCUlcwUmxhTUNWRm9FWHdFNzFJc3hjd3pIZGMyTnYydkZQSXJIREtFQ01h?= =?utf-8?B?cjdUSFNnNWZCTHYxYzd5aVBBS3o2MkNLbC9uOEZEWEtkOG8yWG5HVEIvQmE4?= =?utf-8?B?V1QrZXBXd29lS1QxQmMxRCtRL1p2Smlha01GeDZISEZjOEp4R3NUMWQyOXpy?= =?utf-8?B?OGRYTFZqRnUvVm0vaUMycEZqMjNnekcxRjFvKzBzZUczeU9GZC9RMmo3eVJP?= =?utf-8?B?ZjRBM0VIQmc0NE90bStra3hKeWs4Rm9Nbmk0TVhLWWVaWitSclFhVHlDVDd6?= =?utf-8?B?SC9yaW5iVmlRNlowSGN6ZHFNbSt2SjBtM1FuREx4aEhXMnJmcTBndjVzTjNM?= =?utf-8?B?VXpnb1hERThUVjdmVjRValdtRjlTNEdwVGNXcDNzWnRENzFUMjlyUTBtd3hI?= =?utf-8?B?Qi9hMlhid3phV2RJMjlnTnJaeG1lVnZUYjVwbzJBMVRLcVdJQ1d0ZHp2dytG?= =?utf-8?B?NkxOMzBWdkdVclV6L0V2NmJLZ2Jndm95c3RqOVBzVzloWlpRMkEvWUZ2ZFh5?= =?utf-8?B?NnlYeFFFcUNEVGxKWEhQSkVGUTcweWluQWNrV2llRDdNRmVTTGo0ZDF4KzMw?= =?utf-8?B?Zkh2cGhmeDRWYkRHNVBVaElrZk81Mm4rUjcybnorU1ZMTHRqUng3akd6d1h5?= =?utf-8?B?ZW9qRGFkQ21icGFFVVVBQ2pxZFVMa2duVlhsK1lKVUR4aExCMXlWMWQ1Tjdr?= =?utf-8?B?SXdHTHBEUkVHcmJXbjJ3aFZhUFdKYjcyd3ZVakVkQ0ZBMVNVbHRqNW1pMUd1?= =?utf-8?B?Vjc4bEFZcVV2ZlAxMVJITWtsMmxvcGIyR0EyUHVWWU45YWx1S2hNMDlFTUlp?= =?utf-8?B?elFkVmE4VFdzQVFQL3htV1lCMzM3c1RxR0VTaVhvVW14MFcrYXQ4M3dMMmtu?= =?utf-8?B?MFVEOUlOczFLK1ROQTF5V2UrQ1B4b2hKSVFxT2cxS0pTcUdkS1NIblF0NUdi?= =?utf-8?B?OENCMTlYYXFMZmd3MTRiQUo4OGJLMlJ5OHBocFFUdE54RTUrMGxuTmQzOXov?= =?utf-8?B?czdFM1A5a01OeW4vc0Z4TXZ2S2JsOE5FbXZhRGJKUEl3ZDM5blFmSDBpUURP?= =?utf-8?B?VXZBK3R0UXBJZ2JsbVplbXVJaWRDYnJzcXBDUUNsS0hnRmxBUjhPYjc0RlV0?= =?utf-8?B?Z0VJVUxEYzF0Uk0vcEY4Mnc2SEc2N0Z3TlRmUmFtaVNPUTIxUUxycmZQVU83?= =?utf-8?B?emZKSU5oeGJxTm91MFhyZk1PNVROL0FLVmhhKzE4ZThmZ3RzM3dMd3lsNGx6?= =?utf-8?B?MmpPbGtraFMvMTdTZ3ZUbndxcERsdlkvWmlGbEVONjF5RzM3T2xkSWJDMVc0?= =?utf-8?B?Z211bjJaeUJTeVpxV2hMb2FacmlvREtZTHI3NG5hdFl5a21RRlM2YVhEN3No?= =?utf-8?B?bGNyT3QrN2lVM20yQlBIQUg5OVl1NVdpejlZMWZyd2tkSXEwUUEvSzV3cTA0?= =?utf-8?B?UmFPZmlsTlE4T3NyZWl1TDV2Sk9FTVhYNnBIR0hvcTdBWWEwN0d2clJmTGNt?= =?utf-8?Q?LOvECJXbm8e6VJDp/tP/nBTMmjtrjaxmfCdth?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0237.CHEP278.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: b8370b9b-789b-4947-899e-08da1263bfd9 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2022 15:41:25.5176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w4az2EG86y/7cS7835lBh1Ykep2IChdGOJChaZQ3Ee7WyOZSx+otmL1liqvPJUC8PebbJDnKmII5AX0O5qyciuHDscyCNKljCbVBOV7YDAY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVAP278MB0312 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220330_084130_978181_C2193405 X-CRM114-Status: GOOD ( 21.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2022-03-26 at 12:14 -0300, Fabio Estevam wrote: > On a custom carrier board with a i.MX6Q Apalis SoM, the sgtl5000 codec > on the SoM is often not detected and the following error message is > seen when the sgtl5000 driver tries to read the ID register: > > sgtl5000 1-000a: Error reading chip id -6 > > The reason for the error is that the MCLK clock is not provided > early enough. > > Fix the problem by describing the MCLK pinctrl inside the codec > node instead of placing it inside the audmux pinctrl group. > > With this change applied the sgtl5000 is always detected on every boot. > > Fixes: 693e3ffaae5a ("ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM") > Signed-off-by: Fabio Estevam > --- > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > index ed2739e39085..bd763bae596b 100644 > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > @@ -286,6 +286,8 @@ vgen6_reg: vgen6 { > codec: sgtl5000@a { > compatible = "fsl,sgtl5000"; > reg = <0x0a>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sgtl5000>; > clocks = <&clks IMX6QDL_CLK_CKO>; > VDDA-supply = <®_module_3v3_audio>; > VDDIO-supply = <®_module_3v3>; > @@ -517,8 +519,6 @@ MX6QDL_PAD_DISP0_DAT20__AUD4_TXC 0x130b0 > MX6QDL_PAD_DISP0_DAT21__AUD4_TXD 0x130b0 > MX6QDL_PAD_DISP0_DAT22__AUD4_TXFS 0x130b0 > MX6QDL_PAD_DISP0_DAT23__AUD4_RXD 0x130b0 > - /* SGTL5000 sys_mclk */ > - MX6QDL_PAD_GPIO_5__CCM_CLKO1 0x130b0 > >; > }; > > @@ -811,6 +811,12 @@ MX6QDL_PAD_NANDF_CS1__GPIO6_IO14 0x000b0 > >; > }; > > + pinctrl_sgtl5000: sgtl5000grp { > + fsl,pins = < > + MX6QDL_PAD_GPIO_5__CCM_CLKO1 0x130b0 > + >; > + }; > + > pinctrl_spdif: spdifgrp { > fsl,pins = < > MX6QDL_PAD_GPIO_16__SPDIF_IN 0x1b0b0 Thanks Fabio Acked-by: Max Krummenacher _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel