From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AADF3C433FE for ; Mon, 17 Oct 2022 07:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N41vK6piz1K7/nBf1mXlIxiB8CQpv9NvqqECkJ+DIrc=; b=SZUGk5VveD7I8j Tb3eAsHb6AhK+uSwi8MmfSBTheVCuZRjirkOw/FcK+oKBo/qsCtq/fSgs6dVGjrVaznBy4NEnNSXb i0BOCUy8doTe7x1wrpbYtzIZHtfFRNXZeyQWKb3CTUcr2OgyKGpI26PxXVHEP4rQ7NJfVm6X8Q8Ho DPlfQYsoDnVe5SekGK9L33LJfUo6+M14otLxMe81F72N6s2Xq5i9O0Qiiu74vd2fNpT1PhPyW6xlq x5PHC20h5ljxCTfqYfgjOwd9dWuKvnclNAHXtKogu+yoSeSsLSPFDu8LjeXoGtyIrdmH2KJhrY8Ca KOuizZjLM6/07BW18AVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okKPS-008Pm3-Qt; Mon, 17 Oct 2022 07:19:38 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okKPQ-008Pjk-1R for linux-arm-kernel@lists.infradead.org; Mon, 17 Oct 2022 07:19:37 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id DE10984EED; Mon, 17 Oct 2022 09:19:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1665991172; bh=SjAj6seYBPhk6U+OWYULFQrtnRvmj6Vg6YaIM8puxw0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZEtb3zofCkXTg2IUYgB48reM59wdMdsEKNw819GTiAzdhl7W1PNopJfSTtOtP4NT4 6980/EblEVdwSN5xWQSgM7eBSZ10TmVMy9qqI3ElQHfOZeEtDGUoLUcesXWsQvVGuf UnnO0TE/bDasJ7zddxbM/sMpBcuZyt/jkmpyIJgoTWF3Nlb0wfb3lq5Stv3qR8tAV8 vF18S9dYwdjLYsmCznd/HKCCIP2SCY/qbbtKc7qJbIE0k4sYa8x1SXPl/VRUUi+4XM ExXQ0LyB8X4vzkvzZtwsvLGy9ovwClhtaXyF5SMh9R5mw0HvO8yJ2N3V/3wHyivHYo vm6KUX/+eUr9A== Message-ID: Date: Mon, 17 Oct 2022 09:19:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v7 01/10] drm: bridge: Add Samsung DSIM bridge driver Content-Language: en-US To: Jagan Teki Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula References: <20221005151309.7278-1-jagan@amarulasolutions.com> <20221005151309.7278-2-jagan@amarulasolutions.com> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221017_001936_414774_4419874C X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/17/22 04:49, Jagan Teki wrote: > On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut wrote: >> >> On 10/5/22 17:13, Jagan Teki wrote: >>> Samsung MIPI DSIM controller is common DSI IP that can be used in various >>> SoCs like Exynos, i.MX8M Mini/Nano. >>> >>> In order to access this DSI controller between various platform SoCs, >>> the ideal way to incorporate this in the drm stack is via the drm bridge >>> driver. >>> >>> This patch is trying to differentiate platform-specific and bridge driver >>> code by maintaining exynos platform glue code in exynos_drm_dsi.c driver >>> and common bridge driver code in samsung-dsim.c providing that the new >>> platform-specific glue should be supported in the bridge driver, unlike >>> exynos platform drm drivers. >>> >>> - Add samsung_dsim_plat_data for keeping platform-specific attributes like >>> host_ops, irq_ops, and hw_type. >>> >>> - Initialize the plat_data hooks for exynos platform in exynos_drm_dsi.c. >>> >>> - samsung_dsim_probe is the common probe call across exynos_drm_dsi.c and >>> samsung-dsim.c. >>> >>> - plat_data hooks like host_ops and irq_ops are invoked during the >>> respective bridge call chains. >> >> Maybe the Subject should say "Split ... driver" or "Move ... driver" , >> since it is not adding a new driver here ? > > Though it is not added a completely new driver, it is adding more > infrastructure platform code to be compatible with both Exynos and > i.MX8M. This is the prime reason for adding that commit head and > explaining the same in the commit body. Diffstat looks like this: drivers/gpu/drm/bridge/samsung-dsim.c | 1703 ++++++++++++++++++++++ drivers/gpu/drm/exynos/Kconfig | 1 + drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 ++--------------------- include/drm/bridge/samsung-dsim.h | 113 ++ 7 files changed, 1952 insertions(+), 1653 deletions(-) Looks to me like most of the code is just moved from existing driver in this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel