Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Riabenko <roman@riabenko.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org,
	 andre.przywara@arm.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, 	devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
		linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] arm64: dts: allwinner: sun50i-a64-olinuxino: Add RX delay
Date: Thu, 20 Aug 2026 12:57:27 +0300	[thread overview]
Message-ID: <badf09f4411ad450b7a5def37099af1edbb40d8e.camel@riabenko.com> (raw)
In-Reply-To: <e9c26d2a-2426-43b7-8c68-89cc52a2c7cb@lunn.ch>

У ср, 2026-08-19 у 15:48 +0200, Andrew Lunn пише:
> On Sat, Aug 15, 2026 at 03:53:16AM +0300, Roman Riabenko wrote:
> > The Ethernet on Olimex A64-OlinuXino computers requires an RX delay
> > greater than 0. If the value is not set or is 0, packet loss in the
> > downlink direction is severe enough to interfere with downloads and
> > disrupt software installation.
> > 
> > The range of acceptable values is wide. The vendor has been
> > applying
> > 200 ps in its downstream DTs since 2021. This patch matches that
> > common practice.
> > 
> > Signed-off-by: Roman Riabenko <roman@riabenko.com>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > index fd3794678c33..6c8b79c257b9 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> > @@ -106,6 +106,7 @@ &emac {
> >  	phy-handle = <&ext_rgmii_phy>;
> >  	phy-supply = <&reg_dcdc1>;
> >  	allwinner,tx-delay-ps = <600>;
> > +	allwinner,rx-delay-ps = <200>;
> >  	status = "okay";
> >  };
> 
> The full node is:
> 
> &emac {
>         pinctrl-names = "default";
>         pinctrl-0 = <&rgmii_pins>;
>         phy-mode = "rgmii";
>         phy-handle = <&ext_rgmii_phy>;
>         phy-supply = <&reg_dcdc1>;
>         allwinner,tx-delay-ps = <600>;
>         status = "okay";
> };
> 
> Please take a read of:
> 
> https://elixir.bootlin.com/linux/v6.15/source/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L287
> 
> phy-mode of "rgmii" is questionable. Does the PCB have extra long
> clock lines?

The PCB tracks for RX clock in comparison to RX data are approximately
the same in length in the PCB layout file (12 mm or so). The tracks for
TX clock in comparison to TX data are approximately the same as well
(roughly 14-16 mm). Thus, the tracks themselves do not appear to
implement the 2ns RGMII delay. Any delay from the tracks' lengths is
likely insignificant.

When I change the phy-mode to rgmii-id and remove allwinner,tx-delay-
ps, the connection is stable in both upstream and downstream direction.
There are no retries in my iperf3 tests. According to KSZ9031RNX
datasheet, it adds a typical 1.2 ns delay to RX_CLK with respect to
RX_DV and RXD by default, but no TX delay is provided by default. The
rgmii-id configuration causes the PHY driver to enable appropriate
internal RGMII delays.

I will submit a second version of the patch changing phy-mode to rgmii-
id and removing allwinner,tx-delay-ps.

Thank you for referring me to the linked document.

Roman


      reply	other threads:[~2026-08-20  9:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15  0:53 [PATCH] arm64: dts: allwinner: sun50i-a64-olinuxino: Add RX delay Roman Riabenko
2026-08-16 18:59 ` Jernej Škrabec
2026-08-19 13:48 ` Andrew Lunn
2026-08-20  9:57   ` Roman Riabenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=badf09f4411ad450b7a5def37099af1edbb40d8e.camel@riabenko.com \
    --to=roman@riabenko.com \
    --cc=andre.przywara@arm.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox