From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E03D1C25B7C for ; Mon, 27 May 2024 08:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0f4MYPQshCQJuqDZp+i+2izGAgeFjna0Poo10z73BkM=; b=poL9eeGGR9GfWU lKbuuh2HZAMngWRD8+y7vRjLM9+n/kVUP/7dD7heoW202hQLHkms1wz+X9Gc+eNycNmM2JprGmz/m M7Og4+IsFuk1gtkkz84Z7DQFKqR3QQFNF2bYLC/SjztchRjO3N2ovR1ijAm1R6ZujdSbtWOXxPu2Y zY3EVA4E2TYTlOY12SlqAfSzca7b6Sm5cZhm7DWHfIt4ULF3UvEMaCR+yP6KBQh0Eb5a4Uc6U3Ulx tD9o0EBLEjoX8Km2wAYlqmhcpPUJzfQbem6tntKYSMoq/9ixeRS7LEiaaP+5757sFq0iVVOOjuGCd v9MPCHs3kWQEQC8w0QAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBVVM-0000000EC4c-0usl; Mon, 27 May 2024 08:14:52 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBVVI-0000000EC3b-3HGN for linux-arm-kernel@lists.infradead.org; Mon, 27 May 2024 08:14:50 +0000 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2e73359b900so75822881fa.2 for ; Mon, 27 May 2024 01:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1716797685; x=1717402485; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U9TONvTEWThGczkgWTi4O6+TwYpFpcfs3Yxs9Jjw9zo=; b=WKySpKgacypl9ThLCyZwft887Cmfwbvd26Fk44Ju/d+FkkLrHbZtS4T1PSJWxVcr/q IQ5yxwbo0e6QO2kGXHIEAsAe1joAB2zhDYRuWqIM9KOzpBUwKqf0j30PTjq4dNdQy8uB V27wu5+r97XS7l28n8495qKgV4GdfPO7sqPYSloVZNtXBPyrEjOFQTyujmXsSn5BIjZL P6+2YgupkMYIlvqu3ViYiTLYD8cIjJ9ocH1IUuNqNg8gFTXAVFDdSK5pe6M3X78dYF/M lXzs/g874jCYzN4hEvyLhFm3gM9R+0MdNuW4L0wNazFfr2CqR+kz021+JmFwy5NCJu5q l4Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716797685; x=1717402485; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U9TONvTEWThGczkgWTi4O6+TwYpFpcfs3Yxs9Jjw9zo=; b=EUhhM17awUlPDSWDUUAIAbZ7ArxRQFDBqlz/SOU/TqYsldXmF/xFuyjLjqjQLA3ugB a1tIyzjrT+KKstZFdXxxFsFvDdH4PLJ/U/+gW9QFHV4x8wTys7Y2L2fn84VFhV8RpW1y gVgIzs6d1Qu4/HcKgrYlIQYEySzmiADuPUZA8ygA6iiPdVny3l5Z5jWfssj9qPwLR+W2 6zS3bUoIXW+lKlCTMKmY2jLSIPcfcHZaUmPIdMp30TFbxEfJ4jErJOojAMjImY2cknJP OpvAxL5gESBwQ2TLaz/1z+xzIi/fK2aRl3ZmhwKSG6Y4ExLDJEn9wD2usb51YtdEyX91 p2ow== X-Forwarded-Encrypted: i=1; AJvYcCUrW78GLiPLcSB7QYoGVvgTA3SpWqhmE9RHEkhBJYzy3Y/lU2NSwKte+q0ciFVx3SIQZ64jaba5pWF1LI/gD8O+74+tXC0xCxeKWA8h4UF+UxFcRa8= X-Gm-Message-State: AOJu0Yzqt5uH/qEk2eDnU42eoRMJn707UCeUTmsK+HUyDbrU5bKvl7zj EftPnnOWT3Vjq+XiYkpeCSdipDaptCcyoWrivr+Cb6ExY+sHV43llkWIRN2UalY= X-Google-Smtp-Source: AGHT+IE5hwvA+dnXZp0Ce0d7BlZoXZS8BtrFd0HTMRigsC5U6EqzAEtorNHmX+hus94f/jH5p+ygFg== X-Received: by 2002:a2e:9819:0:b0:2e9:6d3e:e91f with SMTP id 38308e7fff4ca-2e96d3ee9b2mr28178891fa.52.1716797685169; Mon, 27 May 2024 01:14:45 -0700 (PDT) Received: from [192.168.27.173] ([77.205.21.89]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4210896fc8asm100562585e9.13.2024.05.27.01.14.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 01:14:44 -0700 (PDT) Message-ID: Date: Mon, 27 May 2024 10:14:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/6] dt-bindings: thermal: mediatek: Rename thermal zone definitions for MT8186 and MT8188 To: Conor Dooley Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Lezcano , Nicolas Pitre , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20240524-mtk-thermal-mt818x-dtsi-v5-0-56f8579820e7@baylibre.com> <20240524-mtk-thermal-mt818x-dtsi-v5-1-56f8579820e7@baylibre.com> <20240524-concerned-fritter-262f5e16293e@spud> Content-Language: en-US From: Julien Panis In-Reply-To: <20240524-concerned-fritter-262f5e16293e@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240527_011448_861899_A814DDF8 X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/24/24 20:24, Conor Dooley wrote: > On Fri, May 24, 2024 at 11:04:34AM +0200, Julien Panis wrote: >> Use thermal zone names that make more sense. >> >> Signed-off-by: Julien Panis > Removing the defines is an ABI break. If these are all the same devices, > but with more accurate naming, then keep the old defines and add new > ones. However, the GPU1 define changes in the course of this patch which > is more problematic. > > Why do these names even make more sense? Where did the old names come > from and where do the new? > > Thanks, > Conor. Thanks for your comment. For mt8188, the old name 'soc' came from a document by MTK, which is not public: MT8188G Functional Specification. This document does not explain what 'soc' are/do exactly, it just says that some temperature sensors are located on them. Then, there was a comment about these 'soc' names: https://lore.kernel.org/all/ff12e104-da8b-4800-bfbe-a006ffe1b840@collabora.com/ So, I had a discussion with MTK to understand what these 'soc1/2/3' are/do. The new names comes from this discussion and were given by MTK. For the other SoC of this series (mt8186), the same kind of document exists (MT8186G Functional Specification) and explains what 'soc' are/do exactly: ('cam', 'dsp', 'nna'...which are used in 'mt8186.dtsi'). Using the same logic in 'mt8188.dtsi' would be more consistent. Besides, these names are more explicit. Julien > >> --- >> include/dt-bindings/thermal/mediatek,lvts-thermal.h | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/include/dt-bindings/thermal/mediatek,lvts-thermal.h b/include/dt-bindings/thermal/mediatek,lvts-thermal.h >> index bf95309d2525..ddc7302a510a 100644 >> --- a/include/dt-bindings/thermal/mediatek,lvts-thermal.h >> +++ b/include/dt-bindings/thermal/mediatek,lvts-thermal.h >> @@ -24,7 +24,7 @@ >> #define MT8186_BIG_CPU1 5 >> #define MT8186_NNA 6 >> #define MT8186_ADSP 7 >> -#define MT8186_MFG 8 >> +#define MT8186_GPU 8 >> >> #define MT8188_MCU_LITTLE_CPU0 0 >> #define MT8188_MCU_LITTLE_CPU1 1 >> @@ -34,11 +34,11 @@ >> #define MT8188_MCU_BIG_CPU1 5 >> >> #define MT8188_AP_APU 0 >> -#define MT8188_AP_GPU1 1 >> -#define MT8188_AP_GPU2 2 >> -#define MT8188_AP_SOC1 3 >> -#define MT8188_AP_SOC2 4 >> -#define MT8188_AP_SOC3 5 >> +#define MT8188_AP_GPU0 1 >> +#define MT8188_AP_GPU1 2 >> +#define MT8188_AP_ADSP 3 >> +#define MT8188_AP_VDO 4 >> +#define MT8188_AP_INFRA 5 >> #define MT8188_AP_CAM1 6 >> #define MT8188_AP_CAM2 7 >> >> >> -- >> 2.37.3 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel