From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jun Guo <jun.guo@cixtech.com>,
peter.chen@cixtech.com, fugang.duan@cixtech.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
ychuang3@nuvoton.com, schung@nuvoton.com, robin.murphy@arm.com,
Frank.Li@kernel.org
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/3] dma: arm-dma350: support combined IRQ mode with runtime IRQ topology detection
Date: Mon, 23 Mar 2026 13:03:35 +0100 [thread overview]
Message-ID: <bb4d7661-0f06-4f74-89f2-09fd4888f166@kernel.org> (raw)
In-Reply-To: <20260323114822.1925869-3-jun.guo@cixtech.com>
On 23/03/2026 12:48, Jun Guo wrote:
>
> dch->has_wrap = FIELD_GET(CH_CFG_HAS_WRAP, reg);
> dch->has_trig = FIELD_GET(CH_CFG_HAS_TRIGIN, reg) &
> @@ -640,6 +752,7 @@ static void d350_remove(struct platform_device *pdev)
> }
>
> static const struct of_device_id d350_of_match[] __maybe_unused = {
> + { .compatible = "cix,sky1-dma-350" },
Redundant. Drop. Review your LLM generated code...
> { .compatible = "arm,dma-350" },
> {}
> };
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-23 12:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 11:48 [PATCH v4 0/3] dmaengine: arm-dma350: support combined IRQ topology Jun Guo
2026-03-23 11:48 ` [PATCH v4 1/3] dt-bindings: dma: arm-dma350: document generic and combined IRQ topologies Jun Guo
2026-03-23 12:00 ` Krzysztof Kozlowski
2026-03-23 12:02 ` Krzysztof Kozlowski
2026-03-23 12:15 ` Jun Guo
2026-03-23 12:14 ` Jun Guo
2026-03-24 12:04 ` Robin Murphy
2026-03-25 6:05 ` Jun Guo
2026-03-23 11:48 ` [PATCH v4 2/3] dma: arm-dma350: support combined IRQ mode with runtime IRQ topology detection Jun Guo
2026-03-23 12:03 ` Krzysztof Kozlowski [this message]
2026-03-24 12:59 ` Robin Murphy
2026-03-23 11:48 ` [PATCH v4 3/3] arm64: dts: cix: add DT nodes for DMA Jun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb4d7661-0f06-4f74-89f2-09fd4888f166@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=jun.guo@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=schung@nuvoton.com \
--cc=vkoul@kernel.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox