From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1379C282CE for ; Tue, 4 Jun 2019 12:05:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 976B8249EF for ; Tue, 4 Jun 2019 12:05:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sj64sIOW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 976B8249EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xQbhZ15kWJ5FwlldwmiAPoOQ1YPE0gzvM0KSwBsILKY=; b=Sj64sIOWGBdza5 DUIUoQXs6aKv6CnxM3DaK/V+ydI0jrtAA57n7Y0T4s5UjowbB5op1PAg0rjYKhGGUW0+yE6v7ZqWG jZkEB+6K1zjpCm53PUqGU/ozdgbwY/8BmF9HCTCPge6c3yIvAAaPIbWfFwDE01JENPZExdnaV5Oh6 vo4rvp2XFPrcUF2OfmuRWUXvd2W1rk36fQeVfn56kLQZySy25oLVtwCG771mfzRSAzdWTIn5fDwb5 N6y7BMJcYmWPJVbKTy9SHTTHYiMF48FSMzf0Pw1Q4wYwLZH+3z80d1LWYyyi9Js6MlhvdP2DtQSh0 fGbiqAKmMSZsT2qB6BWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY8CJ-00013F-U7; Tue, 04 Jun 2019 12:05:47 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY8CH-00012F-Kl for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 12:05:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 783AC80D; Tue, 4 Jun 2019 05:05:45 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 58CBA3F690; Tue, 4 Jun 2019 05:05:42 -0700 (PDT) Subject: Re: [PATCH v6 01/19] kernel: Standardize vdso_datapage To: Arnd Bergmann References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-2-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: Date: Tue, 4 Jun 2019 13:05:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_050545_684277_0E3F19D3 X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Huw Davies , Catalin Marinas , Daniel Lezcano , Will Deacon , Linux Kernel Mailing List , Ralf Baechle , linux-mips@vger.kernel.org, Paul Burton , "open list:KERNEL SELFTEST FRAMEWORK" , Rasmus Villemoes , Russell King , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/05/2019 09:16, Arnd Bergmann wrote: > On Thu, May 30, 2019 at 4:15 PM Vincenzo Frascino > wrote: > >> + * vdso_data will be accessed by 64 bit and compat code at the same time >> + * so we should be careful before modifying this structure. >> + */ >> +struct vdso_data { >> + u32 seq; >> + >> + s32 clock_mode; >> + u64 cycle_last; >> + u64 mask; >> + u32 mult; >> + u32 shift; >> + >> + struct vdso_timestamp basetime[VDSO_BASES]; >> + >> + s32 tz_minuteswest; >> + s32 tz_dsttime; >> + u32 hrtimer_res; >> +}; > > The structure contains four padding bytes at the end, which is > something we try to avoid, at least if this ends up being used as > an ABI. Maybe add "u32 __unused" at the end? > Agreed, I will fix this in v7. > Arnd > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel