From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E18A9C6FD18 for ; Tue, 18 Apr 2023 20:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J4CIzA5+ebC8p+z23IALlMXIMUuiICb/VZmfQ7PYfmA=; b=0Rl7huJcExTVo6 c98rhDLftHQ/It82YBIxEinoR0Z6C/T7cTlevA50rL6hkhApKwG/LZ36S4iUJNPlwgo3Cx4Mx94D1 9siv+f36zh3N9p7BmJ5BPuHDBbfzNAnPp3jaLF4hUMU1qrkxbf2EpYLP8n+kSD3+kP5hff35IKFSL Lx4PndUxdQS+QukLSxQvnED2E9t8wR+k2chwI1OnQ85YOhaH92C3FQs6i+xCb44e0vkMt1l9Y80hV 7M+bVTDk8qwZ6y2/jNobGWiKe66EDzkhrYcjHL98stIwjxGmMZ4FRaAyNIkGXAwJpGmXNCAF7kYa9 y8fVVlnmPfRPM25CZMXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1porVT-003EMD-1t; Tue, 18 Apr 2023 20:00:51 +0000 Received: from mx4.securetransport.de ([178.254.6.145]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1porVP-003EL8-1m for linux-arm-kernel@lists.infradead.org; Tue, 18 Apr 2023 20:00:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1681848010; bh=C8n+u6LGHwZMhPF+YX4nvzfsQzvMFbR9EYTHpXERbIQ=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=J+GFblxL10crjZMM+rtTPaZRh3AysPVwW+jcdL/f1vDj9sjFe16oxOK6FYXgT3iik KnYKoExg6AILFRGeHqSonN6F3qjX7Kkrk1mRez8OK048Tr+Trc1yEm/L6WEIiFaJvP dwQ6NsN+xAFlAZfy0KxayXAOtCvBXUmq0ck8Q/g5lwhD2mQBRjhKbmausdlw6eM5Qg wAzgWiAcDv6sqJ4y4v1Ti+8YsSj/61B9BcpWO7gW3VfrUuvpIcKtQGCpMiQ3tenFiZ T0xwtO77djIl/miGtYGkNgt777d/k1yiERxEfvURpV3IyT7RuyiSE5jIQkwfIPutG5 DMKa+24s0Vcvw== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: "linux-arm-kernel@lists.infradead.org" CC: Support Opensource , Adam Thomson , Liam Girdwood , Mark Brown , Marek Vasut , kernel , "linux-kernel@vger.kernel.org" , Christoph Niedermaier Subject: RE: [PATCH V4 3/3] regulator: da9062: Make the use of IRQ optional Thread-Topic: [PATCH V4 3/3] regulator: da9062: Make the use of IRQ optional Thread-Index: AQHZUmi9/xwYP1tNtkugFXddhctvjq8xtZQA Date: Tue, 18 Apr 2023 20:00:03 +0000 Message-ID: References: <20230309092254.56279-1-cniedermaier@dh-electronics.com> <20230309092254.56279-3-cniedermaier@dh-electronics.com> In-Reply-To: <20230309092254.56279-3-cniedermaier@dh-electronics.com> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_130047_833472_B0D3F1D8 X-CRM114-Status: GOOD ( 23.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Christoph Niedermaier [mailto:cniedermaier@dh-electronics.com] Sent: Thursday, March 9, 2023 10:23 AM > This patch makes the use of IRQ optional to make the DA9061/62 usable > for designs that don't have the IRQ pin connected, because the regulator > is usable without IRQ. > > Signed-off-by: Christoph Niedermaier > Acked-by: Mark Brown > Reviewed-by: Adam Ward > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202303082246.GuLdPL0t-lkp@intel.com/ > --- > Cc: Support Opensource > Cc: Adam Thomson > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Marek Vasut > Cc: kernel@dh-electronics.com > Cc: linux-kernel@vger.kernel.org > To: linux-arm-kernel@lists.infradead.org > --- > V2: - Rebase on current next 20230209 > - Add Reviewed-by and Acked-by tags > V3: - Rebase on current next 20230307 > v4: - Rebase on current next 20230309 > - Fix a missing variable change reported by kernel test robot > --- > drivers/regulator/da9062-regulator.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/regulator/da9062-regulator.c b/drivers/regulator/da9062-regulator.c > index 1a6324001027..ae7955afce86 100644 > --- a/drivers/regulator/da9062-regulator.c > +++ b/drivers/regulator/da9062-regulator.c > @@ -924,7 +924,7 @@ static int da9062_regulator_probe(struct platform_device *pdev) > struct da9062_regulator *regl; > struct regulator_config config = { }; > const struct da9062_regulator_info *rinfo; > - int irq, n, ret; > + int n, ret; > int max_regulators; > > switch (chip->chip_type) { > @@ -1012,12 +1012,11 @@ static int da9062_regulator_probe(struct platform_device *pdev) > } > > /* LDOs overcurrent event support */ > - irq = platform_get_irq_byname(pdev, "LDO_LIM"); > - if (irq < 0) > - return irq; > - regulators->irq_ldo_lim = irq; > + regulators->irq_ldo_lim = platform_get_irq_byname_optional(pdev, "LDO_LIM"); > + if (regulators->irq_ldo_lim < 0) > + return 0; > > - ret = devm_request_threaded_irq(&pdev->dev, irq, > + ret = devm_request_threaded_irq(&pdev->dev, regulators->irq_ldo_lim, > NULL, da9062_ldo_lim_event, > IRQF_TRIGGER_LOW | IRQF_ONESHOT, > "LDO_LIM", regulators); Hi, In V3 of this patch the kernel test robot found an issue. A fix is important, because otherwise the normal path with IRQ could have problems. So I fixed it in V4. Any comments or is it OK how I fixed it? Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel