From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB30FC636D4 for ; Fri, 17 Feb 2023 08:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1vx38fuyRB3ZOpjEwZjlfZLdYwjgUYx3x5IwyMrZCO8=; b=QU3wlnsjsIOvAm rkFnER4EWWFc5VWXriTwBLluwth84Nqi61lWulAKAFWi2eS5tYmV9Uznfy4neo7rzKTO4zq5byUFN NPPgFnoo+Ok1VZ26ywzk8Ld1GVJditNkq0ckjaJyXdW8Gd9LGF0NzgOts2VenAOtMnKXoBEiCX23v Smt0FXuHI68q3Eq5bO09M+lV+caqi8q9rbqoSMJ2ijIMb9ZXtNOeS71SSuUaF0T7xr2TjT6xbnWRw AaGKDb9o0Z4JSLGmIiNuVJlJUDD4GC8xjLtL9BFMfCvYkygxPFQ3qIWiwp1WSBkmwJT6hG7uKtVga UMUuUEYYcNitFto5FXeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSwFO-00DKKh-7N; Fri, 17 Feb 2023 08:37:38 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSwFL-00DKJA-CR for linux-arm-kernel@lists.infradead.org; Fri, 17 Feb 2023 08:37:36 +0000 Received: by mail-ed1-x52c.google.com with SMTP id cn2so1494802edb.4 for ; Fri, 17 Feb 2023 00:37:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=rX+L+RQNvSmvl3vXjy6ejfPbMjDPoWjZZGv/1GsmR20=; b=Ls1Fayg63aBxblW6mHpeLVmXVbOasWCiICroEXVqnP5iZHKcq6ElDZ3ETAR60+Ep7m y33QuXhBCXzd8H1UAvoFVCb78iZpmUcHNTBgakDoCxEt9LWaSZCe+98JTYjQZ4OOlCDS Qm7P6yK/5PT3CwEIDxqzlItpjBCWr0R8jn9BMAxfWNIwmx7qfO1wgXD++qhq5RbyIvXf fxwXe0AzmtPBdAFjB7T4xTw9415OfcMhLuGHbX1Qad7qY5w89YUCBk7kAevg+mvcLtuw 8MaUGG7UsPrgGU9tKCceGKwo4q8AzYD1oXBfLGjS9Y4cY3Y4S5cp0PHC0Ob2DajkmLKS qytw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rX+L+RQNvSmvl3vXjy6ejfPbMjDPoWjZZGv/1GsmR20=; b=psOM1nRKJ0Jv5GrmZWk05LQEWqtakLyXWo0wO3NkviEwadcBj+cd43wWGRXPK7Hn+m Agg0752bPwRNT34N2/5sAKliPj7/EVMjj67hh4l81IUFmDnQEevb+k0fIQnsqfXXwiSW JrcuIxTgoLmo6PvIUhIjdSv0qzK3wS+9blgOEmx/0n4T5Em5R0rtlKqtDd+8EataiAy+ /DGIDxMMScdr5Iz9ah51t3fSGutk0sj6URayQSzbqixbkGwcmOFAGQOmD6f235X/gMna bA+nQRHic8YbxYD+4FRwOVNwRDbvlKdxjxcCBYOvKAC7BTfT4AOyLQ3qsxR8jiksG67L uZXw== X-Gm-Message-State: AO0yUKXQtTP4vURdNDXv+sKTXTqbe2ZTzo8/iX0zdHwccu9P5+uOD9cy p8Xva98TNMCuAWOl6412qreJFA== X-Google-Smtp-Source: AK7set/Y69SId1gyB/TFH7/ENtT0fJggoSlC+ReCLuRDgDfgQBRqc3eqQ+xubhnrYJ7kz3dsmzGGHw== X-Received: by 2002:a05:6402:18:b0:4ab:4011:ff3d with SMTP id d24-20020a056402001800b004ab4011ff3dmr61844edu.0.1676623042189; Fri, 17 Feb 2023 00:37:22 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id v30-20020a50d09e000000b004acdef7baaesm1921274edd.96.2023.02.17.00.37.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Feb 2023 00:37:21 -0800 (PST) Message-ID: Date: Fri, 17 Feb 2023 09:37:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 i2C driver To: Ryan Chen , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Philipp Zabel , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20230201103359.1742140-1-ryan_chen@aspeedtech.com> <20230201103359.1742140-3-ryan_chen@aspeedtech.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230217_003735_468713_C8D0E96F X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/02/2023 10:26, Ryan Chen wrote: > Hello Krzysztof > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Thursday, February 16, 2023 5:22 PM >> To: Ryan Chen ; Rob Herring >> ; Krzysztof Kozlowski >> ; Joel Stanley ; Andrew >> Jeffery ; Philipp Zabel ; >> openbmc@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; >> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for AST2600 >> i2C driver >> >> On 16/02/2023 10:20, Ryan Chen wrote: >>> Hello Krzysztof >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski >>>> Sent: Thursday, February 16, 2023 4:18 AM >>>> To: Ryan Chen ; Rob Herring >>>> ; Krzysztof Kozlowski >>>> ; Joel Stanley ; >>>> Andrew Jeffery ; Philipp Zabel >>>> ; openbmc@lists.ozlabs.org; >>>> linux-arm-kernel@lists.infradead.org; >>>> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org >>>> Subject: Re: [PATCH v4 2/3] dt-bindings: i2c-ast2600: Add support for >>>> AST2600 i2C driver >>>> >>>> On 15/02/2023 06:43, Ryan Chen wrote: >>>>>>> + - $ref: /schemas/i2c/i2c-controller.yaml# >>>>>>> + >>>>>>> +properties: >>>>>>> + compatible: >>>>>>> + enum: >>>>>>> + - aspeed,ast2600-i2c >>>>>> >>>>>> NAK. It's already there. Please do not waste our time in submitting >>>>>> duplicated drivers. >>>>> >>>>> It is not duplicated, as my description in cover " This series add >>>>> AST2600 i2c >>>> new register set driver" >>>>> So, this will be different driver compatible. >>>>> The original compatible is >>>>> - aspeed,ast2400-i2c-bus >>>>> - aspeed,ast2500-i2c-bus >>>>> - aspeed,ast2600-i2c-bus >>>>> So the new register set compatible is "- aspeed,ast2600-i2c", remove >> "bus". >>>> >>>> Bindings are documenting hardware, so I claim - we already have this >>>> hardware described and this is duplicated. Otherwise - what are these >>>> two I2C controllers and what are the differences? Why they do not >>>> have really different name? Bus looks more like a mistake than a >> differentiating name. >>> For misunderstanding, or mistaken. >>> I purpose to be aspeed,ast2600-i2cv2, will it more clear way ? >> >> I don't know. I still did not get answers. I asked here several questions. > Those are different i2c controller, as I description in cover letter. The cover letter does not explain here anything. It barely mentions "new register set" and "separate register set". This is really short, so without proper explanations you will get all these questions. Are they compatible? Do they overlap? Are they completely different? If so, why datasheet uses same name for them? So many questions but cover letter is basically two sentences and here: > The i2c new register mode, there have two separate slave/master register. > And different register with old register. you repeat the same. > So now, avoid misunderstanding, or mistaken. > I purpose to be aspeed,ast2600-i2cv2. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel