From: <Codrin.Ciubotariu@microchip.com>
To: <pierre-louis.bossart@linux.intel.com>, <alsa-devel@alsa-project.org>
Cc: alexandre.belloni@bootlin.com, lgirdwood@gmail.com,
tiwai@suse.de, linux-kernel@vger.kernel.org, tiwai@suse.com,
perex@perex.cz, Ludovic.Desroches@microchip.com,
broonie@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization
Date: Mon, 29 Mar 2021 07:32:22 +0000 [thread overview]
Message-ID: <bb884a72-84e3-0c63-9d19-35caa297ec45@microchip.com> (raw)
In-Reply-To: <20210326215927.936377-4-pierre-louis.bossart@linux.intel.com>
On 26.03.2021 23:59, Pierre-Louis Bossart wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Cppcheck complains:
>
> sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization]
> err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
> ^
> sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized
> int err = -ENXIO;
> ^
> sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten
> err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
> ^
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-29 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210326215927.936377-1-pierre-louis.bossart@linux.intel.com>
2021-03-26 21:59 ` [PATCH 02/17] ASoC: atmel: fix shadowed variable Pierre-Louis Bossart
2021-03-29 7:38 ` Codrin.Ciubotariu
2021-03-26 21:59 ` [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization Pierre-Louis Bossart
2021-03-29 7:32 ` Codrin.Ciubotariu [this message]
2021-03-26 21:59 ` [PATCH 04/17] ASoC: bcm: cygnus_ssp: " Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 05/17] ASoC: meson: axg-tdmin: remove useless assignment Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 06/17] ASoC: meson: axg-tdmout: " Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 07/17] ASoC: pxa: " Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 10/17] ASoC: stm: stm32_adfsdm: fix snprintf format string Pierre-Louis Bossart
2021-03-26 21:59 ` [PATCH 11/17] ASoC: sunxi: sun8i-codec: clarify expression Pierre-Louis Bossart
2021-03-29 8:12 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb884a72-84e3-0c63-9d19-35caa297ec45@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox