From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F3B6C2D0EF for ; Tue, 31 Mar 2020 02:55:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 418EB20578 for ; Tue, 31 Mar 2020 02:55:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DiCrwMDQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="AXkyKXnb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 418EB20578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DrftRB6d5UyNOXXwof7A6o/+MNRcrOhUNsF2/bZY0/E=; b=DiCrwMDQBLivKIe7EZv5cIZt8 ugjWAY/wsoOhtRk6GoPlA3j8tiZkEvMhyF85TSTjRmUkY9Un1IdOEtICjohrGfLnCAPmzIf6op476 jdI/uCnEeyxQq/flUqNDTKWAZXvAsVlgPJEpsJRQn8wvV9+tovBGvM1WCYXa9W/Tr9MDfUZlohY7F McVxQppBd5NcdFy8gUIa9CZ3gtwhz4ndeMKaWJelS2le016Ha2bhKph8GO1lXQVMRA4v9NCL6Gkkv GruS3ncAJibsYK+B4YUyXZewYT9uxnQmmVGalMCnGvmi6m4XZg38I7kLYznPGcGT8xLF0z8sQt3H9 xvx569OcQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJ73i-00054O-NA; Tue, 31 Mar 2020 02:55:22 +0000 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJ73f-00053T-7K for linux-arm-kernel@lists.infradead.org; Tue, 31 Mar 2020 02:55:20 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 30 Mar 2020 19:55:03 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 30 Mar 2020 19:55:16 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 30 Mar 2020 19:55:16 -0700 Received: from [10.25.76.105] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 31 Mar 2020 02:55:11 +0000 Subject: Re: [PATCH V5 5/5] PCI: tegra: Add support for PCIe endpoint mode in Tegra194 To: Bjorn Helgaas , References: <20200330214721.GA128269@google.com> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: Date: Tue, 31 Mar 2020 08:25:08 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200330214721.GA128269@google.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1585623303; bh=3ahKFXsLD6s6zihW7Lrcb4QHzaeo3c4wt/u7RD8Off8=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=AXkyKXnb8indhkbOroXPMP4WQtUfPJRj34vliLWkwdB295fSHutztOclP4xtwlFIL VUwgXUoRhEpOTHDQsvwIfChY17yF7+xfu8J1u63hVIJm2GbtQITCYFmBe2ZGUWb0pB uOZ7HACkHdbHrenA5JBlytWRzMzlt91oq0+ShC6KAe2xnEHPtuNC/35wA8L07ywvh3 uk+cm/n538EUcnSvTJREeblguG7+R12wAaSP/JNEDESPrhRK/YVS3RoKL4bKhDJOCL pKE18gpS5YJF5KgA7axDuGGih/TEkk3yquDARTo0LqkXG66ISy2QNblc91BhLEHEWj cvMTmJrwHnl/g== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200330_195519_274831_AA11730C X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, mmaddireddy@nvidia.com, kthota@nvidia.com, gustavo.pimentel@synopsys.com, linux-kernel@vger.kernel.org, kishon@ti.com, robh+dt@kernel.org, thierry.reding@gmail.com, linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, andrew.murray@arm.com, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, sagar.tv@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/31/2020 3:17 AM, Bjorn Helgaas wrote: > External email: Use caution opening links or attachments > > > On Tue, Mar 03, 2020 at 11:40:52PM +0530, Vidya Sagar wrote: >> Add support for the endpoint mode of Synopsys DesignWare core based >> dual mode PCIe controllers present in Tegra194 SoC. >> >> Signed-off-by: Vidya Sagar >> Acked-by: Thierry Reding >> --- >> V5: >> * Added Acked-by: Thierry Reding >> * Removed unwanted header file inclusion >> >> V4: >> * Addressed Lorenzo's review comments >> * Started using threaded irqs instead of kthreads >> >> V3: >> * Addressed Thierry's review comments >> >> V2: >> * Addressed Bjorn's review comments >> * Made changes as part of addressing review comments for other patches >> >> drivers/pci/controller/dwc/Kconfig | 30 +- >> drivers/pci/controller/dwc/pcie-tegra194.c | 679 ++++++++++++++++++++- >> 2 files changed, 691 insertions(+), 18 deletions(-) >> >> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig >> index 0830dfcfa43a..169cde58dd92 100644 >> --- a/drivers/pci/controller/dwc/Kconfig >> +++ b/drivers/pci/controller/dwc/Kconfig >> @@ -248,14 +248,38 @@ config PCI_MESON >> implement the driver. >> >> config PCIE_TEGRA194 >> - tristate "NVIDIA Tegra194 (and later) PCIe controller" >> + tristate >> + >> +config PCIE_TEGRA194_HOST >> + tristate "NVIDIA Tegra194 (and later) PCIe controller - Host Mode" >> depends on ARCH_TEGRA_194_SOC || COMPILE_TEST >> depends on PCI_MSI_IRQ_DOMAIN >> select PCIE_DW_HOST >> select PHY_TEGRA194_P2U >> + select PCIE_TEGRA194 >> + default y > > Sorry I missed this before, but why is this "default y"? From > Documentation/kbuild/kconfig-language.rst: > > The default value deliberately defaults to 'n' in order to avoid > bloating the build. With few exceptions, new config options should > not change this. The intent is for "make oldconfig" to add as little > as possible to the config from release to release. > > I do see that several other things in other drivers/pci/ Kconfig files > are also "default y", and we should probably change some of them. But > I don't want to add even more unless there's a good reason. > > I'm not looking for more reactions like these: > > https://lore.kernel.org/r/CAHk-=wiZ24JuVehJ5sEC0UG1Gk2nvB363wO02RRsR1oEht6R9Q@mail.gmail.com > https://lore.kernel.org/r/CA+55aFzPpuHU1Nqd595SEQS=F+kXMzPs0Rba9FUgTodGxmXsgg@mail.gmail.com > > Can you please update this patch to either remove the "default y" or > add the rationale for keeping it? I'm fine with removing 'default y' line. Should I send a patch only with this change? Thanks, Vidya Sagar > >> + help >> + Enables support for the PCIe controller in the NVIDIA Tegra194 SoC to >> + work in host mode. There are two instances of PCIe controllers in >> + Tegra194. This controller can work either as EP or RC. In order to >> + enable host-specific features PCIE_TEGRA194_HOST must be selected and >> + in order to enable device-specific features PCIE_TEGRA194_EP must be >> + selected. This uses the DesignWare core. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel