From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2C15C43334 for ; Tue, 7 Jun 2022 00:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pRZg1iaUPGaR+h20KpaLK84KiEnV1r+g/ViMzXHhhNA=; b=TTZX/nOP1LQZlO PGNGOMp526L6DN0dT2o78sZUCrjlI8P8oYEr0jIRR701/emSCv7epkk0RmdGaWJJ9vtjbAZX0hY93 vqvw/NLyz0dcUtjpQWZ2oynpXyRGbXZ4wzilhCFkl0ZB2np+k82sjup67dF3p5QdG1+MqTBxbB/hv 4qI9q7uPYKXoiYJ7Y52wfWrplJJX1M9BWeBReCiJjsKg+6EuRUwwDmoCfVCarzoyr8QRtEkUQ/HzC XV8Xs4S5KzVagZ4DxCudWCd2wDJ2UmVvVSsq0e9gW4SLeSq95QHAsD05tK5OdwUYuekxPPuLQZw5N 6njzzLuydQlxAmgFqH9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyNQq-003w8a-Kf; Tue, 07 Jun 2022 00:50:52 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyNQn-003w8C-HO for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 00:50:50 +0000 Received: from [192.168.87.104] (unknown [50.47.106.71]) by linux.microsoft.com (Postfix) with ESMTPSA id 87E1320BE625; Mon, 6 Jun 2022 17:50:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 87E1320BE625 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1654563047; bh=mNIWq9mEXLrb2v1fqG+qEYhLSaH2HfCn23YiIjp/ozs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MmasGyKFt3+ENYRwLKiFpoiehKjYBtnkFGsVFLDwFYkPbHgu4xCmT9g3LpBW98z80 QZqERPjYGTiFrDX5ozdsaBbkYtYsVNQW2IAFvxy8LczsPaFDWcNSo+EoVpO3wT/ykY tQ2GxmhBC/gs2UkznfLjNQ6TI1QR9WyzwWInZ7lc= Message-ID: Date: Mon, 6 Jun 2022 17:50:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 3/5] ARM: dts: aspeed: Add HACE device controller node Content-Language: en-US To: Neal Liu , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Johnny Huang Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, BMC-SW@aspeedtech.com, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220606064935.1458903-1-neal_liu@aspeedtech.com> <20220606064935.1458903-4-neal_liu@aspeedtech.com> From: Dhananjay Phadke In-Reply-To: <20220606064935.1458903-4-neal_liu@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_175049_655207_70A10EEF X-CRM114-Status: UNSURE ( 8.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/5/2022 11:49 PM, Neal Liu wrote: > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index 3d5ce9da42c3..371d2a6b56ef 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -304,6 +304,14 @@ apb { > #size-cells = <1>; > ranges; > > + hace: crypto@1e6d0000 { > + compatible = "aspeed,ast2600-hace"; > + reg = <0x1e6d0000 0x200>; > + interrupts = ; > + clocks = <&syscon ASPEED_CLK_GATE_YCLK>; > + resets = <&syscon ASPEED_RESET_HACE>; Shouldn't the left side be also 'crypto', see existing crypto nodes in arch/arm64/dts for example. crypto: crypto@1e6d0000 { ... Regards, Dhananjay _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel