From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C23C48BDF for ; Thu, 24 Jun 2021 10:16:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90387613FB for ; Thu, 24 Jun 2021 10:16:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90387613FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zjD4pXsZmI+BUjQNOh5w5cF9r2djLeiBwc3HjCYCrRY=; b=0Ur4/Xk3wO4IEZCoKoaxA+MlcE dH8KMTe4iwtgDBwMPh7PK+0lrCJRU6DIWhM1n92nhEmqMF1jEuz5ygPanL76/WVgZ842wLSvP7HBd T4LVp6p5wU4yX9D0wKI839rqoLjK1CpFrNHO1aiTLsE5Oe50t72glsnemAPCGLw757gkC2TUw4y4d WkQNwP5bdo5XY6ieL0Y9WgOkEMHC1Mch0wnvqyLibUK0WGqikpFFfYRaN68IhXqb0wwlwDq2jug7k gdHK4r9D803vzcaUUwhfqnzjPB6TNKhH/en/ctNGVXJx5MXTx7Ewe7hnQGnvkIJ/C6cXarpizCZ41 5RiGX6Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwMNw-00E02J-O3; Thu, 24 Jun 2021 10:15:00 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwMMz-00DzFK-VC for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 10:14:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624529640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qgeFYkU0pR1Q1xO1W6kYeH0XfpPQ577wwQcLewdoy9I=; b=C4fJMYlyXOYFpPhsPy1vz2dgiKNtgYeXnf2Y6/fmC4MIieSXk2suAoRLv2d06iqAl6PY01 3Nz1og9YsiGkL3UJjq91DaNiVB2jGqB5uoOuS6mIom482jv7bm5fjAjBzrAWCmphS38SVN 2lIADXMQJUlWrTg6XHU3hw4qPYrlkfY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-493-Go8WSDGEOTeJjbH2COc-OA-1; Thu, 24 Jun 2021 06:13:56 -0400 X-MC-Unique: Go8WSDGEOTeJjbH2COc-OA-1 Received: by mail-wr1-f70.google.com with SMTP id l2-20020adfe5820000b029011a64161d6aso2024038wrm.6 for ; Thu, 24 Jun 2021 03:13:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qgeFYkU0pR1Q1xO1W6kYeH0XfpPQ577wwQcLewdoy9I=; b=O/xk1/JRJwWbKKFKasjTzne4wtV8W3z0+2+DqwCogWrnbqpjgfL3Y8KrdTK18eLZXR PJgH/0c+tjbkaeOW+sN/37CPmaE5jlu3fCg9onBYfDDlDTcXLbHm75iwQ8LY8HPJxArr hhNeznbjOrsYYrYL5bTT0HMR98eK4/lrvNbXMlpikxblvmoyKmG+7+YuBTcvwBXKw7mm 4NyglhMY1zJw5xmF+mq8EM+dadroka28UOoGoUAtZtWUdTBoAYEcKKYMfYIcaXd9u5Vt smZ3Ds7Hh35h4wSth2ri0jxB7/0rodw2VSL/DQUGol9JMxXx0FSCt5y/ZKXMe0MqQQjT SN/w== X-Gm-Message-State: AOAM531hAPWWTZlosgF6YjGyQ4KhBH3xA+Z+KqdLriqUv1i//VNgQpZA WerTckKiFMjHvD62g9+oyhdWMP5zf4OQf8J7K+zqDNdnc9pZid4M28Mf9gN7lTr3ldrwap/3aBF XkwZGi2d9qTHZIauZv8ypsOk5SDRD+2Huyks= X-Received: by 2002:adf:e80c:: with SMTP id o12mr3526064wrm.425.1624529635765; Thu, 24 Jun 2021 03:13:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwystGI+L9gOrbELlIiJWJblqcplIdniKN++kkqVaKxE8NfJktozv1x7SoGv2eSTMa2UzUKpw== X-Received: by 2002:adf:e80c:: with SMTP id o12mr3526053wrm.425.1624529635607; Thu, 24 Jun 2021 03:13:55 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id q19sm8207562wmc.44.2021.06.24.03.13.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 03:13:55 -0700 (PDT) Subject: Re: [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang Cc: Alexandru Elisei , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, James Morse , Jim Mattson , Joerg Roedel , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sean Christopherson , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Will Deacon References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-3-stevensd@google.com> <1624524331.zsin3qejl9.astroid@bobo.none> <201b68a7-10ea-d656-0c1e-5511b1f22674@redhat.com> <1624528342.s2ezcyp90x.astroid@bobo.none> From: Paolo Bonzini Message-ID: Date: Thu, 24 Jun 2021 12:13:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1624528342.s2ezcyp90x.astroid@bobo.none> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_031402_111444_E4441DFC X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/06/21 11:57, Nicholas Piggin wrote: >> Needing kvm_pfn_page_unwrap is a sign that something might be buggy, so >> it's a good idea to move the short name to the common case and the ugly >> kvm_pfn_page_unwrap(gfn_to_pfn(...)) for the weird one. In fact I'm not >> sure there should be any kvm_pfn_page_unwrap in the end. > > If all callers were updated that is one thing, but from the changelog > it sounds like that would not happen and there would be some gfn_to_pfn > users left over. In this patches there are, so yeah the plan is to always change the callers to the new way. > But yes in the end you would either need to make gfn_to_pfn never return > a page found via follow_pte, or change all callers to the new way. If > the plan is for the latter then I guess that's fine. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel