From: Markus Elfring <Markus.Elfring@web.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>,
Boris Brezillon <bbrezillon@kernel.org>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Johan Hovold <johan@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: rtc: at91sam9: fix OF node leak in probe() error path
Date: Mon, 26 Aug 2024 09:12:32 +0200 [thread overview]
Message-ID: <bbc43cc6-0ee9-4cfd-b642-ac888ad9e627@web.de> (raw)
In-Reply-To: <391cc2f7-4a88-4565-8653-e46bd77e28f8@linaro.org>
>>> Driver is leaking an OF node reference obtained from
>>> of_parse_phandle_with_fixed_args().
>>
>> Is there a need to improve such a change description another bit?
>>
>> + Imperative mood
…
> Commit msg is fine.
…
>> + Tags like “Fixes” and “Cc”
>
> Read the patch.
What does hinder you to take requirements from a known information source
better into account?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc5#n94
Regards,
Markus
next prev parent reply other threads:[~2024-08-26 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 18:31 [PATCH] rtc: at91sam9: fix OF node leak in probe() error path Krzysztof Kozlowski
2024-08-25 19:35 ` Markus Elfring
2024-08-26 6:59 ` Krzysztof Kozlowski
2024-08-26 7:12 ` Markus Elfring [this message]
2024-08-26 7:30 ` Greg KH
2024-09-11 22:30 ` [PATCH] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbc43cc6-0ee9-4cfd-b642-ac888ad9e627@web.de \
--to=markus.elfring@web.de \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=bbrezillon@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox